Re: [pgadmin-hackers] pgAdmin III - Default server info from postgres-reg.ini not getting picked up

2011-05-31 Thread Nikhil S
> Thanks, applied. > > Thanks Dave. Regards, Nikhils

[pgadmin-hackers] pgAdmin III - Default server info from postgres-reg.ini not getting picked up

2011-05-31 Thread Nikhil S
Hi, In case of postgres-reg.ini only containing PPAS server information, it is not being picked up properly by pgAdmin. The issue is in pgServerFactory::CreateObjects() function. Even though the server information is being read correctly from the file, it is not being appended correctly into the b

Re: [pgadmin-hackers] Re: pgadmin III - "Display objects" part of database restore errors out in non-English locales

2011-05-19 Thread Nikhil S
Thanks Dave. Regards, Nikhils On Thu, May 19, 2011 at 9:15 PM, Dave Page wrote: > Thanks - applied. > > On Wed, May 18, 2011 at 12:03 PM, Nikhil S wrote: > > Please ignore the last patch. Some unwanted debug changes in there! > > Please use this one. > > > >

[pgadmin-hackers] Re: pgadmin III - "Display objects" part of database restore errors out in non-English locales

2011-05-18 Thread Nikhil S
Please ignore the last patch. Some unwanted debug changes in there! Please use this one. Regards, Nikhils On Wed, May 18, 2011 at 5:28 PM, Nikhil S wrote: > Hi, > > So, I changed the locale on my setup to "zh_CN.UTF-8" and tried to restore > into a database using a backu

[pgadmin-hackers] pgadmin III - "Display objects" part of database restore errors out in non-English locales

2011-05-18 Thread Nikhil S
Hi, So, I changed the locale on my setup to "zh_CN.UTF-8" and tried to restore into a database using a backup from earlier. When I click on "Display objects" tab, I see an error being displayed, although the actual restore happens just fine. Note that no error occurs in English locales. Took me a

Re: [pgadmin-hackers] Warning about PNGs

2011-05-05 Thread Nikhil S
> > When was the last time you ran the bootstrap script? > > Apparently never :P Did it now and things are kosher. Sorry for the noise. Regards, Nikhils

Re: [pgadmin-hackers] Warning about PNGs

2011-05-05 Thread Nikhil S
> What issue? If you cannot build png2c, you're not going to be able to > build the rest of pgAdmin. > > Am using the default configure command: ./configure --with-pgsql=/home/pg/pg_database/ Which completes ok AFAICS. Then the make errors out: make all-recursive make[1]: Entering directory `/h

Re: [pgadmin-hackers] Warning about PNGs

2011-05-05 Thread Nikhil S
Hi, I also face issues while compiling pgadmin on my ubuntu. It has issues compiling xtra/png2c directory. Till date, I have circumvented this issue by removing this directory manually from the Makefile :) Regards, Nikhils On Wed, May 4, 2011 at 11:04 PM, Dave Page wrote: > On Wed, May 4, 2011

Re: [pgadmin-hackers] pgAdmin III: erroneous references to "proargdefvals" attribute

2011-04-28 Thread Nikhil S
Thanks Dave. Regards, Nikhils On Thu, Apr 28, 2011 at 6:58 PM, Dave Page wrote: > Thanks, applied. > > On Thu, Apr 28, 2011 at 10:59 AM, Nikhil S wrote: > > Hi, > > > >> > >> The pgAdmin source base is peppered with references to a non-existent > >

Re: [pgadmin-hackers] pgAdmin III: erroneous references to "proargdefvals" attribute

2011-04-28 Thread Nikhil S
Hi, > The pgAdmin source base is peppered with references to a non-existent > "proargdefvals" attribute. Ok, this was being used in AS83, so we cannot remove these references completely. > The FEATURE_FUNCTION_DEFAULTS feature will not get set because of this > ever. This patch replaces the r

[pgadmin-hackers] pgAdmin III: erroneous references to "proargdefvals" attribute

2011-04-27 Thread Nikhil S
Hi, The pgAdmin source base is peppered with references to a non-existent "proargdefvals" attribute. The FEATURE_FUNCTION_DEFAULTS feature will not get set because of this ever. This patch replaces the references to this attribute by the valid "proargdefaults" attribute. Regards, Nikhils diff --g

Re: [pgadmin-hackers] pgAdmin III: debugger does not handle PPAS functions with OUT parameters properly

2011-04-01 Thread Nikhil S
> > Thanks, applied. > > Thanks Dave. How's the lunch on the cruise? ;) Regards, Nikhils

[pgadmin-hackers] pgAdmin III: debugger does not handle PPAS functions with OUT parameters properly

2011-04-01 Thread Nikhil S
Hi, In PPAS 90, if an SPL-function has both an OUT-parameter and a return value (which is not possible on PostgreSQL otherwise), the return value is transformed into an extra OUT-parameter named "_retval_". Although we fixed the normal code path a while back, the debugger still remains dazed and c

Re: [pgadmin-hackers] pgAdmin III: comments on PPAS 9.0 functions not working properly

2011-03-31 Thread Nikhil S
Thanks, applied. > > Thanks Dave. Regards, Nikhils > On Thu, Mar 31, 2011 at 8:15 AM, Nikhil S wrote: > > Hi, > > > > Consider the following PPAS 9.0 function: > > > > CREATE OR REPLACE FUNCTION TEST_in_inout_out(A IN INT, B IN OUT INT, C > OUT

[pgadmin-hackers] pgAdmin III: comments on PPAS 9.0 functions not working properly

2011-03-31 Thread Nikhil S
Hi, Consider the following PPAS 9.0 function: CREATE OR REPLACE FUNCTION TEST_in_inout_out(A IN INT, B IN OUT INT, C OUT INT) RETURN INT IS D INT; BEGIN D := A + B + C; RETURN D; END; When I click on properties and try to assign a comment to this function, it errors out. In PPAS 9.

Re: [pgadmin-hackers] pgAdmin III: use proper functions to retrieve information related to PPAS packages

2011-03-05 Thread Nikhil S
> Damn that Heikki bloke :-) > > Hehe :) > Thanks - applied with a minor change to the variable name. > > Thanks Dave. Regards, Nikhils

[pgadmin-hackers] pgAdmin III: use proper functions to retrieve information related to PPAS packages

2011-03-05 Thread Nikhil S
Hi, In PPAS 9.0, two new functions have been introduced to retrieve information related to package elements. We need to incorporate the same as the old sql query will not work anymore. Regards, Nikhils diff --git a/pgadmin/schema/edbPackage.cpp b/pgadmin/schema/edbPackage.cpp index f1cec72..d703e

Re: [pgadmin-hackers] pgAdmin III: system schemas under incorrect hiearchy in EDBAS PostgreSQL mode

2011-02-28 Thread Nikhil S
> Thanks - applied (with a minor tweak to make it work) :-p > > Heh, thanks Dave :) Regards, Nikhils > On Fri, Feb 25, 2011 at 3:05 PM, Nikhil S wrote: > > Hi, > > > > If we use pgadmin III to browse a PPAS database that was installed in > > Postgresql mode

[pgadmin-hackers] pgAdmin III: system schemas under incorrect hiearchy in EDBAS PostgreSQL mode

2011-02-25 Thread Nikhil S
Hi, If we use pgadmin III to browse a PPAS database that was installed in Postgresql mode, the "sys" and "dbo" system schemas appear incorrectly under the normal user "Schemas" hierarchy. The issue is occurring because the current sql in pgSchemaBaseFactory::CreateObjects() which tries to avoid sh

Re: [pgadmin-hackers] pgAdmin III: adjust code as per new EDB AS90 functions/procedures semantics

2011-02-23 Thread Nikhil S
Thanks Dave! Regards, Nikhils On Wed, Feb 23, 2011 at 3:57 PM, Dave Page wrote: > Thanks, patch applied to trunk and 1.12. > > On Mon, Feb 21, 2011 at 9:17 AM, Nikhil S wrote: > > Hi, > > > > In EDBAS 9.0, following notable restructuring has been done with res

Re: [pgadmin-hackers] pgAdmin III: adjust code as per new EDB AS90 functions/procedures semantics

2011-02-21 Thread Nikhil S
ems low risk. > > +1 from the patch-submitter (if it counts ;)) Regards, Nikhils > On Mon, Feb 21, 2011 at 9:17 AM, Nikhil S wrote: > > Hi, > > > > In EDBAS 9.0, following notable restructuring has been done with respect > to > > functions and procedures. We need

[pgadmin-hackers] pgAdmin III: adjust code as per new EDB AS90 functions/procedures semantics

2011-02-21 Thread Nikhil S
Hi, In EDBAS 9.0, following notable restructuring has been done with respect to functions and procedures. We need to adopt the same in the pgAdmin code base. Note that these changes make EDBAS funcs/procs behave more like native Postgres functions which is a good thing: * To debug edb-SPL functio

Re: [pgadmin-hackers] pgAdmin III: the debugger does not pre-populate default values for arguments

2011-02-16 Thread Nikhil S
Thanks Dave! > On Mon, Feb 14, 2011 at 12:53 PM, Nikhil S wrote: > > > >> > Ok. One way that I can think of is that since we have the typeoids > >> > handily > >> > available, we can check the same and see if it is of stringlike type > >>

Re: [pgadmin-hackers] pgAdmin III: the debugger does not pre-populate default values for arguments

2011-02-14 Thread Nikhil S
> > Ok. One way that I can think of is that since we have the typeoids > handily > > available, we can check the same and see if it is of stringlike type > > (PGOID_TYPE_CHAR, PGOID_TYPE_NAME, PGOID_TYPE_TEXT, etc..). If yes, then > we > > retain the "", else we ignore it. Sounds reasonable? > > Ye

Re: [pgadmin-hackers] pgAdmin III: the debugger does not pre-populate default values for arguments

2011-02-14 Thread Nikhil S
Hi, > But I guess you mean, we should find a solution more on the pgadmin side > > instead of tinkering with the backend? > > Yes. > > Ok. One way that I can think of is that since we have the typeoids handily available, we can check the same and see if it is of stringlike type (PGOID_TYPE_CHAR, P

Re: [pgadmin-hackers] Re: pgAdmin III: Error on clicking "Display Objects" while doing a restore

2011-02-13 Thread Nikhil S
Hi Prajwal, The issue just pops up a benign error message. If you continue further you should be able to proceed with the restore process. Regards, Nkhils On Sun, Feb 13, 2011 at 2:25 PM, Prajwal wrote: > > Hi Nikhil, > > I am new to PostgreSQL. > I do need to restore the database on Postgres

Re: [pgadmin-hackers] pgAdmin III: the debugger does not pre-populate default values for arguments

2011-02-11 Thread Nikhil S
> > Hmmm, well variables can default to NULL too. The backend code tries to > > track those variables which default to NULL or to other values. For the > > rest, it defaults them to "". It then uses construct_md_array to generate > > the output string for type TEXTOID. Dunno if we can have nothing

Re: [pgadmin-hackers] pgAdmin III: the debugger does not pre-populate default values for arguments

2011-02-11 Thread Nikhil S
> > > Note that if there are no default values, the the defvals column is > > completely empty. Now why we see the "" for non-default arguments - the > > issue seems to be on the server side in the contrib module calls to > compute > > the default values. > > We need to change that then - we can't

Re: [pgadmin-hackers] pgAdmin III: the debugger does not pre-populate default values for arguments

2011-02-10 Thread Nikhil S
Hi, On Thu, Feb 10, 2011 at 8:48 PM, Dave Page wrote: > On Mon, Feb 7, 2011 at 9:03 AM, Nikhil S wrote: > > One side-effect of this feature is that earlier where non-default > variables > > appeared as empty, they will now appear with values "". This will happen >

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-10 Thread Nikhil S
> Thanks - applied. > > Thanks Dave. Regards, Nikhils > On Mon, Feb 7, 2011 at 1:01 PM, Nikhil S wrote: > > Hi, > > > > If one clicks on Postgres (non EDB) database and tries to expand the > schema > > tab, then the current git head spits out an erro

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-07 Thread Nikhil S
> Well, the SQL does get fired against a PG database in the EDBAS mode for > me. I too was puzzled about the minimum version check being EDBAS specific. > > Just checked. The version checker function checks for the version number and also for a bool which is set to true in EDBAS mode. So yeah, this

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-07 Thread Nikhil S
> I"m not sure I understand. You first said that the bug is on regular > PostgreSQL (and I can't reproduce it on 9.0 regular PostgreSQL). When > you explain the bug and if I read correctly your patch, it fixes EDB > database only. > > So is it a fix for EDB databases or PostgreSQL databases? > > We

[pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-07 Thread Nikhil S
Hi, If one clicks on Postgres (non EDB) database and tries to expand the schema tab, then the current git head spits out an error. The offending query contains the following comparison protype = 1; protype is of type char, so it expects the RHS to be a char. However this works ok against an EDB

[pgadmin-hackers] pgAdmin III: the debugger does not pre-populate default values for arguments

2011-02-07 Thread Nikhil S
Hi, The debugger, when it is invoked on a function or a procedure, provides a dialogue box to fill up values for the arguments. In case the user has created them with some default values assigned to some of the parameters, then they would expect that the debugger pre-populates them with those defa

Re: [pgadmin-hackers] Hiding Schedules/Step tabs while creating a new pgAgent job

2011-02-06 Thread Nikhil S
> > > When creating a new job, if one directly clicks on the Schedules tab and > > tries to add one, then the date picker does not work. I was trying to see > > why this is so for quite a while. Then I realized that adding a schedule > or > > a step before the job has been actually created does no

[pgadmin-hackers] Hiding Schedules/Step tabs while creating a new pgAgent job

2011-02-06 Thread Nikhil S
Hi, When creating a new job, if one directly clicks on the Schedules tab and tries to add one, then the date picker does not work. I was trying to see why this is so for quite a while. Then I realized that adding a schedule or a step before the job has been actually created does not make sense. H

Re: [pgadmin-hackers] pgAdmin III: 'public' schema not selected by default for "Default Privileges" tab

2011-02-04 Thread Nikhil S
> > If one right clicks on database and goes to properties, there the > "Default > > Privileges" tab does not seem to contain the 'public' schema > pre-selected. > > It is so the case in the normal "Privileges" for example. This patch > > pre-populates the 'public' schema for the default privileges

Re: [pgadmin-hackers] pgAdmin III: synonym support for EDBAS functions/procedures

2011-02-04 Thread Nikhil S
> Nah - I meant to do it yesterday, but ended up spending all day trying > to figure out why I couldn't detect a focus event on a notebook page > properly. > > Committed - thanks! > > Thanks Dave. Regards, Nikhils

[pgadmin-hackers] pgAdmin III: 'public' schema not selected by default for "Default Privileges" tab

2011-02-03 Thread Nikhil S
Hi, If one right clicks on database and goes to properties, there the "Default Privileges" tab does not seem to contain the 'public' schema pre-selected. It is so the case in the normal "Privileges" for example. This patch pre-populates the 'public' schema for the default privileges case too. Reg

Re: [pgadmin-hackers] pgAdmin III: synonym support for EDBAS functions/procedures

2011-02-03 Thread Nikhil S
Hi Dave, > > > I'm inclined to consider this a bug, as my failure to update this > > prior to the release of 1.12 means that our support for that feature > > is essentially broken. > > > > Does anyone object, before I commit it to 1.12? > > > > No objection here. > > > Aye from the patch submitter

[pgadmin-hackers] pgAdmin III: synonym support for EDBAS functions/procedures

2011-02-01 Thread Nikhil S
Hi, Since EDB AS 8.4, we support synonyms for functions and procedures. I checked support for both plpgsql functions and edbspl functions and procedures. However the create synonym dialogue only provides "Sequence, Synonym, Table and View" as target types. We need to add functions and procedures t

Re: [pgadmin-hackers] pgAdmin III: EDB procedures with non void return types not handled properly

2011-01-31 Thread Nikhil S
> Thanks. This seems to be a bug in fact, as it could mis-identify a > function that returns void as a procedure. > > Applied for 1.12.3 and master. > > Thanks Dave. Regards, Nikhils

[pgadmin-hackers] pgAdmin III: EDB procedures with non void return types not handled properly

2011-01-30 Thread Nikhil S
Hi, With the latest refactorings in the EDBAS90 source base, procedures (CREATE PROCEDURE objects) can have non void return types in some cases. For example: edb=# create or replace procedure set_Order ( v_indexINOUT integer ) AS counterinteger; BEGIN counter := 0; v_

Re: [pgadmin-hackers] pgAdmin III: Error on clicking "Display Objects" while doing a restore

2011-01-30 Thread Nikhil S
> Just applied. > > This issue was bugging me too, but I couldn't find a proper fix. So, > thanks a lot for this :) > > Glad to be of some help :). Thanks Guillaume. Regards, Nikhils

[pgadmin-hackers] pgAdmin III: Error on clicking "Display Objects" while doing a restore

2011-01-29 Thread Nikhil S
Hi, The following set of operations induce an error: 1. Create a backup file /tmp/pg.backup of an existing database 2. Create a new database 3. Right click and select restore database by specifying this file 4. Clicking on "Display Objects" causes the following error: "An error has occurred: Sche

Re: [pgadmin-hackers] pgAdmin III: crash when trying to save edited pg_hba.conf

2011-01-29 Thread Nikhil S
> Seems good enough. Commited. Thanks a lot :) > > Thanks a lot! Regards, Nikhils

[pgadmin-hackers] pgAdmin III: crash when trying to save edited pg_hba.conf

2011-01-28 Thread Nikhil S
Hi, The following set of operations induce a crash in the latest git code base: 1. Open pgAdmin III 2. Go to File Menu->Open Postgressql.conf 3. From data folder select pg_hba.conf file and open it 4. The file opens successfully 5. Now select any setting ("port" for example) and add a Value and C