[pgadmin-hackers] Pgadmin 1.22.1 binaries for win32 and osx

2016-02-26 Thread Nikolai Zhubr
Hello Dave, Haven't you forgot to publish standalone pgadmin 1.22.1 binaries (win32 and osx)? (http://www.postgresql.org/ftp/pgadmin3/release/v1.22.1/) Thank you, Nikolai -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://

Re: [pgadmin-hackers] pgAdmin 3 update

2016-02-08 Thread Nikolai Zhubr
Hello Dave, 08.02.2016 12:48, Dave Page: Just a quick heads-up - I'm going to wrap 1.22.1 today ready to go out with the PG updates later this week. There have been a few tweaks and fixes since 1.22.0, so it seems like a good idea. Indeed, sounds good. Whould there be some preliminary windows b

Re: [pgadmin-hackers] pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390

2016-01-07 Thread Nikolai Zhubr
Hello all, Would it also go to REL-1_22_0_PATCHES (so as to be included in the upcoming release)? Thank you, Nikolai 07.01.2016 15:54, Ashesh Vashi: [...] - Return value of the function will be displayed as "SETOF record" instead of "SETOF SETOF record" under SQL

Re: [pgadmin-hackers] pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390

2016-01-07 Thread Nikolai Zhubr
Hello all, 05.01.2016 15:24, Neel Patel: Hi, Please find attached patch file with below fix. - Return value of the function will be displayed as "SETOF record" instead of "SETOF SETOF record" under SQL tab within properties window. Let me know for any comments. Confirmed OK. Please commit.

Re: [pgadmin-hackers] pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390

2016-01-05 Thread Nikolai Zhubr
Hi all, Running 1.22-rc1 now I observe that this commit has apparently still not solved the issue in at least one place. That is: - "RETURNS SETOF record" is correctly displayed in SQL panel now. - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL tab within the propertie

[pgadmin-hackers] Small bug in function declaration sql generator

2015-10-11 Thread Nikolai Zhubr
Hello all, I've found some issue with function declaration sql generator apparently. In the example below (just pasted this from SQL pane now), it obviously generated one excessive 'SETOF' keyword. CREATE OR REPLACE FUNCTION util_csv2table( IN arg_src_str text, OUT par_name character

Re: [pgadmin-hackers] [PATCH] Beautify line-ends handling yet more.

2015-10-10 Thread Nikolai Zhubr
Hello Dave, 10.10.2015 16:51, Dave Page wrote: [...] * Unix/Mac (LF) * DOS/Windows (CRLF) If it is OK then I'll craft a git diff for that (eventually). I'm not sure we should - it may be useful for someone working with legacy systems, and it's not like it's a massive amount of code bloating t

Re: [pgadmin-hackers] [PATCH] Beautify line-ends handling yet more.

2015-10-10 Thread Nikolai Zhubr
Hello Dave, 09.10.2015 16:31, Dave Page wrote: [...] I committed a modified version of this - Mac OS X uses \n as a line-end, so that makes a better default than the old-style \r used on Mac classic. Ah, I didn't know that, thanks for explanation. I suppose it is unlikely someone will use curr

[pgadmin-hackers] [PATCH] Beautify line-ends handling yet more.

2015-10-07 Thread Nikolai Zhubr
Hello Dave, Attached are two more patches, mostly cosmetic: * Make a better guess of default line-end type based on platform type. * Get rid of #ifdef -- let wxTextBuffer::Translate do all the work. Sending as attachments, let me know if inserting inline is preferred. Tested on windows only,

[pgadmin-hackers] [PATCH] Perform conversion to platform line-ends when copying to clipboard (Was: Copy to clipboard from ctlSQLBox on windows has line ends broken)

2015-10-06 Thread Nikolai Zhubr
Hello Dave, Apparently the problem was accidentally introduced by some little refactoring as a part of this big commit: http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commitdiff;h=ac60bb573155cd24fc45aa08a41887c1bb612677 Previously, frmMain::OnCopy() used to call sqlPane->Copy() to push

Re: [pgadmin-hackers] Copy to clipboard from ctlSQLBox on windows has line ends broken.

2015-10-06 Thread Nikolai Zhubr
Hi all, As I've now found, a lot of pgXXX::GetSql() functions autogenerate sql code using hardcoded LF line ends ('\n\n'), and this has been so for ages, therefore probably it is OK. But, in order for 'copy to clipboard' to work well (also on ms windows), these LF line ends have to be someho

[pgadmin-hackers] Copy to clipboard from ctlSQLBox on windows has line ends broken.

2015-10-06 Thread Nikolai Zhubr
Hi all, Just discovered this. Only applicable for ms windows probably. Copying several lines of text to clipboard from the SQL info panel - the one normally located in the bottom-right corner of the main pgadmin window (not editable) - results in broken line-ends when pasting. It used to work

[PATCH] Fix EVT_STC_PAINTED recursion issue (Was: Re: [pgadmin-hackers] Repaint lockup in ctlSQLBox::OnPositionStc on windows)

2015-10-04 Thread Nikolai Zhubr
Hi all, 04.10.2015 7:32, J.F. Oster wrote: Hello Nikolai, Appreciate your research! I suggest you to send a *.patch (git diff) attachmeht to the list for the team members and others interested to test it in their environments. Well, technically I can, but it will be ugly, see below. Problem i

Re: [pgadmin-hackers] [Patch] Windows installer: allow manually setting WIXDIR as appropriate.

2015-10-04 Thread Nikolai Zhubr
Hi all, 04.10.2015 7:55, J.F. Oster wrote: Hello, +1 I proposed the same once but had no feedback. I'm actually surprised by the very low feedback on the list altogether. Nikolai, why doesn't the first version work for you? I have it done similar: Because if the variable itself contains qu

[pgadmin-hackers] Repaint lockup in ctlSQLBox::OnPositionStc on windows (Was: SQL-panel causes 100% CPU and lockup on windows)

2015-10-03 Thread Nikolai Zhubr
Hi all, ok, it is broken since this commit: http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=patch;h=b0ecbbca7f77c0f07cff67bba3d2bca28954a1e2 - EVT_STC_UPDATEUI(-1, ctlSQLBox::OnPositionStc) + EVT_STC_PAINTED(-1, ctlSQLBox::OnPositionStc) It appears that in previous version of scintill

Re: [pgadmin-hackers] Building pgadmin on windows - instructions?

2015-10-02 Thread Nikolai Zhubr
Hi all, after 2.5 days of fight I was able to produce a new shining pgadmin3, even with an installer. What a relief. It runs, and has that unfortunate bug still at the same place :) Now going to investigate the bug itself as time permits. As a side effect, I now have a detailed and valid ins

Re: [pgadmin-hackers] [Patch] Windows installer: allow manually setting WIXDIR as appropriate.

2015-10-02 Thread Nikolai Zhubr
Hi again, there is some problem in my previous patch, it did not actually work, here goes a better one: --- pkg/win32/Make.bat.orig Fri Sep 25 13:20:24 2015 +++ pkg/win32/Make.bat Fri Oct 02 21:55:27 2015 @@ -9,7 +9,9 @@ SET APPKEYWORDS=PostgreSQL, pgAdmin SET APPCOMMENTS=PostgreSQL Too

[pgadmin-hackers] [Patch] Windows installer: allow manually setting WIXDIR as appropriate.

2015-10-02 Thread Nikolai Zhubr
Hi all, How about allowing wix3 to be located in a different path, pointed to by setting WIXDIR environment variable _manually_ before building. The following patch allows doing so, while fully retaining previous behaviour in case this variable was not manually set. (E.g. when building in a 3

[pgadmin-hackers] [Patch] Update the version number for windows installer?

2015-10-02 Thread Nikolai Zhubr
Hi all, shouldn't the following be applied to git already? --- pkg/win32/Installer.vcxproj.origFri Oct 02 18:02:48 2015 +++ pkg/win32/Installer.vcxproj Fri Oct 02 21:01:04 2015 @@ -31,7 +31,7 @@ Condition="'$(Configuration)|$(Platform)'=='All|Win32'"> Calling installer build

Re: [pgadmin-hackers] Building pgadmin on windows - instructions?

2015-10-02 Thread Nikolai Zhubr
Hi Dave, 02.10.2015 14:10, Dave Page write: apparenly switched to using wxwidgets 3.0. However, pgAdmin3 1.20 for windows released after that date, on 19-Dec-2014 is still bundled with wxwidgets 2.8 (And 19-Dec is supposedly later than 27-Jan) We added initial support for it. We didn't switch t

Re: [pgadmin-hackers] Building pgadmin on windows - instructions?

2015-10-02 Thread Nikolai Zhubr
Hi all, According to git.postgresql.org, since 27-Jan-2014 the pgAdmin3.sln has apparenly switched to using wxwidgets 3.0. However, pgAdmin3 1.20 for windows released after that date, on 19-Dec-2014 is still bundled with wxwidgets 2.8 (And 19-Dec is supposedly later than 27-Jan) How is that?

[pgadmin-hackers] Add options (checkboxes) to disable folding/unfolding and highlighting in SQL-editor

2015-09-30 Thread Nikolai Zhubr
Hi all, I'd like to propose adding new checkboxes in the editor section of pgadmin preferences, allowing to disable code folding/unfolding and highlighting features. (By default, features would be enabled, retaining exactly current visual experience.) I personally rather like highlighting (if

[pgadmin-hackers] Building pgadmin on windows - instructions?

2015-09-29 Thread Nikolai Zhubr
Hi all, I'm starting to try building pgadmin on windows (and for windows) myself and I'm facing some uncertainty. INSTALL says to install "Microsoft Visual C++ 2010" and "Windows 2010 Platform SDK". I'm totally ignorant regrading miscrosoft developer tools (sorry), but anyway I have not foun

[pgadmin-hackers] Re: [pgadmin-support] SQL-panel causes 100% CPU and lockup on windows (Was Stability and compatability issues on windows xp)

2015-09-29 Thread Nikolai Zhubr
Hi, 29.09.2015 1:17, I wrote: [...] Here is how to reproduce. (Procedure valid at least for win xp and 7) In under 1 minute! Some more observations. Same problem happens also in function properties window, in the 'Code' tab: - choose some simple (lets say empty) function, open its properties

[pgadmin-hackers] SQL-panel causes 100% CPU and lockup on windows (Was Stability and compatability issues on windows xp)

2015-09-28 Thread Nikolai Zhubr
Hi, (and sorry for cross-posting, the issue is imo pretty important) 27.09.2015 14:12, I wrote: [...] Besides, I suspect that with some luck the problem might also trigger on vista+ when running pgadmin through a remote desktop, although I'm not quite sure. Ok, no need for remote desktop even.

[pgadmin-hackers] Re: [pgadmin-support] Stability and compatability issues on windows xp

2015-09-27 Thread Nikolai Zhubr
Hi, 27.09.2015 8:20, J.F. Oster wrote: Hello, NZ> So, is it planned e.g. to publish some beta windows binaries? +1 for publishing beta binaries. NZ> I'm on windows xp sp3 (32-bit). Windows XP is not supported officially, http://www.pgadmin.org/download/windows.php From v1.16.0, Windows

[pgadmin-hackers] Re: [pgadmin-support] Stability and compatability issues on windows xp

2015-09-26 Thread Nikolai Zhubr
Hi again, and still again regarding this, as I have just discovered that 1.22 beta is probably to be out soon (by looking through last git commits), maybe it is a good time to test and even fix something? So, is it planned e.g. to publish some beta windows binaries? If not, would it make sen