Re: [pgadmin-hackers] pgAdmin 4 commit: Add support for detachable tabs to the runtime.

2017-06-16 Thread Robert Eckhardt
Nice! This is awesome. I didn't see it land. -- Rob On Fri, Jun 16, 2017 at 1:57 AM, Dave Page wrote: > Add support for detachable tabs to the runtime. > > This allows the Query Tool, Debugger and web browser tabs to be moved to > different monitors as desired. > > Fixes

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Robert Eckhardt
Absolutely makes sense. Matt, Sarah, Do we understand the issues Dave is mentioning well enough to look into it and tackle it? -- Rob On Wed, Jun 14, 2017 at 8:12 AM, Dave Page wrote: > Hi, > > Before I commit anything else for this patch, we need to fix the > existing

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-13 Thread Robert Eckhardt
in "Edit" mode. > > I have only modified the UI changes, there are lots of work needs to be > done to complete that. > Please review the design. Suggestions/Comments are welcome. > > > On Tue, Jun 6, 2017 at 4:30 PM, Robert Eckhardt <reckha...@pivotal.io> &

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Robert Eckhardt
Shirley and I are in SF this week so we will be even more async that usual. -- Rob On Mon, Jun 12, 2017 at 7:33 AM, Dave Page wrote: > Adding Shirley... > > Hi > > On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar > wrote: > > Hi > > > > The

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Robert Eckhardt
Thank you. -- Rob On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Sure I will send. > > On Wed, Jun 7, 2017 at 6:54 PM, Dave Page wrote: > >> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar >> wrote:

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-06 Thread Robert Eckhardt
t;>>>> >>>>>>- Show all the existing partitions of the parent table in >>>>>>Partitions tab (Refer Existing_Partitions.png) >>>>>>- Ability to create N partitions and detach existing partitions. >>>&g

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-05 Thread Robert Eckhardt
ssed with this current patch, >> aside from the feature test for for edit table tool. If we agree that >> Surinder can send that patch on a separate thread, is this patch good to be >> committed? >> >> Thanks, >> Matt >> >> On Thu, Jun 1, 2017 at 11:17

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-05 Thread Robert Eckhardt
I guess what I didn't say is YES. What Akshay and Ashesh are building is going to absolutely be fundamental to any workflows being defined in these interviews. -- Rob On Mon, Jun 5, 2017 at 12:17 PM, Robert Eckhardt <reckha...@pivotal.io> wrote: > On Mon, Jun 5, 2017 at 11:45 AM, Dave

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-05 Thread Robert Eckhardt
.png) >>>>- Ability to create N partitions and detach existing partitions. >>>>Refer (Create_Detach_Partition.png), in this example I have detach >>>>two existing partition and create two new partitions. >>>>- Add

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-01 Thread Robert Eckhardt
Awesome, thanks. -- Rob On Thu, Jun 1, 2017 at 11:13 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Robert, > > On Jun 1, 2017 8:22 PM, "Robert Eckhardt" <reckha...@pivotal.io> wrote: > > > > Surindar, > > > > Hav

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-01 Thread Robert Eckhardt
Surindar, Have you sent this patch and I'm missing it or is it still in flight for you? -- Rob On Wed, May 31, 2017 at 1:02 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Joao > > On Wed, May 31, 2017 at 1:19 AM, Joao Pedro De Almeida Pereira < >

Re: [pgadmin-hackers] Autoformatting

2017-05-28 Thread Robert Eckhardt
On Tue, May 9, 2017 at 4:26 AM, Dave Page wrote: > > Anyhoo, The standard we try to use in pgAdmin at the moment is slightly > different from the example you've given. To add it into the mix... > > /* Keywords Upper, 4 space indent, commas after, AND/OR after, > * no spaces

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-24 Thread Robert Eckhardt
On Wed, May 24, 2017 at 3:35 AM, Akshay Joshi wrote: > >Taking average of two columns is just an example/representation of > expression, there is no use case of that. As I am also in learning phase. > Below are some use case that I can think of: > >- > >

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-23 Thread Robert Eckhardt
On Tue, May 23, 2017 at 10:09 AM, Shirley Wang wrote: > > It's possible to design for the range and list partitions and know we can > achieve success because we understand how users would go through this > workflow. Not sure about expressions. > Maybe to pile on this a bit.

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-18 Thread Robert Eckhardt
On Thu, May 18, 2017 at 4:42 AM, Dave Page wrote: > > > Feel like putting that in your backlog? :-) > Interesting you say that. It is either going to be trivial to do or we won't have the context on which vendored libraries have been changed. We have a task to try and see if

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Robert Eckhardt
> > The issues we consistently face: >> >>- The huge (often thousands sometimes tens of thousands) number of >>partitions makes rendering all of the partitions painfully slow and >>frequently not useful. >> >> Perhaps, though I doubt that number would be common in Postgres. The >

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Robert Eckhardt
On Thu, Apr 27, 2017 at 7:01 AM, Akshay Joshi wrote: > Hi Dave > > As per discussion I have changed the logic of showing partitioned table in > browser tree. Attached is the screenshot. > Let me know your thoughts. > Greenplum has had declarative partitioning for

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-13 Thread Robert Eckhardt
> > Is that a new shade of gray? How many do we have now? It looks to me like >>> it's starting to get messy, with too many different variations of gray plus >>> the light blues used for the codemirror gutter and alternate rows in the >>> grid. >>> >> >> Yes, it is a darker shade of gray. Are you

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-06 Thread Robert Eckhardt
> > > 3. right-justified numbers come from precedents like excel or other > > spreadsheet type tools and muddles the distinction between editable and > > un-editable tables (at least data output in from query results is > > un-editable, I know right clicking on a table in the browser to "view ...

[pgadmin-hackers] Results screen/Data output work

2017-02-16 Thread Robert Eckhardt
All, I was looking at the mailing list this morning and realized that we had been remiss in discussing what we (Pivotal) are working on. The primary chunk of work we are doing it to get The data output window to behave similarly to how it behaves in pgAdmin3. Specifically we want users to be

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-25 Thread Robert Eckhardt
> > My main concern is making the right decisions on what to change, and > focussing efforts in the areas where we gain most benefit. Of course, > the resources to do the work are also critical - the current team > already have a good years worth of work in various additional features > and

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-25 Thread Robert Eckhardt
One of the surprises for me when looking at the interview notes was the number of features that people asked for that already existed. IMO one of the wins for design would be making these more easily discovered. As I see it a lot of the design is going to be fairly nuanced and having the

Re: [pgadmin-hackers] Driver Module

2017-01-11 Thread Robert Eckhardt
On Wed, Jan 11, 2017 at 8:07 PM, Dave Page wrote: > Hi > > On Wed, Jan 11, 2017 at 10:24 PM, George Gelashvili > wrote: > > Hi Dave, > > > > Thanks for the pointer. > > We realized that many of the changes we would need to make for supporting > >