Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-15 Thread Sarah McAlear
Hi Dave! Just to verify, which version of QT are you using? The Readme calls for 5.5 at the newest. Could you send us the compiled version of the app? Are you only seeing this on Windows? Thanks, Sarah & Shruti & João On Wed, Jun 14, 2017 at 3:46 PM, Sarah McAlear wrote: > Sounds

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Sarah McAlear
gt; your team been able to look at that yet? >> >> On Wed, Jun 14, 2017 at 4:07 PM, Sarah McAlear >> wrote: >> > Hi Hackers! >> > >> > This patch includes a new pane in the history tab that displays the full >> > formatted query and meta data ab

[pgadmin-hackers][patch] Changing the ACI tree font to Helvetica

2017-06-08 Thread Sarah McAlear
Hi Hackers, This patch changes the ACI Tree font to the font used in the rest of the project and increases the size to match, Helvetica. Thanks, Shirley & Sarah diff --git a/web/pgadmin/static/css/aci_tree.overrides.css b/web/pgadmin/static/css/aci_tree.overrides.css new file mode 100644 index 0

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-08 Thread Sarah McAlear
#x27;t seem related to these changes? Thanks, George & Sarah On Thu, Jun 8, 2017 at 10:19 AM, Dave Page wrote: > Hi > > On Thu, Jun 8, 2017 at 2:18 PM, Sarah McAlear wrote: > > On Thu, Jun 8, 2017 at 8:34 AM, Dave Page wrote: > >> - There are changes to SlickGrid,

Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

2017-06-08 Thread Sarah McAlear
Hi Surinder! We reviewed the patch and the changes look great. Could you change the grays to match the style guide? Silver, #222, and #aaa aren't listed in pgadmin.style.css. Thanks so much! Shirley & Sarah On Thu, Jun 8, 2017 at 9:34 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote:

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-08 Thread Sarah McAlear
ssion info: chrome=58.0.3029.110) > (Driver info: chromedriver=2.29.461585 > (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.3 > x86_64) > > Thanks - this is a very nice improvement! > > > On Wed, Jun 7, 2017 at 9:47 PM, Sarah McAlear wrote: > > Hel

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-10 Thread Sarah McAlear
ts. After we made this change, the tests passed. Can you try to create a new user and use it to execute your tests? Thanks, João & Sarah On Wed, May 10, 2017 at 1:56 PM, Akshay Joshi wrote: > > > On May 10, 2017 19:07, "Sarah McAlear" wrote: > > Hi Akshay! > >

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-10 Thread Sarah McAlear
Hi Akshay! Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tests pass. Thanks! João & Sarah On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi wrote: > Hi Sarah > > On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear wrote: > >> Hi Akshay! >> >> &

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-09 Thread Sarah McAlear
Hi Akshay! > Some test file names ended with "*_sql_template.py*" do we need to add > that string ? we added this suffix after moving the tests up a level to tables/tests to clarify what subject they applied to. we changed the suffix to "_sql.py" - Files "test_column_acl_sql_template.py" and "t

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-05-08 Thread Sarah McAlear
Hi Harshal! We applied your patch and ran the Javascript tests and realized there are 6 tests failing. After that we replicate the failures by hand and found the following issues: - Clicking in the checkboxes of the rows does not select the row anymore. - When copying and pasting (any) data, we r

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-08 Thread Sarah McAlear
lished off on Monday please Ashesh? >>>>> >>>>> On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt >>>> > wrote: >>>>> >>>>>> All, >>>>>> >>>>>> This change in the xss testing is preve

Re: [pgadmin-hackers] Issue with SlickGrid

2017-05-05 Thread Sarah McAlear
Hi Murtuza! 1) > Individual cell selection is not visible, > This will be useful to user when user wants to use "By Selection" & > "Exclude Selection" filter option. > (Even if active cell is not visible to user, above filters are working > though when we click on any cell) Good catch. We'll fix

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid column resize triggers column select

2017-05-05 Thread Sarah McAlear
Hi Murtuza and Ashesh! We are currently working on a number of features related to the query results grid. Some of the changes we are working on is that the checkboxes are going away. The implementation of this patch will have to change based on this. We noticed that 5 Javascript Tests are failing

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-02 Thread Sarah McAlear
Hi Hackers & Ashesh! Is there anything else we can do for this? Thanks! Matt & Sarah On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Thanks for reviewing, Ashesh. > > We have updated the patch. The headers are all consistent and we remove

[pgadmin-hackers][Patch] Rename feature test server

2017-04-27 Thread Sarah McAlear
Hi Hackers! We realized that the feature tests and unit tests were using the same server, which was causing some flakiness when running the tests. This patch renames the server for the feature tests. Thanks! Joao & Sarah 0001-Change-the-name-of-the-Server-created-for-Feature-te.patch Descriptio

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-27 Thread Sarah McAlear
Hi Kushboo! We understand your point, but we believe that relying on 2 independent functions to deliver the same formatting can become a problem if the PG function changes. Our suggestion is to use a single function in our javascript code to do this formatting. If the community believes we can li

Re: [pgadmin-hackers] [patch] Query Output Header Width

2017-04-24 Thread Sarah McAlear
Oh, good catch! Here's a new patch with all the lines in place. Thanks, Joao & Sarah On Thu, Apr 20, 2017 at 12:05 PM, Dave Page wrote: > > > On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili < > ggelashv...@pivotal.io> wrote: > >> Hello Hackers, >> >> We found that having the column header e

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-24 Thread Sarah McAlear
Awesome, thank you for adding that back in! On Sun, Apr 23, 2017 at 11:17 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Fri, Apr 21, 2017 at 7:59 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers, >> >> We review the patch, just noticed

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-12 Thread Sarah McAlear
Great, thank you so much! On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi wrote: > > On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear > wrote: > >> Hi Hackers! >> > Hi Sarah, > >> >> Is there an update on this? >> > We will look in to it end of t

Re: [pgadmin-hackers] [question]

2017-04-12 Thread Sarah McAlear
We follow this same URL object mapping almost everywhere in pgAdmin4. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Apr 12, 2017 at 3:39 AM, Sarah McAlear > wrote: > >> Hel

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-12 Thread Sarah McAlear
Hi Hackers! Is there an update on this? Thanks, Sarah & Joao On Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear wrote: > Hi Ashesh! > > Good catch. Looks like there was an override of the input function that > didn't get moved to the new file, causing the input with the @ to

[pgadmin-hackers] [question]

2017-04-11 Thread Sarah McAlear
Hello Hackers, We are working with the tree and are looking into the paths that are used to get tree data from the Python backend. We noticed that the path has a component that has to be numeric, but it appears that what this number is, is irrelevant. Here's an example: /browser/server/children/1

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-07 Thread Sarah McAlear
;> On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi < >>>> ashesh.va...@enterprisedb.com> wrote: >>>> >>>>> Hi Joao & Sarah, >>>>> >>>>> I have asked Murtuza to review the patch today. >>>>> He will upda

[pgadmin-hackers] [pgadmin4][patch] Remove (...) from links

2017-04-03 Thread Sarah McAlear
Hi Hackers! A lot of the links in the app's dropdown menu had a trailing (...), which made it seem like there was truncated text. This makes it harder to read and can be confusing. This patch removes the ellipses. Thanks! Shirley & Sarah 0001-Remove-.-from-links.patch Description: Binary data

Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Sarah McAlear
Hi > > Was that the correct patch? I don't see the changes you describe. > > On Tue, Mar 28, 2017 at 12:29 PM, Sarah McAlear > wrote: > > Good catch. We looked into this and it appears that the language > > interpretation that is defined in the babel.cfg only picks up o

Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Sarah McAlear
eliminate some of the configuration again. Here's a new patch that should fix this. Thanks, Matt & Sarah On Mon, Mar 27, 2017 at 9:19 PM, Dave Page wrote: > Hi > > On Mon, Mar 27, 2017 at 2:06 PM, Sarah McAlear > wrote: > > Hi Hackers, > > Sorry about that,

Re: [pgadmin-hackers] Javascript translations

2017-03-27 Thread Sarah McAlear
Hi Hackers, Sorry about that, we attached the wrong patch file. Attaching the correct one Thanks Joao & Sarah On Mon, Mar 27, 2017 at 1:58 PM, Dave Page wrote: > Hi > > On Mon, Mar 27, 2017 at 11:33 AM, Sarah McAlear > wrote: > > Hi Hackers! > > > > We upda

Re: [pgadmin-hackers] Javascript translations

2017-03-27 Thread Sarah McAlear
Hi Hackers! We updated the documentation and included the ability to generate the messages.pot files again. We changed the file and function from translate.js to gettext.js to be consistent with Python and also to have it automatically picked up without having to add extensions to Pybabel. See pat

[pgadmin-hackers][patch] Fix feature tests for Greenplum

2017-03-24 Thread Sarah McAlear
Hi Hackers! This patch fixes a cleanup SQL query to enable running feature tests on CI against Greenplum. Thanks, George & Sarah 0001-Change-drop_database-cleanup-to-terminate-processes.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To

Re: [pgadmin-hackers][patch] Shows titles for disabled buttons on hover

2017-03-17 Thread Sarah McAlear
Hi! Here's a new patch that applies to all the buttons. Thanks, Joao and Sarah On Fri, Mar 10, 2017 at 4:06 AM, Dave Page wrote: > Hi > > On Thu, Mar 9, 2017 at 7:05 PM, Joao Pedro De Almeida Pereira > wrote: > > Hello Dave, > > > > We were looking into this request and we found at least on

Re: [pgadmin-hackers] Feature test regression failures

2017-03-17 Thread Sarah McAlear
Hello, We agree that we should keep an eye on this and the failing feature tests. Our current story touches part of this code, but we won't go into changing the library for now. The patch Tira sent fixes a global variable problem that we found while looking into the code that generates the Tree,

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-17 Thread Sarah McAlear
/commit this please? One thing I notice on a > quick look through is that the file headers are missing everywhere. > They should be present in all source files, except where they would > bloat the data transfer from client to server. > > On Wed, Mar 15, 2017 at 8:09 PM, Sarah Mc

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-15 Thread Sarah McAlear
Hi Hackers! It looks like our previous patch messed up some logging. Please use this one instead. Thanks, Joao & Sarah On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear wrote: > Hi Hackers! > > Here's a patch to move to current db migration system to use Alembic. > Instr

[pgadmin-hackers][patch] Move to Alembic migration system

2017-03-15 Thread Sarah McAlear
Hi Hackers! Here's a patch to move to current db migration system to use Alembic. Instructions to create new migrations are in the README. Thanks! Joao & Sarah 0001-Switch-to-Alembic-and-Flask-migration-db-migration-s.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pg

[pgadmin-hackers][patch] Shows titles for disabled buttons on hover

2017-03-03 Thread Sarah McAlear
Hi Hackers, This patch enables hovering over disabled buttons to see their functionality. Thanks, Joao and Sarah 0001-Ensure-title-is-displayed-in-disabled-buttons.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

Re: [pgadmin-hackers] [Patch] Organize Vendorized Assets

2017-02-23 Thread Sarah McAlear
Whoops, sorry, we messed up some CSS. We'll give you a new patch tomorrow. Sarah & Tira On Thu, Feb 23, 2017 at 5:58 PM, Sarah McAlear wrote: > Hi Hackers, > > This patch creates a vendors directory that separates javascript/font/css > dependencies that we have pulled in

[pgadmin-hackers] SlickGrid

2017-02-13 Thread Sarah McAlear
Hi Hackers, We saw a story about transferring query results to SlickGrid on Redmine ( https://redmine.postgresql.org/issues/2036). We are considering more selection options (in addition to by-row) within the results display, which got us wondering about the use of SlickGrid. It appears that Slick