What do you think about this?
0058-More-information-about-the-selected-objetc.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
> It doesn't return the schema when the schema belongs to your
> search_path. That's the right way to do it.
>
OK. But we must always show the scheme in this context.
We can create another function too.
>
> Well, as far as I know, pgadmin could be connected to many databases. It
> should only display the connection it used to get the informations on
> the selected object.
>
Thinking so, I think you have reason.
>
> Are you sure?
>
Yes. GetFullIdentifier() doesn't return the schema.
> Got some time to work on this. SetLabel is useful for widgets, not for
> windows. Change your call to the SetLabel() method with a call to
> SetTitle(). Works great for me on Linux. Don't know on Windows, maybe
> you could check?
>
OK. I changed it.
>
> About your patch, it seems good so far.
Hello,
I did several tests and seems to be working good.
If you have any suggestion for improvement, please let me know.
Thanks!
0031-Implemeting-auto-save-feature-in-the-SQL-Editor.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To ma
Hello!
I finished the patch. I'm testing deeper, on W7 and Ubuntu.
I will probably send it tonight.
Thanks!
>
> Got some time to work on this. SetLabel is useful for widgets, not for
> windows. Change your call to the SetLabel() method with a call to
> SetTitle(). Works great for me on Linux. Don't know on Windows, maybe
> you could check?
>
Yes. Of course.
>
> About your patch, it seems good so far.
> Do you have any progress on this patch?
>
Yes.
I am finishing a preview. I'm testing on Windows 7 and Ubuntu.
I think I should finish by the end of today.
> Where is it saved?
>
> You also need to have a way to delete those files.
>
I thought to create a specific directory for it.
> Yeah, I think the informations should be available in the file (for
> example if your database has a _ in its name, it will be hard to decode
> the informations from
> Well, this seems good but there's an issue I don't know how you want to
> deal with it: what's happens if I had more than one window opened?
I'm saving a file for each window.
Each window have a private variable called "fileNameAutoSave"
The query is salved from time-to-time. As configuration.
> > MySQL Workbench has a similar feature.
> >
> > This does pose an exposure to save sensitive information without the user
> > knowing. How to solve this? A complicated development path: encrypt
> saved
> > document.
>
> We won't go that road for sure. Too complicated, too easy to make it
> wor
> Seems good to me. We are talking about the query tool, right?
Right.
> Be careful
> that users may have many query tool windows open at the same time.
>
Actually I thought of something simple.
One file per window, when the window is closed, the pgAdmin will delete it.
We avoid the loss of
Hello,
I started to implement the feature "autosave" present in many text editors.
I would like to listen your opnions about this feature.
I put a option "Minutes to save the document automatically" in the
frmOptions.
What do you think?
>
> Not yet commited, I need some time to review it. Moreover, Dave is on
> holiday right now and he has deep concern about this patch, so I won't
> apply it before giving him a chance to review it.
>
Ok!
>
> > but I wanted the yours
> > opinion, about another patch.
> >
> > What do you think,
I know that you still didn't accept my patch yet, but I wanted the yours
opinion, about another patch.
What do you think, about the attached image?
I also think that this information is useful.
<>
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your s
Hello,
I finished the patch. It works fine on Windows 7, but the
SetLabel(wxString) doesn't work on my Ubuntu.
I did make some simple tests with the wxWidgets on Ubuntu, but I can't do
it to work.
Can you help-me with the test on Linux?
Thanks.
0001-More-information-about-the-selected-objetc.p
>
>
> I much prefer what you call "on caption" (I call it the title bar).
>
I called it as "on caption" because of my habit with Delphi.
It is the title bar really
> That's already what we do with the query tool.
>
So, I'll send the patch in the title bar, for you to give a look.
We can also do so. On caption.
<>
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
>
> One alternative option might be to have an extra wxAUI menubar panel,
> with a couple of textlabels on it. That could be moved around and
> hidden or shown in the same way we do for the menu bar (or the
> database selection bar on the query tool).
>
Good ideia.
I can do. Then we see if it impr
>
> Not really. The panel you've used for the server name is fixed width.
> As I mentioned before, on some, if not all platforms, you can only
> have 1 variable width panel. That's one of the reasons we've avoided
> putting extra info in there before, that isn't a clearly defined
> width.
>
It's t
>
> I can test the PPAS stuff, but not the Greenplum objects. But... they
> shouldn't be an issue - if an object is derived from pgSchema, you can
> (and should use GetSchema(). If it's derived from a pgTable, you
> probably want the table name too. If it's derived from pgObject,
> pgServer, pgData
I fixed the problems.
I removed the implementation on EnterpriseDB items, because I don't have
how to test it. Can you help to test it?
I tested on Windows 7 and Ubuntu.
0001-More-information-about-the-selected-objects.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (p
>
> Which is entirely expected as both public synonyms and casts are
> database level objects and thus don't have pgSchema as a parent class.
>
>
I forgot to check the pgCast. Sorry
I'll fix it and resubmit.
Attached.
I think the information "user@database ( server )" is important.
I tested on Windows 7.
I'll test on Ubuntu tonight.
0001-More-information-about-the-selected-objects.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make chan
>
> I think I like the second one better, but this is just my opinion.
>
Well, I'll start working on the second, then.
If new opinions, we changed.
> Not sure I like the point either. We don't have that notation on
> PostgreSQL. I think I would prefer something like "Retrieving details on
> table schema.table" and not say the database. Because if you add the
> database, someone will probably want also the server. It may not be
> usefull to you
Forwarding, sorry.
2012/7/14 Vinicius Santos
> I see some value on it, but I don't like the arrow.
>>
>
> Any suggestions?
> I could put the point rather than the arrow or other something. What do
> you think?
>
> So, this information would solve the problem. What do you think?
>
Any comment? Can I develop the patch?
Hello,
When you click on a table, in the status bar appears: "Retrieving details
on table ..."
I'd like to put more information and leave it like this: "Retrieving
details on table ->., For example:
"Retrieving details on table db_developers->public.table..."
The same for all objects, like func
> Well, I don't like the UI. It takes too much space for only one
> information. I would better like a combobox, with the two choices.
>
I thought so too. I agree with you.
> Moreover, it simply doesn't work on Linux. I've got an assertion failure
> on OnPaint for the list. I actually don't unde
Hello,
I implemented a function for the two buttons "Asc" and "Desc", so that
the maintenance
is easier.
Take a look and tell me what you think.
Thanks.
0003-Implementation-Nulls-First-option-on-dlgEditGridOpti.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-
Patch attached.
0002-Keywords-in-Uppercase.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
>
> Yes. Our UI guideline is to disable (and not hide) widgets when the
> option is not available (whatever the reason).
>
Ok. Do you agree with implementation ?
Can I submit the patch tomorrow?
> And? I don't get your point here. The version it first appeared doesn't
> affect the UI.
>
Ok. But for versions < 8.3, I disable the radiobox, right?
Since the query:
"SELECT column FROM table ORDER BY column NULLS FIRST" would not work on
these versions.
I did not realize again ...
Nope, would be better if it was a radiobox below the column name.
>
>
Humm.
I did not think at radiobox, because this feature is only available from
8.3.
> Don't answer to me only, answer to the list please.
>
Sorry, I did not realize.
>
> Not under "Query tool". Under "Query editor", yes, could be. I won't
> have any problem applying such a patch.
>
Ok. I send the patch tonight.
Thaks.
Hello,
>
> I think that option "Keywords in Uppercase" not should stay in the
> "Colours" tab, should stay in the "Query Tools" tab.
>
> What do you think?
>
> In fact, this option is very cool!
>
If you agree, I can send the patch.
Thank You.
Hello,
I implemented an option "Nulls First" in the ordering screen.
It's just a checkbox for versions >= 8.3 of PostgreSQL.
What do you think?
Hello,
I think that option "Keywords in Uppercase" not should stay in the "Colours"
tab, should stay in the "Query Tools" tab.
What do you think?
In fact, this option is very cool!
Hello,
Someone forgot the code to restore the position of the form
"frmOptions." Patch attached.
Anyway, I think that this form should always appear in the center of the
screen. No?
>From 28674c71e52550031d096f4c5c439f05d970957c Mon Sep 17 00:00:00 2001
From: Vinicius Santos
Em 25/08/2011 19:23, Dave Page escreveu:
I rolled back Vinicius' patch and tested, and still see the error. I
think it's your patch that's at fault:-(
I tested here too, with all the lines of my patch comment, and the error
yet occurs.
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@
the parent schema "public", but the
properties and SQL panes are showing the details of the table.
I did make some tests, and now seems to be OK.
Thanks again.
>From 226782001029e9a9886cdbe23dc2a3f4f06ededc Mon Sep 17 00:00:00 2001
From: Vinicius Santos
Date: Sun, 21 Aug 2011 18:
Em 19/08/2011 16:13, Vinicius Santos escreveu:
2011/8/19 Dave Page mailto:dp...@pgadmin.org>>
Hi,
I just came to review this again (following a hectic week - sorry!).
Unfortunately it no longer applies as frmOptions has been redesigned.
Can you update the patch please?
>From 63c2b20eff916b89fee7135d754094a35f01770c Mon Sep 17 00:00:00 2001
From: Vinicius Santos
Date: Sat, 13 Aug 2011 01:03:11 -0300
Subject: [PATCH] Implement Refresh Object on Click.
---
pgadmin/frm/events.cpp | 49 +++
pgadmin/
Em 11/08/2011 07:25, Dave Page escreveu:
- On frmOptions, the combo box to select the refresh mode should be to
the right of the label, not underneath. The sizing should following
the layout of other tabs.
Done.
- In "Refresh object on click" mode, if I click a table, and then
click the parent
ached.
Thank you.
>From 6727404ebd0aaf4d7283796058501d51e76675a1 Mon Sep 17 00:00:00 2001
From: Vinicius Santos
Date: Thu, 11 Aug 2011 00:14:23 -0300
Subject: [PATCH] Implement Refresh on click.
---
pgadmin/frm/events.cpp | 44 +++
pgadmin/frm/frmOpt
p://archives.postgresql.org/pgadmin-hackers/2011-06/msg00039.php
>From 5c91e26adb64167d4f60380fbfe210bf9351bf2a Mon Sep 17 00:00:00 2001
From: Vinicius Santos
Date: Wed, 10 Aug 2011 00:06:14 -0300
Subject: [PATCH] Implement Refresh on click.
---
pgadmin/frm/events.cpp | 43 ++
You're welcome to send it there. It should apply cleanly on the master
branch.
Simple as that.
If something is wrong, please let me know.
From 1d8da09870f27e0463139badd1d303cae8332341 Mon Sep 17 00:00:00 2001
From: Vinicius Santos
Date: Sat, 6 Aug 2011 00:02:26 -0300
Subject: [
Hello,
I believe that when you save a document in the form "frmQuery", the
"Save" button should be disabled to become more obvious to the user that
the document contains no changes.
When user change the document, the button is enabled again.
As with some text editors.
I know that in this ca
>
>
> I'd probably be happy with a patch that offered *both* "refresh object
> on click" and "refresh object and children on click", but not just the
> latter - the use case is just too narrow imho.
>
>
I agree with you.
What do you think of a ComboBox with the two options?
I'll start to develop,
Hi, sorry for the delay in responding.
I agree to share with you.
First, the update will be different for "F5 refresh" and per "click
refresh". This could confuse people.
Second, this does not obviate the problem of another user to create, for
example, a table and this table does not appear to
in an object type independent way - ie. in pgObject for example. Not
sure how feasible that is though...
Hello,
It could take a look at my patch?
I thought of other ways to implement, but I ended up with this.
Thanks.
>From d85df2b2543a2974cdd1b8679938cce32991f1b9 Mon Sep 17 00:00:00 2001
Fr
Cool, thanks :-). Ideally, something like this should be implemented
> in an object type independent way - ie. in pgObject for example. Not
> sure how feasible that is though...
>
> I thought just in pgObject.
I'll write and tell me what you think.
Should I send this afternoon (afternoon for me,
>
>
> What I'd really like to see is an option which enables on-selection
> refreshing for all object types.
>
>
OK.
I will develop it , and send a patch for you to analyze.
Thanks.
Hello,
I implemented an option to update functions and trigger functions, by
clicking on them in the treeview.
This avoids problems when someone changes the function, and I get the
old version and then overwrite it, without reminding me from updating
(F5) before.
I did a checkbox in the fo
Em 15/12/2010 21:55, Vinicius Santos escreveu:
I'm sending a patch.
Thanks.
Or Better.
>From 27a71f4d562349401ce7b57fc4455d91c2654c6d Mon Sep 17 00:00:00 2001
From: unknown
Date: Wed, 15 Dec 2010 22:23:51 -0200
Subject: [PATCH] Signed-off-by: unknown
---
pgadmin/frm/frmQuery.cp
Hello,
I think it's useful information on how many characters were selected in
the SQL editor.
For me it helps a lot in some cases.
What do you think?
I'm sending a patch.
Thanks.
>From 5d36c0b3c521c9be0047d40c4551cf2d13776c86 Mon Sep 17 00:00:00 2001
From: unknown
Date: Wed, 15 Dec 2010 2
> OK, after some thinking, it would be best to disable the "Clear window"
> items rather than clearing the query. The same needs to be done for Cut,
> Copy, Paste items.
>
> Do you want to work on such a patch?
Do you can review my patch, please?
>From 30b0c5a993a26c54170d3a86fdaaa73e0521aa9a Mon
Hello,
In the SQL editor window, when the focus is outside of any text box, the
button "clear window" does nothing.
I believe that confuse the user. In this case the button should clear
the SQL editor.
Do you agree?
I made this change.
void frmQuery::OnClear(wxCommandEvent& ev)
{
wxWi
59 matches
Mail list logo
