Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Dave Page
On Saturday, July 9, 2011, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 13:39 +0100, Dave Page wrote: >> On Saturday, July 9, 2011, Guillaume Lelarge wrote: >> >> > I would prefer to only refresh the old parent node, and the new parent >> > node. But we have no way to know the new parent node

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Thom Brown
On 9 July 2011 20:55, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 15:14 +0100, Thom Brown wrote: > BTW, just commited and pushed your patch. Thanks again. \o/ Thanks again Guillaume. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB U

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 15:14 +0100, Thom Brown wrote: > On 9 July 2011 12:56, Guillaume Lelarge wrote: > > On Sat, 2011-07-09 at 10:33 +0100, Thom Brown wrote: > >> On 9 July 2011 09:28, Guillaume Lelarge wrote: > >> > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: > >> >> On 9 July 2011 00:

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 13:39 +0100, Dave Page wrote: > On Saturday, July 9, 2011, Guillaume Lelarge wrote: > > > I would prefer to only refresh the old parent node, and the new parent > > node. But we have no way to know the new parent node. So I refresh all > > schemas. Which will bring other per

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Thom Brown
On 9 July 2011 12:56, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 10:33 +0100, Thom Brown wrote: >> On 9 July 2011 09:28, Guillaume Lelarge wrote: >> > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: >> >> On 9 July 2011 00:12, Guillaume Lelarge wrote: >> >> > On Fri, 2011-07-08 at 21:

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Dave Page
On Saturday, July 9, 2011, Guillaume Lelarge wrote: > I would prefer to only refresh the old parent node, and the new parent > node. But we have no way to know the new parent node. So I refresh all > schemas. Which will bring other performance issues for users with big > schemas. I wonder if we

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 10:33 +0100, Thom Brown wrote: > On 9 July 2011 09:28, Guillaume Lelarge wrote: > > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: > >> On 9 July 2011 00:12, Guillaume Lelarge wrote: > >> > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: > >> >> On Fri, 201

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Thom Brown
On 9 July 2011 09:28, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: >> On 9 July 2011 00:12, Guillaume Lelarge wrote: >> > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: >> >> On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: >> >> > On 8 July 201

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: > On 9 July 2011 00:12, Guillaume Lelarge wrote: > > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: > >> On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: > >> > On 8 July 2011 19:46, Guillaume Lelarge wrote: > >> > > On Thu, 20

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 01:15 +0200, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 00:12 +0100, Thom Brown wrote: > > On 8 July 2011 20:57, Guillaume Lelarge wrote: > > > It's not easy to do, I understand you got carried away. Happened > > > sometimes to me too. Still happens actually. > > > > F

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 9 July 2011 00:12, Guillaume Lelarge wrote: > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: >> On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: >> > On 8 July 2011 19:46, Guillaume Lelarge wrote: >> > > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: >> > >> On 7 July 20

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 00:12 +0100, Thom Brown wrote: > On 8 July 2011 20:57, Guillaume Lelarge wrote: > > It's not easy to do, I understand you got carried away. Happened > > sometimes to me too. Still happens actually. > > Found out this patch doesn't contain my removal of a duplicate section >

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 20:57, Guillaume Lelarge wrote: > It's not easy to do, I understand you got carried away. Happened > sometimes to me too. Still happens actually. Found out this patch doesn't contain my removal of a duplicate section of code in dlgTextSearchConfiguration.cpp, so now if the name of

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: > On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: > > On 8 July 2011 19:46, Guillaume Lelarge wrote: > > > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > > >> On 7 July 2011 23:20, Guillaume Lelarge wrote: > > >> > On Wed, 2

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 20:53 +0100, Thom Brown wrote: > On 8 July 2011 20:52, Guillaume Lelarge wrote: > > On Fri, 2011-07-08 at 20:46 +0200, Guillaume Lelarge wrote: > >> On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > >> > On 7 July 2011 23:20, Guillaume Lelarge wrote: > >> > > On Wed, 20

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: > On 8 July 2011 19:46, Guillaume Lelarge wrote: > > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > >> On 7 July 2011 23:20, Guillaume Lelarge wrote: > >> > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: > >> >> add_schemas_to_all

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 20:52, Guillaume Lelarge wrote: > On Fri, 2011-07-08 at 20:46 +0200, Guillaume Lelarge wrote: >> On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: >> > On 7 July 2011 23:20, Guillaume Lelarge wrote: >> > > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: >> > >> add_schemas_

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 20:46 +0200, Guillaume Lelarge wrote: > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > > On 7 July 2011 23:20, Guillaume Lelarge wrote: > > > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: > > >> add_schemas_to_all_items_filtered.patch - same patch as before, bu

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Dave Page
On Friday, July 8, 2011, Thom Brown wrote: > On 8 July 2011 20:15, Dave Page wrote:  * all extension changes are wrong according to me because they aren't   schema objects, but database objects. I don't keep them. >>> >>> The reason why I based it on schema is because I wanted it to inh

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 20:15, Dave Page wrote: >>>  * all extension changes are wrong according to me because they aren't >>>   schema objects, but database objects. I don't keep them. >> >> The reason why I based it on schema is because I wanted it to inherit >> the schema combobox object and its source

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Dave Page
>>  * all extension changes are wrong according to me because they aren't >>   schema objects, but database objects. I don't keep them. > > The reason why I based it on schema is because I wanted it to inherit > the schema combobox object and its source for a list of schemas so > lots of redundant

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 19:46, Guillaume Lelarge wrote: > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: >> On 7 July 2011 23:20, Guillaume Lelarge wrote: >> > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: >> >> add_schemas_to_all_items_filtered.patch - same patch as before, but >> >> with th

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > On 7 July 2011 23:20, Guillaume Lelarge wrote: > > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: > >> add_schemas_to_all_items_filtered.patch - same patch as before, but > >> with the above patch contents removed or adjusted to assume t

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-07 Thread Thom Brown
On 7 July 2011 23:20, Guillaume Lelarge wrote: > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: >> add_schemas_to_all_items_filtered.patch - same patch as before, but >> with the above patch contents removed or adjusted to assume the fixes >> have been applied. >> > > Not yet done. I'll try

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-07 Thread Guillaume Lelarge
On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: > On 5 July 2011 20:47, Guillaume Lelarge wrote: > > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: > >> but left it where it > >> was. In order to implement these changes, I had to also fix quite a > >> few bugs, and while I was at it,

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Jasmin Dizdarevic
Me too...it's quite hard to get in ;) GetNodePath returns a string representing an language dependent node path: Server Groups/localhost/Databases/myDb/Schemas/mySchema/Tables/myTable SetCurrentNodePath accpet the string node path and select's the desired object. During implementing search ob

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 21:08, Guillaume Lelarge wrote: > On Tue, 2011-07-05 at 21:01 +0100, Thom Brown wrote: >> On 5 July 2011 20:47, Guillaume Lelarge wrote: >> > Hi Thom, >> > >> > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: >> >> [...] >> >> I noticed that objects which can be moved to diffe

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 21:14, Jasmin Dizdarevic wrote: >> > > Did you fix the issue with the refresh of the browser? (I can't check >> > > yet, I'm doing a last time compile of Jasmin's patch :) ) >> > >> > I got it refreshing the node in the original schema, but not the >> > destination one. >> > >> >> W

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Jasmin Dizdarevic
2011/7/5 Guillaume Lelarge > On Tue, 2011-07-05 at 21:01 +0100, Thom Brown wrote: > > On 5 July 2011 20:47, Guillaume Lelarge wrote: > > > Hi Thom, > > > > > > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: > > >> [...] > > >> I noticed that objects which can be moved to different schemas

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 21:01 +0100, Thom Brown wrote: > On 5 July 2011 20:47, Guillaume Lelarge wrote: > > Hi Thom, > > > > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: > >> [...] > >> I noticed that objects which can be moved to different schemas can't > >> be moved in PgAdmin, so I looked

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 20:51, Dave Page wrote: > On Tue, Jul 5, 2011 at 8:47 PM, Guillaume Lelarge > wrote: >> >> Thanks a lot for your work. This patch was something I was waiting for. > > A few weeks back I had to talk Thom into posting a 2 line fix. I'm > beginning to think I may have unleashed some s

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 20:47, Guillaume Lelarge wrote: > Hi Thom, > > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: >> [...] >> I noticed that objects which can be moved to different schemas can't >> be moved in PgAdmin, so I looked to see if there was any request to >> have this implemented, and f

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 8:57 PM, Guillaume Lelarge wrote: > On Tue, 2011-07-05 at 20:51 +0100, Dave Page wrote: >> On Tue, Jul 5, 2011 at 8:47 PM, Guillaume Lelarge >> wrote: >> > >> > Thanks a lot for your work. This patch was something I was waiting for. >> >> A few weeks back I had to talk Thom

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 20:51 +0100, Dave Page wrote: > On Tue, Jul 5, 2011 at 8:47 PM, Guillaume Lelarge > wrote: > > > > Thanks a lot for your work. This patch was something I was waiting for. > > A few weeks back I had to talk Thom into posting a 2 line fix. I'm > beginning to think I may have u

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 8:47 PM, Guillaume Lelarge wrote: > > Thanks a lot for your work. This patch was something I was waiting for. A few weeks back I had to talk Thom into posting a 2 line fix. I'm beginning to think I may have unleashed some sort of rampant patch beast... > BTW, are you going

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Guillaume Lelarge
Hi Thom, On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: > [...] > I noticed that objects which can be moved to different schemas can't > be moved in PgAdmin, so I looked to see if there was any request to > have this implemented, and found this ticket: > http://code.pgadmin.org/trac/ticket/5