Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

On Fri, Sep 25, 2015 at 1:30 PM, Ashesh Vashi wrote: > Yup. > It's in my plate, was updating the CHANGELOG only. > Done. Thanks John for the patch, and Sanket for reviewing the patch. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Yup. It's in my plate, was updating the CHANGELOG only. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Sep 25, 2015 at 1:28 PM, Dave Pag

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Ashesh, are you able to deal with this before Monday (when I'll be cutting the feature-frozen beta 1 tarballs)? On Fri, Sep 25, 2015 at 7:03 AM, John Obaterspok wrote: > Thanks, appreciated. > > Can it be committed then? :) > > 2015-09-23 9:49 GMT+02:00 Sanket Mehta : > >> Hi John/Ashesh, >> >>

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Thanks, appreciated. Can it be committed then? :) 2015-09-23 9:49 GMT+02:00 Sanket Mehta : > Hi John/Ashesh, > > I have reviewed the patch and it seems fine to me. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Wed, Sep 23, 2015 at 11:08 AM, John Obaterspok < > john.oba

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Hi John/Ashesh, I have reviewed the patch and it seems fine to me. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Wed, Sep 23, 2015 at 11:08 AM, John Obaterspok wrote: > Hi Sanket, > > Did you give the patch a try? I would really like it to for the next > release :) > > -- john > >

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Hi Sanket, Did you give the patch a try? I would really like it to for the next release :) -- john 2015-09-16 20:27 GMT+02:00 John Obaterspok : > Hi Sanket, > > Attached patch is rebased now. > > Regards, > > -- john > > > 2015-09-16 11:20 GMT+02:00 Sanket Mehta : > >> Hi John, >> >> Patch is n

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Hi Sanket, Attached patch is rebased now. Regards, -- john 2015-09-16 11:20 GMT+02:00 Sanket Mehta : > Hi John, > > Patch is not proper. > I got below error when I try to apply the patch: > > error: patch failed: pgadmin/frm/frmQuery.cpp:2435 > error: pgadmin/frm/frmQuery.cpp: patch does not

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Hi John, Patch is not proper. I got below error when I try to apply the patch: error: patch failed: pgadmin/frm/frmQuery.cpp:2435 error: pgadmin/frm/frmQuery.cpp: patch does not apply Please do provide the proper patch. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Sep 14, 2

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Sure Ashesh, I will review the patch. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi wrote: > Sanket, > > Can you please take a look at it? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company >

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Sanket, Can you please take a look at it? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok wrot

[pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Hello, I'm updated the patch to add commit/rollback actions in the toolbar with the following: 1) updated icons (based on existing pgadmin icon with arrows drawn by me) 2) add entry to menu as well 3) disable icons when not in a transaction 4) Ctrl+Shift C|R shortcut Hopefully all issues are reso

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

On Thu, Jun 25, 2015 at 7:08 AM, Sanket Mehta wrote: > Hi Dave, > > I have a query inline. > > On Wed, Jun 24, 2015 at 3:06 PM, John Obaterspok < > john.obaters...@gmail.com> wrote: > >> Hi, >> >> I'm going to redo the patch with: >> 1) updated icons >> 2) add entry to menu as well >> 3) disable

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Hi Dave, I have a query inline. On Wed, Jun 24, 2015 at 3:06 PM, John Obaterspok wrote: > Hi, > > I'm going to redo the patch with: > 1) updated icons > 2) add entry to menu as well > 3) disable icons when not in a transaction > > Regarding the shortcut for commit/rollback. I'm not very found o

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Hi, I'm going to redo the patch with: 1) updated icons 2) add entry to menu as well 3) disable icons when not in a transaction Regarding the shortcut for commit/rollback. I'm not very found of keyboard shortcuts for commit/rollback when disabling auto commit. But I'll add it if you want it. Any r

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Hi John, are you sending any other icons for the same? Regards, Sanket Mehta Sr Software engineer Enterprisedb On Tue, Jun 23, 2015 at 1:47 PM, Dave Page wrote: > Hi > > On Mon, Jun 22, 2015 at 2:02 PM, John Obaterspok < > john.obaters...@gmail.com> wrote: > >> Dave, >> >> Regarding "I don't t

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Hi On Mon, Jun 22, 2015 at 2:02 PM, John Obaterspok wrote: > Dave, > > Regarding "I don't think there is...", was it the width, style or > something else that you didn't like? The total width with commit/rollback > icon + the connection drop down is less than 790 px. > I've changed the arrows so

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Dave, Regarding "I don't think there is...", was it the width, style or something else that you didn't like? The total width with commit/rollback icon + the connection drop down is less than 790 px. I've changed the arrows so they point to the data store icon (ie commit) and from the data store (r

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Just that whatever we add needs to match the style of what's there already, and it should convey the purpose of the buttons as clearly as possible. Finally, we only add them if there's physical room when displaying the window on a screen of ~1000px wide. Personally, I don't think there is... On Fr

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Hi Dave, Do you have any comments on the same? Regards, Sanket Mehta Sr Software engineer Enterprisedb On Wed, Jun 17, 2015 at 5:52 PM, John Obaterspok wrote: > Thanks, > > I can try to look at disabling when not in transaction mode + the short > cuts. > > Regarding the icons, toad for oracle

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Thanks, I can try to look at disabling when not in transaction mode + the short cuts. Regarding the icons, toad for oracle uses a database icon which the arrows point to/from. Perhaps we should add something *similar*? [image: Infogad bild 1] -- john 2015-06-17 13:44 GMT+02:00 Sanket Mehta :

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Hi John, I have applied the patch and below are my suggestions: 1. Rollback and commit icons should be disabled session is not in transaction mode 2. Rollback and Commit should also be included in Query menu and individual short cut should be assigned to them. Dave, Can we have any other icons

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Sure Dave. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Tue, Jun 16, 2015 at 4:55 PM, Dave Page wrote: > Sanket, can you look at this please? > > Sent from my iPad > > > On 15 Jun 2015, at 16:33, John Obaterspok > wrote: > > > > Hello, > > > > With the newly added option to disab

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Sanket, can you look at this please? Sent from my iPad > On 15 Jun 2015, at 16:33, John Obaterspok wrote: > > Hello, > > With the newly added option to disable auto commit (hurray) I really missed > commit/rollback toolbar buttons. Attached patch adds this. > > -- john > > <0001-Add-Commit-

[pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Hello, With the newly added option to disable auto commit (hurray) I really missed commit/rollback toolbar buttons. Attached patch adds this. -- john 0001-Add-Commit-Rollback-toolbar-action.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org