Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-18 Thread Dave Page
On Thu, May 18, 2017 at 2:04 PM, Robert Eckhardt wrote: > > > On Thu, May 18, 2017 at 4:42 AM, Dave Page wrote: > >> >> >> Feel like putting that in your backlog? :-) >> > > Interesting you say that. It is either going to be trivial to do or we > won't have the context on which vendored librarie

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-18 Thread Robert Eckhardt
On Thu, May 18, 2017 at 4:42 AM, Dave Page wrote: > > > Feel like putting that in your backlog? :-) > Interesting you say that. It is either going to be trivial to do or we won't have the context on which vendored libraries have been changed. We have a task to try and see if it is trivial. If it

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-18 Thread Dave Page
Hi On Wed, May 17, 2017 at 4:45 PM, Matthew Kleiman wrote: > Hi Dave > > Have you confirmed that removing the changes we made to shorten the class >> names used for rows and cells doesn't affect the performance or memory >> utilisation of the grid? > > > We haven't noticed any performance issues

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-17 Thread Matthew Kleiman
Hi Dave Have you confirmed that removing the changes we made to shorten the class > names used for rows and cells doesn't affect the performance or memory > utilisation of the grid? We haven't noticed any performance issues with this upgraded version of SlickGrid, nor our other changes to the qu

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-17 Thread Dave Page
On Wed, May 17, 2017 at 1:59 PM, Dave Page wrote: > Hi > > On Mon, May 15, 2017 at 7:35 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers >> >> We upgraded SlickGrid to the latest version + 53ee34. We upgraded since >> we are working on some changes to

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-17 Thread Dave Page
Hi On Mon, May 15, 2017 at 7:35 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers > > We upgraded SlickGrid to the latest version + 53ee34. We upgraded since we > are working on some changes to the query results functionality, including > improvements to col

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-15 Thread Matthew Kleiman
Hey Merlin Yes, we are using the 6pac fork. We've found Ben (6pac) to be very responsive. He accepted two PRs we wrote to the SlickGrid in a very timely manner. Thanks, Matt On Mon, May 15, 2017 at 4:46 PM Merlin Moncure wrote: > On Mon, May 15, 2017 at 1:35 PM, Joao Pedro De Almeida Pereira >

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-15 Thread Merlin Moncure
On Mon, May 15, 2017 at 1:35 PM, Joao Pedro De Almeida Pereira wrote: > Hello Hackers > > We upgraded SlickGrid to the latest version + 53ee34. We upgraded since we > are working on some changes to the query results functionality, including > improvements to column selection and shortcuts. > > Thi