Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-11 Thread Dave Page
On Thu, Nov 11, 2010 at 9:34 PM, Guillaume Lelarge wrote: > Le 11/11/2010 22:32, Dave Page a écrit : >> On Thu, Nov 11, 2010 at 9:24 PM, Guillaume Lelarge >> wrote: >>> >>> Just waiting to know Dave's opinion on all this before moving on. >> >> I'm leaning to tabs. >> > > OK. And no issue with me

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-11 Thread Guillaume Lelarge
Le 11/11/2010 22:32, Dave Page a écrit : > On Thu, Nov 11, 2010 at 9:24 PM, Guillaume Lelarge > wrote: >> >> Just waiting to know Dave's opinion on all this before moving on. > > I'm leaning to tabs. > OK. And no issue with me pushing such a huge patch? -- Guillaume http://www.postgresql.fr

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-11 Thread Dave Page
On Thu, Nov 11, 2010 at 9:24 PM, Guillaume Lelarge wrote: > > Just waiting to know Dave's opinion on all this before moving on. I'm leaning to tabs. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-11 Thread Guillaume Lelarge
Le 11/11/2010 22:10, Robert Haas a écrit : > On Tue, Nov 2, 2010 at 5:52 PM, Guillaume Lelarge > wrote: >> Le 24/10/2010 07:49, Dave Page a écrit : >>> On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge >>> wrote: IIRC, we should use spaces and not tabs. If I look into the code, I see m

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-11 Thread Robert Haas
On Tue, Nov 2, 2010 at 5:52 PM, Guillaume Lelarge wrote: > Le 24/10/2010 07:49, Dave Page a écrit : >> On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge >> wrote: >>> IIRC, we should use spaces and not tabs. If I look into the code, I see >>> many tabs in it. I can of course configure my editor

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-04 Thread Benedek László
On 2010-11-03 17:58, Guillaume Lelarge wrote: > I'm actually quite impressed with it. I worked a bit with it, and > "-pbSs4" seems to do quite good stuff for us. > > Do you use other command line options with this tool? I use a .astylerc file for my projects, which contains the following: --styl

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-03 Thread Guillaume Lelarge
Le 03/11/2010 01:05, Benedek László a écrit : > On 2010-10-24 17:05, Magnus Hagander wrote: > >> Also if going there - has anybody investigated if it's possible to get >> pgindent to work on C++ files? Or if there's another similar tool we >> could/should use? >> > > I use astyle for my C++ sourc

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-03 Thread Benedek László
On 2010-10-24 17:05, Magnus Hagander wrote: > Also if going there - has anybody investigated if it's possible to get > pgindent to work on C++ files? Or if there's another similar tool we > could/should use? > I use astyle for my C++ source code auto formatting. It has a lot of formatting option

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-03 Thread Benedek László
On 2010-10-24 17:05, Magnus Hagander wrote: > > Also if going there - has anybody investigated if it's possible to get > > pgindent to work on C++ files? Or if there's another similar tool we > > could/should use? > > I use astyle for my C++ source code auto formatting. It has a lot of formatting

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-02 Thread Guillaume Lelarge
Le 24/10/2010 07:49, Dave Page a écrit : > On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge > wrote: >> IIRC, we should use spaces and not tabs. If I look into the code, I see >> many tabs in it. I can of course configure my editor to display them as >> four tabs, but I would really like to get

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-11-02 Thread Guillaume Lelarge
Le 24/10/2010 08:10, Guillaume Lelarge a écrit : > Le 24/10/2010 08:05, Magnus Hagander a écrit : >> On Sun, Oct 24, 2010 at 07:49, Dave Page wrote: >>> On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge >>> wrote: IIRC, we should use spaces and not tabs. If I look into the code, I see

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-10-24 Thread Guillaume Lelarge
Le 24/10/2010 08:05, Magnus Hagander a écrit : > On Sun, Oct 24, 2010 at 07:49, Dave Page wrote: >> On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge >> wrote: >>> IIRC, we should use spaces and not tabs. If I look into the code, I see >>> many tabs in it. I can of course configure my editor to

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-10-24 Thread Magnus Hagander
On Sun, Oct 24, 2010 at 07:49, Dave Page wrote: > On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge > wrote: >> IIRC, we should use spaces and not tabs. If I look into the code, I see >> many tabs in it. I can of course configure my editor to display them as >> four tabs, but I would really like

Re: [pgadmin-hackers] 4 spaces versus tabs

2010-10-24 Thread Dave Page
On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge wrote: > IIRC, we should use spaces and not tabs. If I look into the code, I see > many tabs in it. I can of course configure my editor to display them as > four tabs, but I would really like to get rid of them. > > Any objections? because it woul

[pgadmin-hackers] 4 spaces versus tabs

2010-10-24 Thread Guillaume Lelarge
IIRC, we should use spaces and not tabs. If I look into the code, I see many tabs in it. I can of course configure my editor to display them as four tabs, but I would really like to get rid of them. Any objections? because it would be a hell of a patch (90427 replacements) -- Guillaume http://