Re: [pgadmin-hackers] A bunch of minor issues

2007-11-23 Thread Dave Page
Heikki Linnakangas wrote: > Euler Taveira de Oliveira wrote: >> Heikki Linnakangas wrote: >>> Attached is a patch to change a few string constructions to be more >>> localization-friendly. There's still a lot of troublesome constructs >> where is the patch? > > Oh crap. Here.. :-) Thanks Heikki,

Re: [pgadmin-hackers] A bunch of minor issues

2007-10-01 Thread Dave Page
Heikki Linnakangas wrote: Ok. I submitted the wx patch to the wxWidgets patch tracker: https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1803492&group_id=9863 We'll see how that goes... It was committed to wxWidgets, with some modifications. Nice. It turns out that the changes to

Re: [pgadmin-hackers] A bunch of minor issues

2007-10-01 Thread Heikki Linnakangas
Heikki Linnakangas wrote: > Dave Page wrote: >> Heikki Linnakangas wrote: >>> Dave Page wrote: I'd be more interested in the patches so I can update my utilities and those of developer.pgadmin.org where stringextract tends to be run (I imagine Guillaume would like a copy too). >>> Ok

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-27 Thread Heikki Linnakangas
Dave Page wrote: > Heikki Linnakangas wrote: >> Dave Page wrote: >>> I'd be more interested in the patches so I can update my utilities and >>> those of developer.pgadmin.org where stringextract tends to be run (I >>> imagine Guillaume would like a copy too). >> Ok. Here's two patches to enable tha

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-27 Thread Dave Page
Heikki Linnakangas wrote: > Dave Page wrote: >> I'd be more interested in the patches so I can update my utilities and >> those of developer.pgadmin.org where stringextract tends to be run (I >> imagine Guillaume would like a copy too). > > Ok. Here's two patches to enable that: > > wx-linenumber

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-27 Thread Dave Page
Heikki Linnakangas wrote: > Dave Page wrote: >> Heikki Linnakangas wrote: >>> There's some strings in calls to wxLogDebug, like "OnTargetComplete() >>> called", that are wrapped in _() for translation. Aren't those just for >>> developers, and therefore a waste of time to translate? >> Yep. Removed

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > Heikki Linnakangas wrote: >> There's some strings in calls to wxLogDebug, like "OnTargetComplete() >> called", that are wrapped in _() for translation. Aren't those just for >> developers, and therefore a waste of time to translate? > > Yep. Removed. Here's a few more, though I

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Jyrki Wahlstedt wrote: > On 26.9.2007, at 14.26, Heikki Linnakangas wrote: >> Finnish texts do tend to more longer than English. It's not a problem in >> most places, but for example "Rename" in the favourites manager is >> translated to "Nimeä uudelleen", which is quite a bit longer. If we just >>

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > I'd be more interested in the patches so I can update my utilities and > those of developer.pgadmin.org where stringextract tends to be run (I > imagine Guillaume would like a copy too). Ok. Here's two patches to enable that: wx-linenumbers-in-wxrc-1.patch (against wxWidgets SV

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Heikki Linnakangas wrote: Dave Page wrote: REINDEX is similar to a drop and recreate of the index in that the index contents are rebuilt from scratch. However, the locking considerations are rather different. REINDEX locks out writes but not reads of the index's parent table. It also takes an ex

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > REINDEX is similar to a drop and recreate of the index in that the index > contents are rebuilt from scratch. However, the locking considerations > are rather different. REINDEX locks out writes but not reads of the > index's parent table. It also takes an exclusive lock on the s

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Guillaume Lelarge
Dave Page a écrit : > Heikki Linnakangas wrote: > [...] >> Meanwhile, anyone interested in the pgadmin3.pot file I have here with >> the file/line numbers in it? I can post it if so.. > > I'd be more interested in the patches so I can update my utilities and > those of developer.pgadmin.org where

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Guillaume Lelarge
Dave Page a écrit : > [Guillaume; I've left some of Heikki's suggestions to your discretion, > please read on...] > Thanks :) >> Attached is a patch to change a few string constructions to be more >> localization-friendly. There's still a lot of troublesome constructs >> like "Cannot drop system

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Jyrki Wahlstedt wrote: On 26.9.2007, at 14.26, Heikki Linnakangas wrote: Dave Page As you know I work in OS X and Windows most of the time and I know there are no sizing issues there in English. Is this something specific to running in Finnish (should that be Fin?), or GTK do you think? FI

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Heikki Linnakangas wrote: RECREATE is a pgAdmin extension that drops and recreates an index. What's the advantage of that, compared to normal REINDEX? Quoth the PG docs: REINDEX is similar to a drop and recreate of the index in that the index contents are rebuilt from scratch. However, the

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Jyrki Wahlstedt
On 26.9.2007, at 14.26, Heikki Linnakangas wrote: Dave Page As you know I work in OS X and Windows most of the time and I know there are no sizing issues there in English. Is this something specific to running in Finnish (should that be Fin?), or GTK do you think? FI (or fi) should be enou

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Heikki Linnakangas wrote: Really? . No, that change was backpatched all the way to 8.1 branch, which is the first release with 2PC. The check is in src/backend/access/transam/twophase.c: Rats - seems the test server I was using was 8.2.2. Oh well, easy fix committed. Thanks, Dave. -

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > [Guillaume; I've left some of Heikki's suggestions to your discretion, > please read on...] > > Heikki Linnakangas wrote: >> When creating a table or index, it would be nice if we checked that the >> value given for fillfactor is valid, within 0-100, in pgAdmin. Would be >> nice

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > Dave Page wrote: >>> When trying to commit/rollback a prepared transaction in a database >>> other than 'postgres', using the "server status" dialog, I always get >>> this error message: >>> >>> ERROR: prepared transaction belongs to another database >>> HINT: Connect to the da

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Dave Page wrote: When trying to commit/rollback a prepared transaction in a database other than 'postgres', using the "server status" dialog, I always get this error message: ERROR: prepared transaction belongs to another database HINT: Connect to the database where the transaction was prepare

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
[Guillaume; I've left some of Heikki's suggestions to your discretion, please read on...] Heikki Linnakangas wrote: Hi, I'm working on the Finnish translation to bring it up-to-date, and bumped into a few minor issues, mostly localization related. This is the first time I'm hacking or even usi

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Euler Taveira de Oliveira wrote: > Heikki Linnakangas wrote: >> Attached is a patch to change a few string constructions to be more >> localization-friendly. There's still a lot of troublesome constructs > where is the patch? Oh crap. Here.. -- Heikki Linnakangas EnterpriseDB http://www.en

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-25 Thread Euler Taveira de Oliveira
Heikki Linnakangas wrote: > I'm working on the Finnish translation to bring it up-to-date, and > bumped into a few minor issues, mostly localization related. This is the > first time I'm hacking or even using pgAdmin, so excuse me if some of > these topics have been discussed to death already: >

[pgadmin-hackers] A bunch of minor issues

2007-09-25 Thread Heikki Linnakangas
Hi, I'm working on the Finnish translation to bring it up-to-date, and bumped into a few minor issues, mostly localization related. This is the first time I'm hacking or even using pgAdmin, so excuse me if some of these topics have been discussed to death already: When creating a table or index,