Re: [pgadmin-hackers] Feature test issues

2017-03-03 Thread Dave Page
On Thu, Mar 2, 2017 at 2:36 PM, Atira Odhner wrote: > Just to clarify the change we made in this regard --- we use the 'reset > layout' link in the header between tests, but it essentially still does a > page load and doesn't save us time. If we were to do an actual page load we > would run into i

Re: [pgadmin-hackers] Feature test issues

2017-03-02 Thread Atira Odhner
Just to clarify the change we made in this regard --- we use the 'reset layout' link in the header between tests, but it essentially still does a page load and doesn't save us time. If we were to do an actual page load we would run into issues because of the navigation confirmation popup. If we wer

Re: [pgadmin-hackers] Feature test issues

2017-02-28 Thread Dave Page
On Tue, Feb 28, 2017 at 4:50 PM, Atira Odhner wrote: >> On my top-of-the-range-last-year Mac, startup takes about 14 seconds >> per test - that's from the start of the test, until the point at which >> the "Loading pgAdmin..." spinner vanishes. > > > That includes the time it takes to load the pag

Re: [pgadmin-hackers] Feature test issues

2017-02-28 Thread Atira Odhner
> > On my top-of-the-range-last-year Mac, startup takes about 14 seconds > per test - that's from the start of the test, until the point at which > the "Loading pgAdmin..." spinner vanishes. That includes the time it takes to load the page, not just app startup time. The spinner doesn't appear u

Re: [pgadmin-hackers] Feature test issues

2017-02-28 Thread Dave Page
On Mon, Feb 27, 2017 at 7:51 PM, Atira Odhner wrote: > The team here at Pivotal is doing TDD already. Running so many > configurations sounds like it belongs in a CI not in a TDD cycle. It is in a CI - that doesn't mean I don't want us to aim towards the point where we're doing TDD as well. > I

Re: [pgadmin-hackers] Feature test issues

2017-02-27 Thread Atira Odhner
The team here at Pivotal is doing TDD already. Running so many configurations sounds like it belongs in a CI not in a TDD cycle. I want to make sure we are making the most effective technical investment that we can. My thought process is generally: * Are we feeling pain from this right now? (is it

Re: [pgadmin-hackers] Feature test issues

2017-02-27 Thread Dave Page
On Sun, Feb 26, 2017 at 8:39 AM, Dave Page wrote: > > On the plus side, test runs are now green across the board with > feature tests enabled, except for Python 2.6 :-) I say that, however... - I've now seen the same error with Python 3.6 as with 2.6, yet whilst it's consistent on 2.6, it's inte

Re: [pgadmin-hackers] Feature test issues

2017-02-27 Thread Dave Page
On Mon, Feb 27, 2017 at 4:02 AM, Atira Odhner wrote: > Cool, we already have a task about proper teardown and a couple other things > in our backlog. we'll probably get to it in the next day or so. I'll take a > look at the other stuff. Thanks. > Also, regarding speed, even without the app start

Re: [pgadmin-hackers] Feature test issues

2017-02-26 Thread Ashesh Vashi
On Mon, Feb 27, 2017 at 9:32 AM, Atira Odhner wrote: > Cool, we already have a task about proper teardown and a couple other > things in our backlog. we'll probably get to it in the next day or so. I'll > take a look at the other stuff. > > Also, regarding speed, even without the app startup time

Re: [pgadmin-hackers] Feature test issues

2017-02-26 Thread Atira Odhner
Cool, we already have a task about proper teardown and a couple other things in our backlog. we'll probably get to it in the next day or so. I'll take a look at the other stuff. Also, regarding speed, even without the app startup time, end to end tests are always going to be relatively slow. We de

[pgadmin-hackers] Feature test issues

2017-02-26 Thread Dave Page
Hi Tira, George, I've just been updating our internal automated test system to run the feature tests, and ran into a couple of additional issues that need to be addressed. Can you look into the following please? - When starting pgAdmin, it's using the default configuration database (CONFIG['SQLIT