Re: [pgadmin-hackers] Fixed FB 20417

2012-01-10 Thread Dave Page
Thanks, patch applied! On Tue, Jan 10, 2012 at 10:53 AM, Akshay Joshi wrote: > > > On Tue, Jan 10, 2012 at 3:44 PM, Dave Page wrote: >> >> On Tue, Jan 10, 2012 at 10:09 AM, Akshay Joshi >> wrote: >> > >> > On Tue, Jan 10, 2012 at 3:09 PM, Dave Page wrote: >> >> >> >> On Tue, Jan 10, 2012 at 9:

Re: [pgadmin-hackers] Fixed FB 20417

2012-01-10 Thread Akshay Joshi
On Tue, Jan 10, 2012 at 3:44 PM, Dave Page wrote: > On Tue, Jan 10, 2012 at 10:09 AM, Akshay Joshi > wrote: > > > > On Tue, Jan 10, 2012 at 3:09 PM, Dave Page wrote: > >> > >> On Tue, Jan 10, 2012 at 9:36 AM, Guillaume Lelarge > >> wrote: > >> > On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi

Re: [pgadmin-hackers] Fixed FB 20417

2012-01-10 Thread Dave Page
On Tue, Jan 10, 2012 at 10:09 AM, Akshay Joshi wrote: > > On Tue, Jan 10, 2012 at 3:09 PM, Dave Page wrote: >> >> On Tue, Jan 10, 2012 at 9:36 AM, Guillaume Lelarge >> wrote: >> > On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi wrote: >> >> Hi Dave >> >> >> >> Modified the logic. Attached is the

Re: [pgadmin-hackers] Fixed FB 20417

2012-01-10 Thread Akshay Joshi
On Tue, Jan 10, 2012 at 3:09 PM, Dave Page wrote: > On Tue, Jan 10, 2012 at 9:36 AM, Guillaume Lelarge > wrote: > > On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi wrote: > >> Hi Dave > >> > >> Modified the logic. Attached is the patch file, please review it. > >> > > > > This is still wrong. bI

Re: [pgadmin-hackers] Fixed FB 20417

2012-01-10 Thread Dave Page
On Tue, Jan 10, 2012 at 9:36 AM, Guillaume Lelarge wrote: > On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi wrote: >> Hi Dave >> >> Modified the logic. Attached is the patch file, please review it. >> > > This is still wrong. bIsChangeComment isn't always true when the user > creates a replication

Re: [pgadmin-hackers] Fixed FB 20417

2012-01-10 Thread Guillaume Lelarge
On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi wrote: > Hi Dave > > Modified the logic. Attached is the patch file, please review it. > This is still wrong. bIsChangeComment isn't always true when the user creates a replication cluster. It's only true if there is a comment. -- Guillaume http

Re: [pgadmin-hackers] Fixed FB 20417

2012-01-10 Thread Akshay Joshi
Hi Dave Modified the logic. Attached is the patch file, please review it. On Mon, Jan 9, 2012 at 6:04 PM, Dave Page wrote: > On Mon, Jan 9, 2012 at 11:23 AM, Akshay Joshi > wrote: > > Hi Dave > > > > I have fixed the Fogbugz 20417 "PEM client: Unable to remove comments on > > slony Replication

Re: [pgadmin-hackers] Fixed FB 20417

2012-01-09 Thread Dave Page
On Mon, Jan 9, 2012 at 11:23 AM, Akshay Joshi wrote: > Hi Dave > > I have fixed the Fogbugz 20417 "PEM client: Unable to remove comments on > slony Replication(edb_cluster) tab". Attached is the patch file, please > review it. Hi, I think the patch is basically correct, but needs a small mod so

[pgadmin-hackers] Fixed FB 20417

2012-01-09 Thread Akshay Joshi
Hi Dave I have fixed the Fogbugz 20417 "PEM client: Unable to remove comments on slony Replication(edb_cluster) tab". Attached is the patch file, please review it. -- *Akshay Joshi Senior Software Engineer EnterpriseDB Corporation The Enterprise PostgreSQL Company Phone: +91 20-3058-9522 Mobile: