Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-07 Thread Dave Page
Thanks - applied to head. On Thu, Feb 6, 2014 at 7:49 AM, Akshay Joshi wrote: > > > > On Wed, Feb 5, 2014 at 7:49 PM, Dave Page wrote: > >> Hi >> >> >> On Wed, Feb 5, 2014 at 7:42 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> I have removed the check like "i

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-05 Thread Akshay Joshi
On Wed, Feb 5, 2014 at 7:49 PM, Dave Page wrote: > Hi > > > On Wed, Feb 5, 2014 at 7:42 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> I have removed the check like "if (i > 0 || i ==0)" from many places >> except one. I have tried to fix compiler warnings either by

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-05 Thread Dave Page
Hi On Wed, Feb 5, 2014 at 7:42 AM, Akshay Joshi wrote: > Hi Dave > > I have removed the check like "if (i > 0 || i ==0)" from many places > except one. I have tried to fix compiler warnings either by modifying the > logic or putting some other checks. Attached is the modified patch, please > rev

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-04 Thread Akshay Joshi
Hi Dave I have removed the check like "if (i > 0 || i ==0)" from many places except one. I have tried to fix compiler warnings either by modifying the logic or putting some other checks. Attached is the modified patch, please review it. On Mon, Feb 3, 2014 at 3:13 PM, Akshay Joshi wrote: > > >

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-03 Thread Akshay Joshi
On Mon, Feb 3, 2014 at 2:51 PM, Dave Page wrote: > > > > On Mon, Feb 3, 2014 at 6:50 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks Ashesh, >> >> >> On Mon, Feb 3, 2014 at 11:49 AM, Ashesh Vashi > .com> wrote: >> >>> Akshay, >>> >>> wxGetSingleChoiceIndex returns integer n

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-03 Thread Dave Page
On Mon, Feb 3, 2014 at 6:50 AM, Akshay Joshi wrote: > Thanks Ashesh, > > > On Mon, Feb 3, 2014 at 11:49 AM, Ashesh Vashi .com> wrote: > >> Akshay, >> >> wxGetSingleChoiceIndex returns integer not "unsigned integer" >> And, this syntax is definitely wrong in any case for unsigned integers >> > >

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-03 Thread Dave Page
On Mon, Feb 3, 2014 at 6:04 AM, Akshay Joshi wrote: > > > > On Fri, Jan 31, 2014 at 7:26 PM, Dave Page wrote: > >> >> >> >> On Fri, Jan 31, 2014 at 6:03 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> >>> On Thu, Jan 30, 2014 at 7:35 PM, Dave Page wrote: >>> Hi >>

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-02 Thread Akshay Joshi
Thanks Ashesh, On Mon, Feb 3, 2014 at 11:49 AM, Ashesh Vashi wrote: > Akshay, > > wxGetSingleChoiceIndex returns integer not "unsigned integer" > And, this syntax is definitely wrong in any case for unsigned integers > Fixed the above by changing the data type from "unsigned int" to "int",

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-02 Thread Ashesh Vashi
Akshay, wxGetSingleChoiceIndex returns integer not "unsigned integer" And, this syntax is definitely wrong in any case for unsigned integers if (i > 0 || i == 0) On Mon, Feb 3, 2014 at 11:34 AM, Akshay Joshi wrote: > > > > On Fri, Jan 31, 2014 at 7:26 PM, Dave Page wrote: > >> >> >> >> On Fri

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-02-02 Thread Akshay Joshi
On Fri, Jan 31, 2014 at 7:26 PM, Dave Page wrote: > > > > On Fri, Jan 31, 2014 at 6:03 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> >> On Thu, Jan 30, 2014 at 7:35 PM, Dave Page wrote: >> >>> Hi >>> >>> >>> On Thu, Jan 30, 2014 at 9:35 AM, Akshay Joshi < >>> akshay.jo...

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-01-31 Thread Dave Page
On Fri, Jan 31, 2014 at 6:03 AM, Akshay Joshi wrote: > > > > On Thu, Jan 30, 2014 at 7:35 PM, Dave Page wrote: > >> Hi >> >> >> On Thu, Jan 30, 2014 at 9:35 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> I have fixed some compiler warnings which we are facing

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-01-30 Thread Akshay Joshi
On Thu, Jan 30, 2014 at 7:35 PM, Dave Page wrote: > Hi > > > On Thu, Jan 30, 2014 at 9:35 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> I have fixed some compiler warnings which we are facing on OSXMavericks. >> Attached >> is the patch file. Can you please review

Re: [pgadmin-hackers] Fixed some compiler warnings

2014-01-30 Thread Dave Page
Hi On Thu, Jan 30, 2014 at 9:35 AM, Akshay Joshi wrote: > Hi Dave > > I have fixed some compiler warnings which we are facing on OSX Mavericks. > Attached > is the patch file. Can you please review it. > > If patch looks good to you then can you please commit it. > > It mostly looks good, but

[pgadmin-hackers] Fixed some compiler warnings

2014-01-30 Thread Akshay Joshi
Hi Dave I have fixed some compiler warnings which we are facing on OSX Mavericks. Attached is the patch file. Can you please review it. If patch looks good to you then can you please commit it. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*