Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-11 Thread Dave Page
On Feb 10, 2008 3:47 PM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > > As promised, here are two other patches, one each for the following: > > > 1. IS DISTINCT FROM to replace '<>' in the WHERE conditions > 2. Documentation addition in the html about the recent Selection/Sort > changes. Thanks

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-11 Thread Dave Page
On Feb 9, 2008 6:52 PM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > Hi, > > Hmmm... although I did do a complete svn co before submitting my previous > patch, I think I am making it all complicated by bringing in too many things > together. > > I think you're right. Probably its better to do one t

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-10 Thread Robins Tharakan
> > I fixed that when I committed your first patch - or did you find > something else wrong? > Oops :) No I didn't find anything else wrong. Robins

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-10 Thread Dave Page
On Feb 10, 2008 3:47 PM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > > As promised, here are two other patches, one each for the following: > > > 1. IS DISTINCT FROM to replace '<>' in the WHERE conditions > 2. Documentation addition in the html about the recent Selection/Sort > changes. > > Still

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-10 Thread Robins Tharakan
Running(). *Robins* -- Forwarded message -- From: Robins Tharakan <[EMAIL PROTECTED]> Date: Feb 10, 2008 12:22 AM Subject: Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid To: Dave Page <[EMAIL PROTECTED]> Cc: pgadmin-hackers@postgresql.org Hi, Hmmm... although I did do a compl

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-09 Thread Robins Tharakan
t a thread->IsRunning() in frmEdit.cpp (line: ~414) doesn't cause a crash. *Robins Tharakan* -- Forwarded message -- From: Dave Page <[EMAIL PROTECTED]> Date: Feb 7, 2008 4:50 PM Subject: Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid To: Robins Tharakan <

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-07 Thread Dave Page
Hi. On Feb 6, 2008 5:42 PM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > Hi, > > The attached patch does this: > 1. Sanitize the if-else bracket style for the earlier patch. > 2. Use 'IS DISTINCT FROM' instead of <> in an exclusion condition. > > Two issues remain that I can't resolve: > 1. Rightl

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-06 Thread Robins Tharakan
y resolve this would need a inverted tree structure for the where clause which I think is a bit of an overkill for now ? Any hints for a better way to work around these ? *Robins* -- Forwarded message -- From: Dave Page <[EMAIL PROTECTED]> Date: Feb 6, 2008 5:11 PM Sub

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-06 Thread Dave Page
On Feb 6, 2008 11:02 AM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > > ... snip ... > Sure ! Points that I'll take into account from now on. > > > > One other thing I noticed that should be fixed in a new patch - if you > > sort ascending on a column, and then sort descending, it will add > > bot

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-06 Thread Robins Tharakan
> ... snip ... Sure ! Points that I'll take into account from now on. > One other thing I noticed that should be fixed in a new patch - if you > sort ascending on a column, and then sort descending, it will add > both. It should remove the ascending and replace it with the > descending sort. True

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-06 Thread Dave Page
On Feb 5, 2008 5:57 PM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > Sure, I'll try and keep separate patches in separate emails. > Attached is reworked patch which takes care of the issues that you > mentioned. > > Updates in this patch: > 1. Removed the extra separator that came up on right-clic

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-05 Thread Robins Tharakan
Hi Dave, > OK, slow down :-). ... snip If you want to add more functionality, post a new patch, > otherwise the process just becomes a lot more complicated. Sorry for jumping the gun ! I didn't think that this kind of a complication could ariseGuess it shows that this is my first patch submis

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-05 Thread Robins Tharakan
> Hi Dave, > > > OK, slow down :-). ... snip If you want to add more functionality, post > a new patch, > > otherwise the process just becomes a lot more complicated. > > Sorry for jumping the gun ! > I didn't think that this kind of a complication could ariseGuess it > shows that this is my f

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-05 Thread Dave Page
Hi On Feb 5, 2008 12:54 PM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > > The last item on the contextual menu is a separator. I wonder why ? > > > Thats more of a mistake of sorts... Actually I am half way into adding the > Copy/Paste on the right-click. > Just that I thought I should finalize

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-05 Thread Robins Tharakan
Hi, So one more positive note. This is really great. It helps working > quicker with pgAdmin. So, thanks a lot :) > Thanks :) The idea essentially is usability. (For my work here at office, PG's usability is directly linked to my productivity.) The last item on the contextual menu is a separato

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-05 Thread Robins Tharakan
> > Hi, > > So one more positive note. This is really great. It helps working > > quicker with pgAdmin. So, thanks a lot :) > > > > Thanks :) The idea essentially is usability. > (For my work here at office, PG's usability is directly linked to my > productivity.) > > The last item on the contextu

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-05 Thread Guillaume Lelarge
Hi Robins, Robins Tharakan wrote: Thanks for the feedback. A positive note certainly helps :) So one more positive note. This is really great. It helps working quicker with pgAdmin. So, thanks a lot :) I've tried to work on the things mentioned and although I can think of a few more addit

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-04 Thread Robins Tharakan
the sort options) refresh the grid immediately. Hope I didn't miss anything! Regards, *Robins Tharakan* -- Forwarded message -- From: Dave Page <[EMAIL PROTECTED]> Date: Feb 4, 2008 5:55 PM Subject: Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid To: [EMAIL PROT

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-04 Thread Robins Tharakan
the sort options) refresh the grid immediately. Hope I didn't miss anything! Regards, *Robins Tharakan* -- Forwarded message -- From: Dave Page <[EMAIL PROTECTED]> Date: Feb 4, 2008 5:55 PM Subject: Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-04 Thread Dave Page
Hi, On Feb 1, 2008 4:38 AM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > The good part is that now the patch does the following: > 1. Provide options for 'Filter by Selection' / 'Filter Excluding Selection' > / 'Remove Filter' > 2. Takes care if cells have NULL value > 3. Takes multiple Include /

[pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-01-31 Thread Robins Tharakan
Hi, [Attempting a last try at mailing to a list (this time without the image attachment ! may be that's silently deleting my email from the list ?) Sorry in case you are getting this mail again and again, but I can't find this email in the archives so I guess it's getting lost somewhere.] In case