Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Thanks, applied with minor changes to use the home dir as the default save location, and to store the save location as a persistent setting. On Mon, Jul 18, 2016 at 1:27 PM, Neel Patel wrote: > Hi, > > Please find attached patch file to support server side download in runtime > application. > >

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Thanks, applied. On Mon, Jul 18, 2016 at 1:01 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA rebased patch RM1405 (version 4) > > Neel will be sending patch for QT issue for same functionality. > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: htt

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, Please find attached patch file to support server side download in runtime application. NOTE: Before applying this patch, use above harshal's patch. Thanks, Neel Patel On Mon, Jul 18, 2016 at 5:31 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA rebased patch RM14

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, PFA rebased patch RM1405 (version 4) Neel will be sending patch for QT issue for same functionality. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 18, 2016 at 4:02 PM, Dave Page wrote: > Perfect, tha

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Perfect, thanks! On Mon, Jul 18, 2016 at 11:24 AM, Neel Patel wrote: > Yes. I am just testing with different OS. I will send it next 1-2 hour. > > Is it fine ? > > Thanks, > Neel Patel > > On Mon, Jul 18, 2016 at 3:53 PM, Dave Page wrote: > >> Any chance of getting that in the next couple of ho

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Yes. I am just testing with different OS. I will send it next 1-2 hour. Is it fine ? Thanks, Neel Patel On Mon, Jul 18, 2016 at 3:53 PM, Dave Page wrote: > Any chance of getting that in the next couple of hours so I can get it > into beta 3? > > On Mon, Jul 18, 2016 at 11:18 AM, Dave Page wro

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Any chance of getting that in the next couple of hours so I can get it into beta 3? On Mon, Jul 18, 2016 at 11:18 AM, Dave Page wrote: > Thanks! > > On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel > wrote: > >> Hi Dave, >> >> Yes, it will break in runtime. If we need to support downloading at >> s

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Thanks! On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel wrote: > Hi Dave, > > Yes, it will break in runtime. If we need to support downloading at server > side then we need to change the runtime code. > I will send the patch for runtime to support server side download CSV file. > > Thanks, > Neel P

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi Dave, Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code. I will send the patch for runtime to support server side download CSV file. Thanks, Neel Patel On Fri, Jul 15, 2016 at 3:05 PM, Dave Page wrote: > Hi > > This seems

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is sho

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, PFA rebased patch for RM1405 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Yes sure > > -- > *Harshal Dhumal* > *Software

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Yes sure -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 13, 2016 at 5:10 PM, Dave Page wrote: > Hi > > Can you rebase this please? > > Thanks. > > On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal < > harshal

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi Can you rebase this please? Thanks. On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for RM1405. Also to allow download in runtime we will still need > patch >

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel. Changes: To download query result to CSV directly from server and not to use download

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala wrote: > Yes, It will not work in runtime as well but I think Neel is working for > fix in run time for this issue, We might able to fix it in run time but > issue persists in Safari unless they add support in browser itself. > > https://webkit.o

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Neel is just adding the ability to save a file rather than display it. His work won't add the APIs to do client-side downloads - though it will be needed to support that. On Wed, Jun 29, 2016 at 11:22 AM, Murtuza Zabuawala wrote: > Yes, It will not work in runtime as well but I think Neel is work

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself. https://webkit.org/status/#feature-download-attribute > On 29-Jun-2016, at 3:40 p

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala wrote: > Yes Dave, I agree that downloading files has been supported in browsers since > long . > > But in general we send request & then receives files from web server but in > our case we are fetching our data from Backbone models & then conv

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Yes Dave, I agree that downloading files has been supported in browsers since long . But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

On Tue, Jun 28, 2016 at 7:08 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Yes, Safari is exception case because it does not support download attribute > of hyperlink element. > > Ref: http://caniuse.com/#feat=download > > I was not able to find any workaround for Safari as of now that’s is why I

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi Dave, Yes, Safari is exception case because it does not support download attribute of hyperlink element. Ref: http://caniuse.com/#feat=download I was not able to find any workaround for Safari as of now that’s is why I mentioned only Firefox & IE in my last email, Earlier it was only wor

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi On Mon, Jun 27, 2016 at 1:08 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue for downloading query output as CSV not working > in Firefox & IE. > Also fixes the issue that HTML tags were also appended in columns title in > CSV header. > > Browser side fix for -> RM#1405 This

[pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, PFA patch to fix the issue for downloading query output as CSV not working in Firefox & IE. Also fixes the issue that HTML tags were also appended in columns title in CSV header. Browser side fix for -> RM#1405 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enter