Re: [pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Thanks J.F. Oster for the patch, and Sanket Mehta for reviewing it. I've committed it in the repository. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

Re: [pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Hi J.F., Thank you for the explanation. I have reviewed the patch. It resolves both issues mentioned in the explanation. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Tue, Oct 28, 2014 at 10:16 PM, J.F. Oster wrote: > Hello Sanket, > > Steps to reveal issues: > > 1. Prepare test

Re: [pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Hello Sanket, Steps to reveal issues: 1. Prepare test tables: CREATE TABLE tserial2 ( a smallserial NOT NULL, dat text, CONSTRAINT tserial2_pkey PRIMARY KEY (a) ); -- Create these for reference (to compare): CREATE TABLE tserial(

Re: [pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Hi, Can you please explain in which case it will create issue if bug is not applied? Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Oct 27, 2014 at 4:14 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Fri, Oct 24, 2014 at 8:12 PM, J.F. Oster wrote:

Re: [pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Ashesh, can you review/commit this please? On Fri, Oct 24, 2014 at 8:12 PM, J.F. Oster wrote: > Hello! > > This patch adds a few missing lines of code to handle smallserial > columns the same way as serial and bigserial. > > > -- > Best regards, > J.F. > > -- > Sent via pgadmin-hackers mailing l

[pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Hello! This patch adds a few missing lines of code to handle smallserial columns the same way as serial and bigserial. -- Best regards, J.F. 141024_editgrid_serial.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to you