Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-26 Thread Priyanka Shendge
1 more point to add: 5. Synonyms should only run for EPAS server On 26 August 2016 at 16:44, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > Hi Murtuza, > > Please find my review comments below: > > 1. Please attach test_advanced_config.json.in file to read the config data > 2. Wh

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-26 Thread Priyanka Shendge
Hi Murtuza, Please find my review comments below: 1. Please attach test_advanced_config.json.in file to read the config data 2. While reading data from config file "owner" field is missing 3. Please add synonym pickle object to ../regression/test_utils.py file 4. Can we have config data parameter

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-26 Thread Akshay Joshi
Thanks, patch applied. On Thu, Aug 25, 2016 at 7:58 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find updated patch. > > I have also fixed the issue in package node which was displaying create > menu in PG server. (separate patch attached) > > -- > Regards,

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-25 Thread Murtuza Zabuawala
Hi, Please find updated patch. I have also fixed the issue in package node which was displaying create menu in PG server. (separate patch attached) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Aug 25, 2016 at 4:34 PM, Akshay J

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-25 Thread Akshay Joshi
Hi Murtuza Following are my review comments: - Create "Synonym" option is visible for Postgres Servers, when right click on schema node. - Unable to create Public Synonym faced "Internal Server Error". - SQL help not working when click on "[i]" button. - "Public Synonyms?" switch c

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-25 Thread Murtuza Zabuawala
Hi, PFA updated patch with `--binary` option for .png files. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Aug 25, 2016 at 12:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch for synonym

[pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-24 Thread Murtuza Zabuawala
Hi, PFA patch for synonym node, this patch also includes basic unit test cases. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/synonyms/__init__.py b/