Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-26 Thread Dave Page
Hi I've applied the misc changes patch, but it looks like you forgot the --binary option for the pgAgent patch. Can you recreate it please? Thanks. On Fri, Sep 23, 2016 at 9:34 PM, Ashesh Vashi wrote: > Hi Dave, > > > On Thu, Sep 22, 2016 at 8:27 PM, Dave Page wrote: > >> Thanks. From the pgA

Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-23 Thread Ashesh Vashi
Thanks - working on the rest of the comments. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Sep 23, 2016 at 2:40 PM, Dave Page wrote:

Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-23 Thread Dave Page
Thanks, applied. On Fri, Sep 23, 2016 at 7:33 AM, Ashesh Vashi wrote: > Hi Dave, > > > On Thu, Sep 22, 2016 at 8:01 PM, Dave Page wrote: >> >> Hi >> >> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi >> wrote: >>> >>> Hi Dave, >>> >>> Please find the patch for support for paAgent in pgAdmin 4. >

Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-22 Thread Ashesh Vashi
Hi Dave, On Thu, Sep 22, 2016 at 8:01 PM, Dave Page wrote: > Hi > > On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the patch for support for paAgent in pgAdmin 4. >> > > Did you forget the binary switch? > > piranha:web d

Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-22 Thread Dave Page
Thanks. From the pgAgent patch: - The date/time format is different again. Should be locale or ISO (consistent across the app) - I think we need to add hints under the less obvious options - e.g. Job class and host agent - On the job step subnode control, lets move the Script to it's own tab (ca

Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-22 Thread Ashesh Vashi
Will look at them. On Sep 22, 2016 20:08, "Dave Page" wrote: > Hmm - that was clearly hiding from me. I'll take a look now. > > Did you see the rest of my comments? > > On Thu, Sep 22, 2016 at 3:37 PM, Ashesh Vashi > wrote: > > I sent an updated patch immediately. > > > > > > On Sep 22, 2016 20

Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-22 Thread Dave Page
Hmm - that was clearly hiding from me. I'll take a look now. Did you see the rest of my comments? On Thu, Sep 22, 2016 at 3:37 PM, Ashesh Vashi wrote: > I sent an updated patch immediately. > > > On Sep 22, 2016 20:01, "Dave Page" wrote: >> >> Hi >> >> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh V

Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-22 Thread Ashesh Vashi
I sent an updated patch immediately. On Sep 22, 2016 20:01, "Dave Page" wrote: > Hi > > On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the patch for support for paAgent in pgAdmin 4. >> > > Did you forget the binary switch

Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-22 Thread Dave Page
Hi On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the patch for support for paAgent in pgAdmin 4. > Did you forget the binary switch? piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch error: cannot apply binary