Re: [pgadmin-hackers] Patch: database version check

2009-01-14 Thread Dave Page
On Wed, Jan 14, 2009 at 2:20 AM, Quan Zongliang wrote: > BTW: > With import function, some base class changed. > Two new methods: CanImport and CanExport added to pgObject class. > For pgTable, if it has column, both return true. If not, both return false. > For pgView, CanImport return false and

Re: [pgadmin-hackers] Patch: database version check

2009-01-13 Thread Quan Zongliang
> Without the whole patch it's somewhat tricky to apply :-p > > I've manually hacked up something roughly equivalent and committed it. The patch file has been attached. But that definition is strange. So I tried to describe it. After thought cursorily, I think minor-version + 1 is wrong. (foolish

Re: [pgadmin-hackers] Patch: database version check

2009-01-13 Thread Dave Page
On Tue, Jan 13, 2009 at 9:25 AM, Quan Zongliang wrote: > Hi, Dave > > very simple patch: > > pgAdmin3.h > +const short SERVER_MAX_VERSION = 0x0805;//Exclusive > > pgServer.cpp > > +if (conn->BackendMinimumVersion(SERVER_MAX_VERSION >> 8, > SERVER_MAX_VERSION & 0x00FF)) > +wxMe

[pgadmin-hackers] Patch: database version check

2009-01-13 Thread Quan Zongliang
Hi, Dave very simple patch: pgAdmin3.h +const short SERVER_MAX_VERSION = 0x0805;//Exclusive pgServer.cpp +if (conn->BackendMinimumVersion(SERVER_MAX_VERSION >> 8, SERVER_MAX_VERSION & 0x00FF)) +wxMessageBox(_("Connected to newer database using old version pgAdmin, some fun