Re: [pgadmin-hackers] Refresh objects on Click

2011-08-29 Thread Guillaume Lelarge
On Fri, 2011-08-26 at 23:10 +0200, Guillaume Lelarge wrote: > On Thu, 2011-08-25 at 22:14 -0300, Vinicius Santos wrote: > > Em 25/08/2011 19:23, Dave Page escreveu: > > > I rolled back Vinicius' patch and tested, and still see the error. I > > > think it's your patch that's at fault:-( > > I tested

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-26 Thread Guillaume Lelarge
On Thu, 2011-08-25 at 22:14 -0300, Vinicius Santos wrote: > Em 25/08/2011 19:23, Dave Page escreveu: > > I rolled back Vinicius' patch and tested, and still see the error. I > > think it's your patch that's at fault:-( > I tested here too, with all the lines of my patch comment, and the error > ye

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-25 Thread Vinicius Santos
Em 25/08/2011 19:23, Dave Page escreveu: I rolled back Vinicius' patch and tested, and still see the error. I think it's your patch that's at fault:-( I tested here too, with all the lines of my patch comment, and the error yet occurs. -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-25 Thread Dave Page
On Thu, Aug 25, 2011 at 10:16 PM, Guillaume Lelarge wrote: > I think there is a huge issue on this patch. I cannot alter a column > since it has been applied. I always end up with this message: > > There are properties dialogues open for one or more objects that would > be refreshed. Please close

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-25 Thread Guillaume Lelarge
On Wed, 2011-08-24 at 13:01 +0100, Dave Page wrote: > On Wed, Aug 24, 2011 at 3:29 AM, Vinicius Santos > wrote: > > Em 22/08/2011 08:04, Dave Page escreveu: > >> > >> Thanks - that applies cleanly now. Unfortunately, it still doesn't > >> work properly. Please see the attached screenshot. That was

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-24 Thread Dave Page
On Wed, Aug 24, 2011 at 3:29 AM, Vinicius Santos wrote: > Em 22/08/2011 08:04, Dave Page escreveu: >> >> Thanks - that applies cleanly now. Unfortunately, it still doesn't >> work properly. Please see the attached screenshot. That was taken with >> "refresh object and children" turned on - I click

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-23 Thread Vinicius Santos
Em 22/08/2011 08:04, Dave Page escreveu: Thanks - that applies cleanly now. Unfortunately, it still doesn't work properly. Please see the attached screenshot. That was taken with "refresh object and children" turned on - I clicked on the table "test" and then clicked on the parent schema "public"

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-22 Thread Guillaume Lelarge
On Mon, 2011-08-22 at 12:04 +0100, Dave Page wrote: > On Sun, Aug 21, 2011 at 10:14 PM, Vinicius Santos > wrote: > > Em 19/08/2011 16:13, Vinicius Santos escreveu: > > > > 2011/8/19 Dave Page > >> > >> Hi, > >> > >> I just came to review this again (following a hectic week - sorry!). > >> Unfortu

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-22 Thread Dave Page
On Sun, Aug 21, 2011 at 10:14 PM, Vinicius Santos wrote: > Em 19/08/2011 16:13, Vinicius Santos escreveu: > > 2011/8/19 Dave Page >> >> Hi, >> >> I just came to review this again (following a hectic week - sorry!). >> Unfortunately it no longer applies as frmOptions has been redesigned. >> Can yo

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-21 Thread Vinicius Santos
Em 19/08/2011 16:13, Vinicius Santos escreveu: 2011/8/19 Dave Page mailto:dp...@pgadmin.org>> Hi, I just came to review this again (following a hectic week - sorry!). Unfortunately it no longer applies as frmOptions has been redesigned. Can you update the patch please? The pat

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-19 Thread Dave Page
Hi, I just came to review this again (following a hectic week - sorry!). Unfortunately it no longer applies as frmOptions has been redesigned. Can you update the patch please? Thanks. On Sat, Aug 13, 2011 at 5:16 AM, Vinicius Santos wrote: > > -- Dave Page Blog: http://pgsnake.blogspot.com

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-12 Thread Vinicius Santos
>From 63c2b20eff916b89fee7135d754094a35f01770c Mon Sep 17 00:00:00 2001 From: Vinicius Santos Date: Sat, 13 Aug 2011 01:03:11 -0300 Subject: [PATCH] Implement Refresh Object on Click. --- pgadmin/frm/events.cpp | 49 +++ pgadmin/frm/frmOptions.cpp

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-12 Thread Vinicius Santos
Em 11/08/2011 07:25, Dave Page escreveu: - On frmOptions, the combo box to select the refresh mode should be to the right of the label, not underneath. The sizing should following the layout of other tabs. Done. - In "Refresh object on click" mode, if I click a table, and then click the parent

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-11 Thread Dave Page
On Thu, Aug 11, 2011 at 4:20 AM, Vinicius Santos wrote: > Em 10/08/2011 07:34, Dave Page escreveu: >> >> Please see about fixing those issues, and then I can give it a more in >> depth review. > > I fixed the items in question, and performed some more tests. > > Apparently it's OK. > > If any bugs

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-10 Thread Vinicius Santos
Em 10/08/2011 07:34, Dave Page escreveu: Please see about fixing those issues, and then I can give it a more in depth review. I fixed the items in question, and performed some more tests. Apparently it's OK. If any bugs or any suggestions, please let me know. The new patch is attached. Thank

Re: [pgadmin-hackers] Refresh objects on Click

2011-08-10 Thread Dave Page
Hi, On Wed, Aug 10, 2011 at 4:30 AM, Vinicius Santos wrote: > Hi Dave, > > I'm sending the patch on the Refresh object on Click[1]. > > I put the three options. "None", "Refresh object on click" and "Refresh > object and children on click" > > You can review it? Still seems to need some work unf

[pgadmin-hackers] Refresh objects on Click

2011-08-09 Thread Vinicius Santos
Hi Dave, I'm sending the patch on the Refresh object on Click[1]. I put the three options. "None", "Refresh object on click" and "Refresh object and children on click" You can review it? PS: Forgive me, of a mistake in my English. Thank You. [1] = http://archives.postgresql.org/pgadmin-hac