Re: [pgadmin-hackers] SSH Tunneling Patch

2013-05-07 Thread Dave Page
Thanks - pushed. On Tue, May 7, 2013 at 1:03 PM, Ashesh Vashi wrote: > Hi Dave, > > We adopted few configuration from libssh2 related to validate and check > existance of different dependent libraries/packages required by libssh2. > (i.e. openssl, libz, etc.) > > libssh2 configuration does adopt

Re: [pgadmin-hackers] SSH Tunneling Patch

2013-05-07 Thread Ashesh Vashi
Hi Dave, We adopted few configuration from libssh2 related to validate and check existance of different dependent libraries/packages required by libssh2. (i.e. openssl, libz, etc.) libssh2 configuration does adopted few acconfig functions from gettext (found under libssh2/m4 directory). Hence, we

Re: [pgadmin-hackers] SSH Tunneling Patch

2013-05-07 Thread Dave Page
On Tue, May 7, 2013 at 9:09 AM, Akshay Joshi wrote: > Hi Dave > > > On Thu, May 2, 2013 at 10:14 PM, Dave Page wrote: >> >> Hi >> >> I committed the patch a little while back after testing successfully >> on Linux, Windows and Mac and adding some docs. Unfortunately, since >> then I've seen the f

Re: [pgadmin-hackers] SSH Tunneling Patch

2013-05-02 Thread Dave Page
Hi I committed the patch a little while back after testing successfully on Linux, Windows and Mac and adding some docs. Unfortunately, since then I've seen the following issues: - On OS X Tiger 10.4 (the EDB machine Tanaka), I got a compile failure: utils/sshTunnel.cpp:46: error: invalid convers

Re: [pgadmin-hackers] SSH Tunneling Patch

2013-05-01 Thread Dave Page
Well this is sooner than expected... The good news is, that today I cannot recreate the crash I saw previously in either debug or release builds on Mac. I'm guessing something must have been messed up in my environment previously, but it seems stable now. A couple of final review issues I have pic

Re: [pgadmin-hackers] SSH Tunneling Patch

2013-05-01 Thread Dave Page
Some feedback based on this version: - On the first connection attempt, if I get the SSH password wrong, the entire Server dialogue is dismissed, losing all the connection details I entered. I would expect the dialogue to be re-displayed so I could correct the error and try again. - Incorrect own