2005/12/15, Dave Page :
> > Le Mardi 13 Décembre 2005 00:48, Guillaume LELARGE a écrit:
> > > Le Samedi 10 Décembre 2005 16:55, Andreas Pflug a écrit:
> > > > Dave Page wrote:
> > > > >>I still think this patch should be applied.
> > > > >
> > > > > Does anyone see a reason /not/ to do this?
> > >
Le Mercredi 14 Décembre 2005 18:14, Andreas Pflug a écrit :
> Dave Page wrote:
> >>I'm still not convinced we need to do anything. Renaming public is
> >>highly irregular, and finally showing system objects will make it
> >>reappear. The schema restriction allows individual filters
> >>who likes it
Dave Page wrote:
I'm still not convinced we need to do anything. Renaming public is
highly irregular, and finally showing system objects will make it
reappear. The schema restriction allows individual filters
who likes it.
Renaming public is irregular, but if we can allow it without break
> -Original Message-
> From: Andreas Pflug [mailto:[EMAIL PROTECTED]
> Sent: 14 December 2005 10:27
> To: Dave Page
> Cc: Guillaume LELARGE; pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] Schema bug
>
> > I don't have a problem with tha
Dave Page wrote:
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Guillaume LELARGE
Sent: 13 December 2005 23:44
To: pgadmin-hackers@postgresql.org
Subject: Re: [pgadmin-hackers] Schema bug
Le Mardi 13 Décembre 2005 00:48, Guillaume LELARGE a
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of
> Guillaume LELARGE
> Sent: 13 December 2005 23:44
> To: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] Schema bug
>
> Le Mardi 13 Décembre 2005 00:48
Le Mardi 13 Décembre 2005 00:48, Guillaume LELARGE a écrit :
> Le Samedi 10 Décembre 2005 16:55, Andreas Pflug a écrit :
> > Dave Page wrote:
> > >>I still think this patch should be applied.
> > >
> > > Does anyone see a reason /not/ to do this?
> >
> > Hm, Guillaume started a thread on pgsql-hack
Le Mardi 13 Décembre 2005 05:58, Andreas Pflug a écrit :
> Jim C. Nasby wrote:
> > On Tue, Dec 13, 2005 at 12:48:55AM +0100, Guillaume LELARGE wrote:
> >>Well, it seems that pg_* schemas are system schemas and that public and
> >>information_schema schemas are public one. I think we should exclude
Jim C. Nasby wrote:
On Tue, Dec 13, 2005 at 12:48:55AM +0100, Guillaume LELARGE wrote:
Well, it seems that pg_* schemas are system schemas and that public and
information_schema schemas are public one. I think we should exclude system
schemas depending on their names and show public and inform
On Tue, Dec 13, 2005 at 12:48:55AM +0100, Guillaume LELARGE wrote:
> Well, it seems that pg_* schemas are system schemas and that public and
> information_schema schemas are public one. I think we should exclude system
> schemas depending on their names and show public and information_schema,
>
Le Samedi 10 Décembre 2005 16:55, Andreas Pflug a écrit :
> Dave Page wrote:
> >>I still think this patch should be applied.
> >
> > Does anyone see a reason /not/ to do this?
>
> Hm, Guillaume started a thread on pgsql-hackers about renaming system
> schemas in general, maybe we should wait for th
FWIW, here's what we ended up going with in newsysviews:
create or replace function _pg_sv_system_schema(name) returns boolean
as 'select $1 in (name ''pg_catalog'', name ''pg_toast'',
name ''pg_sysviews'', name ''information_schema'')'
language sql immutable strict;
This
Andreas Pflug wrote:
> Florian G. Pflug wrote:
>> I'd prefer system-catalogs being excluded by name - preferably the
>> exclusion-list would be editable, and part of the pgadmin preferences.
>> Seems more transparent to me - and future-proof, in the sense that
>> even if a future postgres version
Florian G. Pflug wrote:
I'd prefer system-catalogs being excluded by name - preferably the
exclusion-list would be editable, and part of the pgadmin preferences.
Seems more transparent to me - and future-proof, in the sense that
even if a future postgres version chooses to rename some catalog
Dave Page wrote:
I had two ways to fix this bug : detect system schemas on
their names, or
detect public schema by its OID. I think it's better to only
keep the public
schema with its OID, it's much less risky to have a wrong
one. That's what
the patch is doing :
AND nspname != 'public'
is
Dave Page wrote:
I still think this patch should be applied.
Does anyone see a reason /not/ to do this?
Hm, Guillaume started a thread on pgsql-hackers about renaming system
schemas in general, maybe we should wait for the result of that discussion.
Regards,
Andreas
---
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of
> Guillaume LELARGE
> Sent: 09 December 2005 22:43
> To: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] Schema bug
>
> Le Vendredi 09 Décembre 20
Le Vendredi 09 Décembre 2005 09:21, Dave Page a écrit :
> > -Original Message-
> > From: Florian G. Pflug [mailto:[EMAIL PROTECTED]
> > Sent: 09 December 2005 01:15
> > To: Dave Page
> > Cc: Andreas Pflug; pgadmin-hackers
> > Subject: Re: [pgadmin-hacke
> -Original Message-
> From: Florian G. Pflug [mailto:[EMAIL PROTECTED]
> Sent: 09 December 2005 01:15
> To: Dave Page
> Cc: Andreas Pflug; pgadmin-hackers
> Subject: Re: [pgadmin-hackers] Schema bug
>
> Hm.. couldn't it check the system-schemas by name i
Dave Page wrote:
Andreas Pflug wrote:
Guillaume LELARGE wrote:
Hi,
I found a weird bug today. If you rename the public
schema, it becomes
unavailable. Here is a patch to fix it. It modifies the
query to use
the oid instead of the schema's name. Works great on
Linux, should'nt
be a problem
Florian G. Pflug wrote:
Andreas Pflug wrote:
Guillaume LELARGE wrote:
Hi,
I found a weird bug today. If you rename the public schema, it
becomes unavailable. Here is a patch to fix it. It modifies the query
to use the oid instead of the schema's name. Works great on Linux,
should'nt be a
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of
> Florian G. Pflug
> Sent: 08 December 2005 15:33
> To: Andreas Pflug; pgadmin-hackers
> Subject: Re: [pgadmin-hackers] Schema bug
>
> Andreas Pflug wrote:
Andreas Pflug wrote:
Guillaume LELARGE wrote:
Hi,
I found a weird bug today. If you rename the public schema, it becomes
unavailable. Here is a patch to fix it. It modifies the query to use
the oid instead of the schema's name. Works great on Linux, should'nt
be a problem on win32.
Actual
2005/12/7, Andreas Pflug <[EMAIL PROTECTED]>:
> Guillaume LELARGE wrote:
> > Hi,
> >
> > I found a weird bug today. If you rename the public schema, it becomes
> > unavailable. Here is a patch to fix it. It modifies the query to use the oid
> > instead of the schema's name. Works great on Linux, sh
Guillaume LELARGE wrote:
Hi,
I found a weird bug today. If you rename the public schema, it becomes
unavailable. Here is a patch to fix it. It modifies the query to use the oid
instead of the schema's name. Works great on Linux, should'nt be a problem on
win32.
Actually, to me renaming the
Hi,
I found a weird bug today. If you rename the public schema, it becomes
unavailable. Here is a patch to fix it. It modifies the query to use the oid
instead of the schema's name. Works great on Linux, should'nt be a problem on
win32.
Regards.
--
Guillaume.
Index: src/schema/pgSchema.cpp
26 matches
Mail list logo
