Re: [pgadmin-hackers] Slony Issue Fix in pgAdmin

2013-09-26 Thread Neel Patel
Thanks Dave. Thanks, Neel Patel On Thu, Sep 26, 2013 at 2:42 PM, Dave Page wrote: > Thanks, applied for 1.18.1+. > > On Thu, Sep 26, 2013 at 9:01 AM, Neel Patel > wrote: > > Hi Dave, > > > > Thanks for the comment. > > > > We changed the logic as below. > > > > if ((data->majorVer == 2 && data

Re: [pgadmin-hackers] Slony Issue Fix in pgAdmin

2013-09-26 Thread Dave Page
Thanks, applied for 1.18.1+. On Thu, Sep 26, 2013 at 9:01 AM, Neel Patel wrote: > Hi Dave, > > Thanks for the comment. > > We changed the logic as below. > > if ((data->majorVer == 2 && data->minorVer >= 2) || (data->majorVer > 2)) > { > // Execute new query > } > else > { > // Execute

Re: [pgadmin-hackers] Slony Issue Fix in pgAdmin

2013-09-26 Thread Neel Patel
Hi Dave, Thanks for the comment. We changed the logic as below. if ((data->majorVer == 2 && data->minorVer >= 2) || (data->majorVer > 2)) { // Execute new query } else { // Execute old query } Please find the updated patch file in attachment and let me know for comments. Thanks, Nee

Re: [pgadmin-hackers] Slony Issue Fix in pgAdmin

2013-09-25 Thread Dave Page
Hi On Tue, Sep 24, 2013 at 12:24 PM, Neel Patel wrote: > Hi Dave, > > Please find the attached patch file for fix of below slony issue in pgAdmin. > > Steps to reproduce:- > > - Install PostgreSQL 9.3 and Slony version 2.2.0. > - Open pgAdmin > - Create new Schema and give cluster name in "Use Sl

[pgadmin-hackers] Slony Issue Fix in pgAdmin

2013-09-24 Thread Neel Patel
Hi Dave, Please find the attached patch file for fix of below slony issue in pgAdmin. *Steps to reproduce:-* - Install PostgreSQL 9.3 and Slony version 2.2.0. - Open pgAdmin - Create new Schema and give cluster name in "Use Slony" option. - Click OK and below error will come. * * ##