Re: [pgadmin-hackers] Support for sslverify

2009-03-17 Thread Dave Page
On Mon, Mar 16, 2009 at 6:31 PM, Magnus Hagander wrote: > This look better? Yep - the only issues I spotted are: - Typo in dlgSelectConnection.h. You can't miss it!! - No change to plugins.ini, which documents the plugins interface. > (I haven't actually tested the backup stuff :-P But it bui

Re: [pgadmin-hackers] Support for sslverify

2009-03-16 Thread Magnus Hagander
Dave Page wrote: > On Mon, Mar 16, 2009 at 2:35 PM, Magnus Hagander wrote: >> Dave Page wrote: >>> On Mon, Mar 16, 2009 at 1:57 PM, Magnus Hagander >>> wrote: >>> - There doesn't seem to be any way to push the verify mode down to the >>> backup/backupall/backupglobals/restore dialogues, or to th

Re: [pgadmin-hackers] Support for sslverify

2009-03-16 Thread Dave Page
On Mon, Mar 16, 2009 at 2:35 PM, Magnus Hagander wrote: > Dave Page wrote: >> On Mon, Mar 16, 2009 at 1:57 PM, Magnus Hagander wrote: >> >>> OK, here's a patch that tries this. Since we're in beta, I definitely >>> want eyes on it before I commit :-) >> >> OK, I've applied eyes - here are my imme

Re: [pgadmin-hackers] Support for sslverify

2009-03-16 Thread Magnus Hagander
Dave Page wrote: > On Mon, Mar 16, 2009 at 1:57 PM, Magnus Hagander wrote: > >> OK, here's a patch that tries this. Since we're in beta, I definitely >> want eyes on it before I commit :-) > > OK, I've applied eyes - here are my immediate thoughts: > > - The verify mode strings look quite long,

Re: [pgadmin-hackers] Support for sslverify

2009-03-16 Thread Dave Page
On Mon, Mar 16, 2009 at 1:57 PM, Magnus Hagander wrote: > OK, here's a patch that tries this. Since we're in beta, I definitely > want eyes on it before I commit :-) OK, I've applied eyes - here are my immediate thoughts: - The verify mode strings look quite long, per my comment on IM. Perhaps

Re: [pgadmin-hackers] Support for sslverify

2009-03-16 Thread Magnus Hagander
Magnus Hagander wrote: > On 15 mar 2009, at 17.00, Dave Page wrote: > >> On Sun, Mar 15, 2009 at 2:51 PM, Magnus Hagander >> wrote: >>> We've seen it here and Dave reported to me on IM that he has received >>> further reports of people getting stuck by the new 8.4 SSL code that >>> verifies serv

Re: [pgadmin-hackers] Support for sslverify

2009-03-16 Thread Magnus Hagander
On 15 mar 2009, at 17.00, Dave Page wrote: On Sun, Mar 15, 2009 at 2:51 PM, Magnus Hagander wrote: We've seen it here and Dave reported to me on IM that he has received further reports of people getting stuck by the new 8.4 SSL code that verifies server certificates by default. I think this

Re: [pgadmin-hackers] Support for sslverify

2009-03-16 Thread Dave Page
On Mon, Mar 16, 2009 at 8:03 AM, Magnus Hagander wrote: >> Note that the server connection diagloue is already pretty much at the >> maximum height, so any changes there will probably need to include >> splitting of the tabset. > > Crap. That something we want to do between betas? It's only UI.

Re: [pgadmin-hackers] Support for sslverify

2009-03-15 Thread Dave Page
On Sun, Mar 15, 2009 at 2:51 PM, Magnus Hagander wrote: > We've seen it here and Dave reported to me on IM that he has received > further reports of people getting stuck by the new 8.4 SSL code that > verifies server certificates by default. > > I think this will happen for example for everybody w

[pgadmin-hackers] Support for sslverify

2009-03-15 Thread Magnus Hagander
We've seen it here and Dave reported to me on IM that he has received further reports of people getting stuck by the new 8.4 SSL code that verifies server certificates by default. I think this will happen for example for everybody who has their pg on a debian server and their client elsewhere, for