Re: [pgadmin-hackers] Ticket 117: Explain Buffers

2010-02-03 Thread Guillaume Lelarge
Le 26/01/2010 10:18, Guillaume Lelarge a écrit : > Le 26/01/2010 04:13, Euler Taveira de Oliveira a écrit : >> Guillaume Lelarge escreveu: >>> New patch attached. >>> >> Nice job. But there are just a few gripes about your patch: (i) it doesn't >> disable the EXPLAIN button when the BUFFERS option

Re: [pgadmin-hackers] Ticket 117: Explain Buffers

2010-01-26 Thread Guillaume Lelarge
Le 26/01/2010 04:13, Euler Taveira de Oliveira a écrit : > Guillaume Lelarge escreveu: >> New patch attached. >> > Nice job. But there are just a few gripes about your patch: (i) it doesn't > disable the EXPLAIN button when the BUFFERS option is enabled, (ii) it doesn't > disable the EXPLAIN ANALYZ

Re: [pgadmin-hackers] Ticket 117: Explain Buffers

2010-01-25 Thread Euler Taveira de Oliveira
Guillaume Lelarge escreveu: > New patch attached. > Nice job. But there are just a few gripes about your patch: (i) it doesn't disable the EXPLAIN button when the BUFFERS option is enabled, (ii) it doesn't disable the EXPLAIN ANALYZE menu when the query is running, and (iii) there is a bug when th

Re: [pgadmin-hackers] Ticket 117: Explain Buffers

2010-01-25 Thread Guillaume Lelarge
Le 23/01/2010 19:20, Euler Taveira de Oliveira a écrit : > Magnus Hagander escreveu: >> While you're whacking around the explain code, one thing that has >> always nagged me, is that ANALYZE is an option for EXPLAIN. IMO we >> should have "Explain" and "Explain Analyze" as separate commands, >> bec

Re: [pgadmin-hackers] Ticket 117: Explain Buffers

2010-01-25 Thread Guillaume Lelarge
Le 23/01/2010 16:40, Magnus Hagander a écrit : > 2010/1/23 Guillaume Lelarge : >> Le 23/01/2010 15:14, Magnus Hagander a écrit : >>> 2010/1/23 Guillaume Lelarge : Hi, This patch handles two new parameters for EXPLAIN: COSTS and BUFFERS. I'm not sure that we need to add support f

Re: [pgadmin-hackers] Ticket 117: Explain Buffers

2010-01-23 Thread Euler Taveira de Oliveira
Magnus Hagander escreveu: > While you're whacking around the explain code, one thing that has > always nagged me, is that ANALYZE is an option for EXPLAIN. IMO we > should have "Explain" and "Explain Analyze" as separate commands, > because they actually do different things. And then options for th

Re: [pgadmin-hackers] Ticket 117: Explain Buffers

2010-01-23 Thread Magnus Hagander
2010/1/23 Guillaume Lelarge : > Le 23/01/2010 15:14, Magnus Hagander a écrit : >> 2010/1/23 Guillaume Lelarge : >>> Hi, >>> >>> This patch handles two new parameters for EXPLAIN: COSTS and BUFFERS. >>> I'm not sure that we need to add support for format. I would like to >>> have your opinion on thi

Re: [pgadmin-hackers] Ticket 117: Explain Buffers

2010-01-23 Thread Guillaume Lelarge
Le 23/01/2010 15:14, Magnus Hagander a écrit : > 2010/1/23 Guillaume Lelarge : >> Hi, >> >> This patch handles two new parameters for EXPLAIN: COSTS and BUFFERS. >> I'm not sure that we need to add support for format. I would like to >> have your opinion on this? > > Not really. The whole idea of

Re: [pgadmin-hackers] Ticket 117: Explain Buffers

2010-01-23 Thread Magnus Hagander
2010/1/23 Guillaume Lelarge : > Hi, > > This patch handles two new parameters for EXPLAIN: COSTS and BUFFERS. > I'm not sure that we need to add support for format. I would like to > have your opinion on this? Not really. The whole idea of using EXPLAIN on the menu is to get the graphical output,

[pgadmin-hackers] Ticket 117: Explain Buffers

2010-01-22 Thread Guillaume Lelarge
Hi, This patch handles two new parameters for EXPLAIN: COSTS and BUFFERS. I'm not sure that we need to add support for format. I would like to have your opinion on this? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com diff --git a/pgadmin/ctl/explainShape.cpp b/pgadmin/ctl/explain