Re: [pgadmin-hackers] Weird code in pgDomain.cpp

2012-05-01 Thread Guillaume Lelarge
On Sat, 2012-04-21 at 15:39 +0200, Guillaume Lelarge wrote: > On Wed, 2012-04-11 at 08:11 +, Dave Page wrote: > > On Tue, Apr 10, 2012 at 9:17 PM, Guillaume Lelarge > > wrote: > > > On Mon, 2012-04-09 at 19:58 +0530, Ashesh Vashi wrote: > > >> On Sun, Apr 8, 2012 at 3:24 PM, Dave Page wrote:

Re: [pgadmin-hackers] Weird code in pgDomain.cpp

2012-04-11 Thread Dave Page
On Tue, Apr 10, 2012 at 9:17 PM, Guillaume Lelarge wrote: > On Mon, 2012-04-09 at 19:58 +0530, Ashesh Vashi wrote: >> On Sun, Apr 8, 2012 at 3:24 PM, Dave Page wrote: >> >> > On Sun, Apr 8, 2012 at 4:44 AM, Guillaume Lelarge >> > wrote: >> > > Hi, >> > > >> > > I was trying to fix a bug on dlgDo

Re: [pgadmin-hackers] Weird code in pgDomain.cpp

2012-04-09 Thread Ashesh Vashi
On Sun, Apr 8, 2012 at 3:24 PM, Dave Page wrote: > On Sun, Apr 8, 2012 at 4:44 AM, Guillaume Lelarge > wrote: > > Hi, > > > > I was trying to fix a bug on dlgDomain, and I found this code (in > > pgadmin/schema/pgDomain.cpp): > > > > wxString conname = set->GetVal(wxT("conname")); > > if (!conna

Re: [pgadmin-hackers] Weird code in pgDomain.cpp

2012-04-08 Thread Dave Page
On Sun, Apr 8, 2012 at 4:44 AM, Guillaume Lelarge wrote: > Hi, > > I was trying to fix a bug on dlgDomain, and I found this code (in > pgadmin/schema/pgDomain.cpp): > > wxString conname = set->GetVal(wxT("conname")); > if (!conname.StartsWith(wxT("$"))) >    check += wxT("CONSTRAINT ") + qtIdent(c

[pgadmin-hackers] Weird code in pgDomain.cpp

2012-04-08 Thread Guillaume Lelarge
Hi, I was trying to fix a bug on dlgDomain, and I found this code (in pgadmin/schema/pgDomain.cpp): wxString conname = set->GetVal(wxT("conname")); if (!conname.StartsWith(wxT("$"))) check += wxT("CONSTRAINT ") + qtIdent(conname) + wxT(" "); I'm wondering why we look for a dollar sign in the