Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hmm, I can't reproduce it now either. Oh well, thanks for checking. Patch applied! On Thu, Sep 5, 2013 at 6:27 PM, Dinesh Kumar wrote: > Hi Dave, > > Sorry for the big delay on this issue. > > I have tried to re-produce the above case in mac but unfortunately i am > not able to re-produce it. I

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi Dave, Sorry for the big delay on this issue. I have tried to re-produce the above case in mac but unfortunately i am not able to re-produce it. I have followed the below steps to reproduce the case. 1) Got the new pgAdmin's master branch. 2) Applied the given patch. 3) Created a new event t

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi Dave, Thanks for your inputs. On Wed, Jul 31, 2013 at 6:00 PM, Dave Page wrote: > Hi > > On Tue, Jul 30, 2013 at 5:16 PM, Dinesh Kumar > wrote: > > Hi Dave, > > > > On Mon, Jul 29, 2013 at 9:22 PM, Dave Page wrote: > >> > >> Hi > >> > >> > >> On Fri, Jul 26, 2013 at 5:58 PM, Dinesh Kumar >

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi On Tue, Jul 30, 2013 at 5:16 PM, Dinesh Kumar wrote: > Hi Dave, > > On Mon, Jul 29, 2013 at 9:22 PM, Dave Page wrote: >> >> Hi >> >> >> On Fri, Jul 26, 2013 at 5:58 PM, Dinesh Kumar >> wrote: >>> >>> Hi Dave, >>> >>> Thanks for committing the patch. >>> >>> I have found one memory leak issue

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi Dave, On Mon, Jul 29, 2013 at 9:22 PM, Dave Page wrote: > Hi > > > On Fri, Jul 26, 2013 at 5:58 PM, Dinesh Kumar < > dinesh.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Thanks for committing the patch. >> >> I have found one memory leak issue in the previous implementation and >> would

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi On Fri, Jul 26, 2013 at 5:58 PM, Dinesh Kumar wrote: > Hi Dave, > > Thanks for committing the patch. > > I have found one memory leak issue in the previous implementation and > would like to submit this new patch on top of the > Pg_Event_Trigger_V5.patch. Please find the below attached patch

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi Dave, Thanks for committing the patch. I have found one memory leak issue in the previous implementation and would like to submit this new patch on top of the Pg_Event_Trigger_V5.patch. Please find the below attached patch and valgrind output and let me know your inputs and suggestions. Thank

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Thanks Akshay - patch applied, with a minor change to replace "EventTrigger" with "Event Trigger" in the treeview. Nice work Dinesh. On Wed, Jul 24, 2013 at 7:48 AM, Akshay Joshi wrote: > Hi Dinesh > > Code looks good to me. Dave I have finished the review for event trigger > functionality, you

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi Dinesh Code looks good to me. Dave I have finished the review for event trigger functionality, you can have a look. On Tue, Jul 23, 2013 at 10:07 PM, Dinesh Kumar < dinesh.ku...@enterprisedb.com> wrote: > Hi Akshay, > > Thanks for your review and for the suggestions. > > On Tue, Jul 23, 2013

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi Dinesh I have reviewed your event trigger patch. Following is my review comments: - There is some problem in "refresh" logic. When I clicked on newly created event trigger node, it gets collapsed automatically and the parent node gets selected. - According to the logic you have dis

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Akshay, please let me know when your review is complete and then I'll take a look. On Mon, Jul 22, 2013 at 2:09 PM, Dinesh Kumar wrote: > Hi Akshay, > > Thank you so much for correcting me on this. It's my bad to forgot the > naming convention in the code. Now, ::OnOK() is get populating the re

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi Dinesh I have just started reviewing your code and found on issue where any changes made on Event Trigger dialog won't be saved. After looking at the code, you haven't override the ::OnOK() function in dlgEventTrigger.cpp. Can you please fix this and resend the new patch. On Wed, Jul 10, 2013

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

> Yes, we can change this enable check box as a radio button. But, >> "REPLICA/ALWAYS" are two enable's properties. Hence, We have implemented >> this in the proposed way. Kindly share your opinion on this. >> > > So: "Enabled Replica ( ) Enabled Always ( ) Disabled ( )" ? > Yes Dave. Dinesh

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi On Wed, Jul 10, 2013 at 10:56 AM, Dinesh Kumar < dinesh.ku...@enterprisedb.com> wrote: > H > i Dave, > > > > OK, it builds fine on Mac for me now. Some initial feedback: >>> >>> - Instead of "DDL_COMMAND_START", we should use "DDL COMMAND START". The >>> same applies to similar cases. >>> >>

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

On Mon, Jul 8, 2013 at 6:17 PM, Dave Page wrote: > Hi > > On Thu, Jul 4, 2013 at 3:10 PM, Dinesh Kumar < > dinesh.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Thanks for your time. >> >> Please find the attached new patch for the same. As per my testing on >> windows/linux, it's working fin

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

H i Dave. Thanks for your inputs. I have built this patch on Linux and found one minor issue. I am not sure this is a known behavior or problem in building. Hence, i would like to discuss this with our team once and will update this thread with the new patch. Thanks in advance. Dinesh -- *Di

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi On Fri, Jun 28, 2013 at 4:55 PM, Dinesh Kumar wrote: > Hi Dave, > > Please find the attached patch file for the pgAdmin's event trigger > compatibility. This patch has been build on the pgAdmin's master branch. > > I would like to request you to share inputs and suggestions on this patch. >