Thanks Neel - patch applied!
Many thanks Sergey!
On Fri, Feb 19, 2016 at 5:17 AM, Neel Patel
wrote:
> Hi Dave,
>
> I re-tested and reviewed the attached patch and it is working perfectly.
> Thank you Sergey for the patch.
>
> Thanks,
> Neel Patel
>
> On Thu, Feb 18, 2016 at 9:08 PM, Dave Page
Hi Dave,
I re-tested and reviewed the attached patch and it is working perfectly.
Thank you Sergey for the patch.
Thanks,
Neel Patel
On Thu, Feb 18, 2016 at 9:08 PM, Dave Page wrote:
> Hi Sergey
>
> That works perfectly for me! I've made a minor change in the attached
> patch - the New button
Hi Sergey
That works perfectly for me! I've made a minor change in the attached patch
- the New button on the button bar now creates a new tab rather than a new
window. That seems more useful to me (you still have options for both on
the File menu). Seem OK to you?
Neel - can you please re-test t
Dave,
I still could not recreate the crash in my environment. But I have modified
the way tabs are closed. Tabs are no longer being removed/deleted from the
code, that task is now left for AuiNotebook when the window is closed.
Again, it works for me without crashes. I am testing with up to 15, 20
On Tue, Feb 16, 2016 at 12:42 AM, Sergey Busel wrote:
> After trying it couple times, I was able to reproduce the crash. I think
> it was due to the way tabs were being closed. A dirty tab would prompt the
> user to save the changes and close the tab right away before moving on to
> the next tab.
After trying it couple times, I was able to reproduce the crash. I think it
was due to the way tabs were being closed. A dirty tab would prompt the
user to save the changes and close the tab right away before moving on to
the next tab. I think it crashed because the user was closing the window
via
Hi ,
I just applied the patch in Linux environment and found the crash. Below
are the steps to reproduce.
We may need to perform below steps multiple time to reproduce the crash.
- Open the "Query Window".
- Go to "File" and click on "New SQL tab". Open the 3-4 SQL tabs and
execute any q
On Thu, Feb 11, 2016 at 2:22 PM, Sergey Busel wrote:
> Added the query name to history entries. Please note that history entries
> are not modified if user saves [Query 1] to file [foo.sql]. I don't think
> that would be practical.
>
Thanks. So I was just about to commit this, when it crashed on
Added the query name to history entries. Please note that history entries
are not modified if user saves [Query 1] to file [foo.sql]. I don't think
that would be practical.
On Wed, Feb 10, 2016 at 8:28 AM, Dave Page wrote:
> Hi
>
> On Wed, Feb 10, 2016 at 12:14 AM, Sergey Busel wrote:
>
>> Dav
Hi
On Wed, Feb 10, 2016 at 12:14 AM, Sergey Busel wrote:
> Dave,
>
> Here is a patch that does display the query tab name in the title bar of
> the output pane. It seems to work with loading and saving the perspective,
> too. The trick is to restore the original text on the output pane before
>
Dave,
Here is a patch that does display the query tab name in the title bar of
the output pane. It seems to work with loading and saving the perspective,
too. The trick is to restore the original text on the output pane before
loading and saving the perspective, and put the query name back in ther
On Wed, Feb 3, 2016 at 3:07 AM, Sergey Busel wrote:
> - Removed unused/commented code.
> - Tab names now reflect the file name, if such is associated with a tab.
> - Removed the "Close Tab" menu item. Added X button to the active tab.
> - To tell the user which tab results are related to and to av
It's a good start Sergey!
Sharing the same connection among the tabs is what I had in mind as well.
In the long run I would like to allow connecting to several db's from the
same pgadmin window. Then have multiple tabs for each connection. Then I
believe it would be easier to allow parallell queri
No, that's not the way it works in this patch. All SQL tabs are sharing the
same output pane. At this point, the tabs only help organize code into
files. For me, it's easier to switch tabs and hit F5 then keep highlighting
the text to execute in the same query box.
I know that this is not a true a
- Removed unused/commented code.
- Tab names now reflect the file name, if such is associated with a tab.
- Removed the "Close Tab" menu item. Added X button to the active tab.
- To tell the user which tab results are related to and to avoid messing
with perspective, the name of the related tab is
2016-02-02 12:08 GMT+01:00 Dave Page :
> On Tue, Feb 2, 2016 at 3:17 AM, Sergey Busel wrote:
> > Patch file for multiple SQL tabs is attached.
>
> Thanks - I see how this could be useful. I think it needs a little
> work before it could be included:
>
> - Unused code should be removed, not commen
On Tue, Feb 2, 2016 at 3:17 AM, Sergey Busel wrote:
> Patch file for multiple SQL tabs is attached.
Thanks - I see how this could be useful. I think it needs a little
work before it could be included:
- Unused code should be removed, not commented out.
- I think the tab names should reflect the
Patch file for multiple SQL tabs is attached.
Thank you
On Mon, Feb 1, 2016 at 3:01 AM, Dave Page wrote:
> On Sun, Jan 31, 2016 at 7:03 PM, Sergey Busel wrote:
> > Hello,
> > It's my first time here and I hope I am sending this to the right mailing
> > list.
> >
> > I am starting to use pgAdmi
On Sun, Jan 31, 2016 at 7:03 PM, Sergey Busel wrote:
> Hello,
> It's my first time here and I hope I am sending this to the right mailing
> list.
>
> I am starting to use pgAdmin 3 more and more nowadays and thought that
> having a multi tabbed interface would be beneficial especially that most (i
Nice! This is something I wanted to work on myself but have not had the
time to yet.
-- john
2016-01-31 20:03 GMT+01:00 Sergey Busel :
> Hello,
> It's my first time here and I hope I am sending this to the right mailing
> list.
>
> I am starting to use pgAdmin 3 more and more nowadays and though
Hello,
It's my first time here and I hope I am sending this to the right mailing
list.
I am starting to use pgAdmin 3 more and more nowadays and thought that
having a multi tabbed interface would be beneficial especially that most
(if not all) similar tools go that route. Somewhere in the mail arc
21 matches
Mail list logo
