Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-10 Thread Nikhil S
> Thanks - applied. > > Thanks Dave. Regards, Nikhils > On Mon, Feb 7, 2011 at 1:01 PM, Nikhil S wrote: > > Hi, > > > > If one clicks on Postgres (non EDB) database and tries to expand the > schema > > tab, then the current git head spits out an error. The offending query > > contains the follo

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-10 Thread Dave Page
Thanks - applied. On Mon, Feb 7, 2011 at 1:01 PM, Nikhil S wrote: > Hi, > > If one clicks on Postgres (non EDB) database and tries to expand the schema > tab, then the current git head spits out an error. The offending query > contains the following comparison > > protype = 1; > > protype is of t

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-08 Thread Magnus Hagander
On Tue, Feb 8, 2011 at 22:19, Dave Page wrote: > On Tue, Feb 8, 2011 at 10:13 PM, Magnus Hagander wrote: >> Forgive me if I'm being dense... but doesn't this error indicate that >> it *isn't* just that? > > No. Nikhil said (and the patch matches) that EDBAS, in PG mode or > normal/Oracle mode, ha

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-08 Thread Dave Page
On Tue, Feb 8, 2011 at 10:13 PM, Magnus Hagander wrote: > Forgive me if I'm being dense... but doesn't this error indicate that > it *isn't* just that? No. Nikhil said (and the patch matches) that EDBAS, in PG mode or normal/Oracle mode, has the problem. On PostgreSQL, the problem doesn't exist (

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-08 Thread Magnus Hagander
On Tue, Feb 8, 2011 at 22:09, Dave Page wrote: > On Tue, Feb 8, 2011 at 7:14 PM, Magnus Hagander wrote: >> On Tue, Feb 8, 2011 at 11:10, Dave Page wrote: >>> On 2/8/11, Magnus Hagander wrote: On Tue, Feb 8, 2011 at 11:01, Dave Page wrote: > On 2/8/11, Magnus Hagander wrote: >> On

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-08 Thread Dave Page
On Tue, Feb 8, 2011 at 7:14 PM, Magnus Hagander wrote: > On Tue, Feb 8, 2011 at 11:10, Dave Page wrote: >> On 2/8/11, Magnus Hagander wrote: >>> On Tue, Feb 8, 2011 at 11:01, Dave Page wrote: On 2/8/11, Magnus Hagander wrote: > On Tue, Feb 8, 2011 at 08:22, Nikhil S wrote: >> >>>

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-08 Thread Magnus Hagander
On Tue, Feb 8, 2011 at 11:10, Dave Page wrote: > On 2/8/11, Magnus Hagander wrote: >> On Tue, Feb 8, 2011 at 11:01, Dave Page wrote: >>> On 2/8/11, Magnus Hagander wrote: On Tue, Feb 8, 2011 at 08:22, Nikhil S wrote: > > >> >> Well, the SQL does get fired against a PG data

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-08 Thread Dave Page
On 2/8/11, Magnus Hagander wrote: > On Tue, Feb 8, 2011 at 11:01, Dave Page wrote: >> On 2/8/11, Magnus Hagander wrote: >>> On Tue, Feb 8, 2011 at 08:22, Nikhil S wrote: > > Well, the SQL does get fired against a PG database in the EDBAS mode > for > me. I too was puzz

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-08 Thread Magnus Hagander
On Tue, Feb 8, 2011 at 11:01, Dave Page wrote: > On 2/8/11, Magnus Hagander wrote: >> On Tue, Feb 8, 2011 at 08:22, Nikhil S wrote: >>> >>> Well, the SQL does get fired against a PG database in the EDBAS mode for me. I too was puzzled about the minimum version check being EDBAS >>

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-08 Thread Dave Page
On 2/8/11, Magnus Hagander wrote: > On Tue, Feb 8, 2011 at 08:22, Nikhil S wrote: >> >> >>> >>> Well, the SQL does get fired against a PG database in the EDBAS mode for >>> me. I too was puzzled about the minimum version check being EDBAS >>> specific. >>> >> >> Just checked. The version checker

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-08 Thread Magnus Hagander
On Tue, Feb 8, 2011 at 08:22, Nikhil S wrote: > > >> >> Well, the SQL does get fired against a PG database in the EDBAS mode for >> me. I too was puzzled about the minimum version check being EDBAS specific. >> > > Just checked. The version checker function checks for the version number and > also

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-07 Thread Nikhil S
> Well, the SQL does get fired against a PG database in the EDBAS mode for > me. I too was puzzled about the minimum version check being EDBAS specific. > > Just checked. The version checker function checks for the version number and also for a bool which is set to true in EDBAS mode. So yeah, this

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-07 Thread Nikhil S
> I"m not sure I understand. You first said that the bug is on regular > PostgreSQL (and I can't reproduce it on 9.0 regular PostgreSQL). When > you explain the bug and if I read correctly your patch, it fixes EDB > database only. > > So is it a fix for EDB databases or PostgreSQL databases? > > We

Re: [pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-07 Thread Guillaume Lelarge
Le 07/02/2011 13:01, Nikhil S a écrit : > Hi, > > If one clicks on Postgres (non EDB) database and tries to expand the schema > tab, then the current git head spits out an error. The offending query > contains the following comparison > > protype = 1; > > protype is of type char, so it expects t

[pgadmin-hackers] pgAdmin III: error while browsing schema of PG database

2011-02-07 Thread Nikhil S
Hi, If one clicks on Postgres (non EDB) database and tries to expand the schema tab, then the current git head spits out an error. The offending query contains the following comparison protype = 1; protype is of type char, so it expects the RHS to be a char. However this works ok against an EDB