Thanks - committed.
On Thu, Mar 24, 2016 at 3:25 PM, Khushboo Vashi
wrote:
> Hi,
>
> Please find the attached updated patch for the Domains Module.
>
> Thanks,
> Khushboo
>
> On Thu, Mar 24, 2016 at 5:29 PM, Dave Page wrote:
>>
>> Hi
>>
>> You're going to hate me for this
>>
>> - I added an
Hi
You're going to hate me for this
- I added an un-validated constraint to a domain, then opened the
domain properties and clicked the Validate? option for it. The SQL is
generated, but the Save button is not enabled.
- If I right-click a domain, I get Create options for "Domain" (with a
co
Hi
Almost there :-s
- The hint for default should be a placeholder in the textbox itself
(like combos have "Select from the list"
- I should be able to check the "Validate?" option on one or more
constraints from within the Domain dialogue
- Please ensure the capitalisation of all property labe
On Wed, Mar 23, 2016 at 3:09 PM, Dave Page wrote:
> Did you forget to attach the latest patch?
>
She did it in the previous patch only.
She forgot to mention about the help string, which she did in later mail.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
Did you forget to attach the latest patch?
On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi
wrote:
> Updated one comment.
>
> On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi
> wrote:
>>
>> Hi,
>>
>> Please find attached updated patch for the Domains module.
>>
>> On Wed, Mar 16, 2016 at 9:40 PM,
Updated one comment.
On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find attached updated patch for the Domains module.
>
> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page wrote:
>
>> Hi
>>
>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
On Mon, Mar 21, 2016 at 7:41 AM, Khushboo Vashi
wrote:
> Hi Dave,
>
>
> On Fri, Mar 18, 2016 at 8:31 PM, Dave Page wrote:
>>
>> On Thu, Mar 17, 2016 at 5:39 PM, Khushboo Vashi
>> wrote:
>> > Hi Dave,
>> >
>> > I have a query regarding your below feedback :
>> >
>> > - Default values should be au
Hi Dave,
On Fri, Mar 18, 2016 at 8:31 PM, Dave Page wrote:
> On Thu, Mar 17, 2016 at 5:39 PM, Khushboo Vashi
> wrote:
> > Hi Dave,
> >
> > I have a query regarding your below feedback :
> >
> > - Default values should be auto-quoted when necessary (ie. strings, on a
> > text-based domain).
> >
Hi
On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
wrote:
> Hi,
>
> Please find the updated Domain Module Patch.
>
> To test this patch, please apply Backgrid Textarea Cell Patch before this.
Thanks. I believe with the following fixes, we'll be done :-)
- Default values should be auto-quoted wh
Hi Dave,
I have a query regarding your below feedback :
* - Default values should be auto-quoted when necessary (ie. strings, on a
text-based domain).*
To resolve this, I have checked the typcategory field from pg_type for the
base_type selected for the Domain.
If the typcategory is String type
Hi,
Please find the updated Domain Module Patch.
To test this patch, please apply Backgrid Textarea Cell Patch before this.
Thanks,
Khushboo
On Wed, Mar 16, 2016 at 3:02 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> On Wed, Mar 16, 2016 at 2:55 PM, Dave Page wrote:
>
On Thu, Mar 17, 2016 at 5:39 PM, Khushboo Vashi
wrote:
> Hi Dave,
>
> I have a query regarding your below feedback :
>
> - Default values should be auto-quoted when necessary (ie. strings, on a
> text-based domain).
>
> To resolve this, I have checked the typcategory field from pg_type for the
> b
Hi,
On Wed, Mar 16, 2016 at 2:55 PM, Dave Page wrote:
> Hi
>
> On Wed, Mar 16, 2016 at 9:18 AM, Khushboo Vashi
> wrote:
> >
> >>> - Owner and schema should be allowed to be left blank (and then default
> >>> to the current user/schema)
> >
> > Done
>
> Oh, sorry - that design changed a while ba
Hi
On Wed, Mar 16, 2016 at 9:18 AM, Khushboo Vashi
wrote:
>
>>> - Owner and schema should be allowed to be left blank (and then default
>>> to the current user/schema)
>
> Done
Oh, sorry - that design changed a while back, and I've updated all the
existing nodes already. I thought I'd mentioned
Per discussion with Khushboo, the patch at
http://www.postgresql.org/message-id/attachment/41939/schemas_macros_10_Feb_2.patch
is a pre-req for this. Updated comments below...
On Thu, Feb 25, 2016 at 12:13 PM, Dave Page wrote:
> Hi
>
> On Wed, Feb 24, 2016 at 9:24 AM, Khushboo Vashi <
> khushboo
Hi
On Wed, Feb 24, 2016 at 9:24 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> I have updated the Domain module as below:
>
> - Used 'NodeByListControl' to get schemas, in domains.js file as suggested
> by Ashesh to avoid code redundancy.
>
> - Applied *'Security Label Mac
Hi Khushboo,
Please find below review comments.
- Reverse engineering SQL generation is not implemented for domain node.
- "Length" and "Precision" fields should be enabled/disabled based on the
selection of "Base Type" value.
- Query is not getting generated properly. Some of the parameters a
Hi Neel,
Thanks for reviewing my patch.
I have modified the code as per your suggestions and also fixed some of the
issues got while doing unit testing.
Please find attached patch for the same.
Thanks,
Khushboo
On Wed, Jan 20, 2016 at 10:56 PM, Neel Patel
wrote:
> Hi Khushboo,
>
> Please f
Hi Khushboo,
Please find below review comments.
- While creating new Domain and clicking on SQL tab, python side we are
getting error saying "*TypeError: 'bool' object is not callable".*
We are not able to create any domain. Fix this issue so that we can test
other functionality.
- Implement th
Hi Neel,
Please find updated patch.
Thanks,
Khushboo
On Wed, Jan 20, 2016 at 12:50 PM, Neel Patel
wrote:
> Hi Khushboo,
>
> While applying the patch file, we are getting below warnings.
>
> #
> domains (1).patch:1340: trailing whitespace.
> oid
Hi Khushboo,
While applying the patch file, we are getting below warnings.
#
domains (1).patch:1340: trailing whitespace.
oid: undefined,
domains (1).patch:1483: trailing whitespace.
(nspname = 'pg_catalog' AND EXISTS
domains (1).patch:1487: t
Resending patch with binary option.
On Wed, Jan 20, 2016 at 10:18 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch for the Domain Module.
>
> The patch will be modified after Types module implementation as we need to
> populate Base Type and some
Hi,
Please find attached patch for the Domain Module.
The patch will be modified after Types module implementation as we need to
populate Base Type and some Type related validations from the Types module.
Please review it and let me know the feedback.
Thanks,
Khushboo
diff --git a/web/pgadmin/
23 matches
Mail list logo
