Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-19 Thread Dave Page
On Sat, Aug 16, 2008 at 4:07 PM, Mickael Deloison <[EMAIL PROTECTED]> wrote: > Hi, > > I uploaded my last patch. This patch includes: > * pgScript fully integrated with pgAdmin code > (pgadmin/include/pgscript and pgadmin/pgscript) > * pgScript CLI, unit test suite, integration test suite and > d

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-16 Thread Mickael Deloison
2008/8/16 Erikjan Rijkers <[EMAIL PROTECTED]>: > No. > > In the regular query tool one can draw a select block (with mouse or > keyboard). Subsequently pressing F5 *only* executes the selected text. This > is a very handy behaviour that (I think) could be mimicked by pgscript without > problem. >

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-16 Thread Erikjan Rijkers
On Sat, August 16, 2008 15:55, Mickael Deloison wrote: > 2008/8/14 Erikjan Rijkers <[EMAIL PROTECTED]>: >> 1) It would be nice if pgScript would only execute a select-block, like the >> normal pgAdmin querytool does. > > Do you mean: redirecting a pgScript script to the regular query tool > if bot

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-16 Thread Mickael Deloison
2008/8/14 Dave Page <[EMAIL PROTECTED]>: > On Thu, Aug 14, 2008 at 4:34 PM, Magnus Hagander <[EMAIL PROTECTED]> wrote: >>> Does that sound about right? >> >> We dumped the static library part, because that library would depend on >> pgadmin itself, and we'd either get duplicate symbols or a circula

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-16 Thread Mickael Deloison
Hi Erikjan, Here a few answers to your questions. 2008/8/14 Erikjan Rijkers <[EMAIL PROTECTED]>: > 1) It would be nice if pgScript would only execute a select-block, like the > normal pgAdmin querytool does. Do you mean: redirecting a pgScript script to the regular query tool if both the pgScri

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-14 Thread Dave Page
On Thu, Aug 14, 2008 at 4:34 PM, Magnus Hagander <[EMAIL PROTECTED]> wrote: >> Does that sound about right? > > We dumped the static library part, because that library would depend on > pgadmin itself, and we'd either get duplicate symbols or a circular > reference. > (pgScript requires a few class

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-14 Thread Mickael Deloison
2008/8/14 Dave Page <[EMAIL PROTECTED]>: > On Thu, Aug 14, 2008 at 4:22 PM, Mickael Deloison <[EMAIL PROTECTED]> wrote: >> >> So I talked with Magnus. The simplest solution is fully integrated >> because I designed pgScript to be fully integrated. A library is the >> most difficult one. >> Therefor

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-14 Thread Magnus Hagander
Dave Page wrote: > On Thu, Aug 14, 2008 at 4:22 PM, Mickael Deloison <[EMAIL PROTECTED]> wrote: >> So I talked with Magnus. The simplest solution is fully integrated >> because I designed pgScript to be fully integrated. A library is the >> most difficult one. >> Therefore we chose fully integrated

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-14 Thread Dave Page
On Thu, Aug 14, 2008 at 4:22 PM, Mickael Deloison <[EMAIL PROTECTED]> wrote: > > So I talked with Magnus. The simplest solution is fully integrated > because I designed pgScript to be fully integrated. A library is the > most difficult one. > Therefore we chose fully integrated with a possibility t

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-14 Thread Mickael Deloison
2008/8/14 Dave Page <[EMAIL PROTECTED]>: > On Thu, Aug 14, 2008 at 2:26 PM, Mickael Deloison <[EMAIL PROTECTED]> wrote: > >> I'm not sure to understand all the possibilities. >> By DLL, what do you mean? Do you say that pgScript code would be on >> pgFoundry (like it is right now) or would be on pg

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-14 Thread Dave Page
On Thu, Aug 14, 2008 at 2:26 PM, Mickael Deloison <[EMAIL PROTECTED]> wrote: > I'm not sure to understand all the possibilities. > By DLL, what do you mean? Do you say that pgScript code would be on > pgFoundry (like it is right now) or would be on pgAdmin SVN. If on > pgAdmin SVN, would it be com

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-14 Thread Mickael Deloison
2008/8/14 Dave Page <[EMAIL PROTECTED]>: > Well a lot of the argument around separating it was based on the idea > that you would continue to work on it without being bound by the > pgAdmin release cycle. I think that makes you one of major the > decision makers - so what do you think we should do?

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-14 Thread Dave Page
On Thu, Aug 14, 2008 at 1:00 AM, Mickael Deloison <[EMAIL PROTECTED]> wrote: > Hi, > > There is a new patch for pgAdmin that includes pgScript. Maybe the > crashes Dave and Guillaume got were caused by a simultaneous access to > the output stream, which is now solved. > > This patch is based on r74

Re: [pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-13 Thread Erikjan Rijkers
On Thu, August 14, 2008 02:00, Mickael Deloison wrote: > There is a new patch for pgAdmin that includes pgScript. Maybe the > Everything is here: http://pgscript.projects.postgresql.org/pgadmin/ Hi Mickael, I played a bit with pgScript; I like it. Here are a few observations: 1) It would be

[pgadmin-hackers] pgScript patch based on pgScript-1.0-beta-3

2008-08-13 Thread Mickael Deloison
Hi, There is a new patch for pgAdmin that includes pgScript. Maybe the crashes Dave and Guillaume got were caused by a simultaneous access to the output stream, which is now solved. This patch is based on r7403: * r7403-dif-pgs1.0b3.zip for the source code patch * r7403-bin-pgs1.0b3.zip for t