Re: [pgadmin-hackers] Changed default ordering in tables

2011-08-08 Thread Erwin Brandstetter
Thanks to both of you! Looking forward to the next release! -- Erwin Brandstetter On 06.08.2011 14:49, Guillaume Lelarge wrote: On Fri, 2011-07-29 at 10:33 +0100, Dave Page wrote: On Fri, Jul 29, 2011 at 9:14 AM, Erwin Brandstetter wrote: So, that's two distinct issue: - "Last 100 rows"

Re: [pgadmin-hackers] Changed default ordering in tables

2011-08-06 Thread Dave Page
Thanks. I thought i checked for the var init. Guess i missed a code path. On Saturday, August 6, 2011, Guillaume Lelarge wrote: > On Fri, 2011-07-29 at 10:33 +0100, Dave Page wrote: >> On Fri, Jul 29, 2011 at 9:14 AM, Erwin Brandstetter >> wrote: >> > So, that's two distinct issue: >> > - "Last

Re: [pgadmin-hackers] Changed default ordering in tables

2011-08-06 Thread Guillaume Lelarge
On Fri, 2011-07-29 at 10:33 +0100, Dave Page wrote: > On Fri, Jul 29, 2011 at 9:14 AM, Erwin Brandstetter > wrote: > > So, that's two distinct issue: > > - "Last 100 rows" broken for multi-column pkeys. > > - Default sort order DESC for edit grid, where it should be ASC. > > That one I can reprod

Re: [pgadmin-hackers] Changed default ordering in tables

2011-07-29 Thread Dave Page
On Fri, Jul 29, 2011 at 9:14 AM, Erwin Brandstetter wrote: > So, that's two distinct issue: > - "Last 100 rows" broken for multi-column pkeys. > - Default sort order DESC for edit grid, where it should be ASC. That one I can reproduce, and fix. Patch attached. Ashesh, can you review and test ple

Re: [pgadmin-hackers] Changed default ordering in tables

2011-07-29 Thread Erwin Brandstetter
On 29.07.2011 07:10, Erwin Brandstetter wrote: On 29.07.2011 04:57, Erwin Brandstetter wrote: On 26.07.2011 23:20, Dave Page wrote: On Tue, Jul 26, 2011 at 9:53 PM, Erwin Brandstetter wrote: That may be the key here. When I open the simple test table from above in v1.14 I get descending orde

Re: [pgadmin-hackers] Changed default ordering in tables

2011-07-28 Thread Erwin Brandstetter
On 29.07.2011 04:57, Erwin Brandstetter wrote: On 26.07.2011 23:20, Dave Page wrote: On Tue, Jul 26, 2011 at 9:53 PM, Erwin Brandstetter wrote: That may be the key here. When I open the simple test table from above in v1.14 I get descending order. On opening the Sort/Filter dialog it see an

Re: [pgadmin-hackers] Changed default ordering in tables

2011-07-28 Thread Erwin Brandstetter
On 26.07.2011 23:20, Dave Page wrote: On Tue, Jul 26, 2011 at 9:53 PM, Erwin Brandstetter wrote: That may be the key here. When I open the simple test table from above in v1.14 I get descending order. On opening the Sort/Filter dialog it see an explicit ORDER BY test_id DESCENDING - which I di

Re: [pgadmin-hackers] Changed default ordering in tables

2011-07-26 Thread Dave Page
On Tue, Jul 26, 2011 at 9:53 PM, Erwin Brandstetter wrote: > That may be the key here. When I open the simple test table from above in > v1.14 I get descending order. On opening the Sort/Filter dialog it see an > explicit ORDER BY test_id DESCENDING - which I did not set. > Once I delete that, the

Re: [pgadmin-hackers] Changed default ordering in tables

2011-07-26 Thread Erwin Brandstetter
On 26.07.2011 22:29, Dave Page wrote: On Tue, Jul 26, 2011 at 7:13 PM, Erwin Brandstetter wrote: On 26.07.2011 18:12, Dave Page wrote: Hi Erwin On Tue, Jul 26, 2011 at 4:47 PM, Erwin Brandstetter wrote: Aloha! In v1.14 tables are opened with ORDER BY $pkey DESC. I wonder if descending

Re: [pgadmin-hackers] Changed default ordering in tables

2011-07-26 Thread Dave Page
On Tue, Jul 26, 2011 at 7:13 PM, Erwin Brandstetter wrote: > On 26.07.2011 18:12, Dave Page wrote: >> >> Hi Erwin >> >> On Tue, Jul 26, 2011 at 4:47 PM, Erwin Brandstetter >>  wrote: >>> >>> Aloha! >>> >>> In  v1.14 tables are opened with ORDER BY $pkey DESC. >>> I wonder if descending order ist

Re: [pgadmin-hackers] Changed default ordering in tables

2011-07-26 Thread Erwin Brandstetter
On 26.07.2011 18:12, Dave Page wrote: Hi Erwin On Tue, Jul 26, 2011 at 4:47 PM, Erwin Brandstetter wrote: Aloha! In v1.14 tables are opened with ORDER BY $pkey DESC. I wonder if descending order ist intended. It used to be the other way round and, as far as I am concerned, that was just fin

Re: [pgadmin-hackers] Changed default ordering in tables

2011-07-26 Thread Dave Page
Hi Erwin On Tue, Jul 26, 2011 at 4:47 PM, Erwin Brandstetter wrote: > Aloha! > > In  v1.14 tables are opened with ORDER BY $pkey DESC. > I wonder if descending order ist intended. It used to be the other way round > and, as far as I am concerned, that was just fine in most cases. > We have the ne