Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-30 Thread Guillaume Lelarge
Dave Page a écrit : > On Sat, Aug 30, 2008 at 9:44 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: > >> The current values could be the settings ones or the table ones. If we >> put the current values in the main textboxes, we will have to first >> check that at least one textbox value is diffe

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-30 Thread Dave Page
On Sat, Aug 30, 2008 at 9:44 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > The current values could be the settings ones or the table ones. If we > put the current values in the main textboxes, we will have to first > check that at least one textbox value is different from the current > value

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-30 Thread Guillaume Lelarge
Dave Page a écrit : > On Sat, Aug 30, 2008 at 9:28 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> Dave Page a écrit : >>> On Sat, Aug 30, 2008 at 5:52 PM, Guillaume Lelarge >>> <[EMAIL PROTECTED]> wrote: >>> > Oh, yes - of course. I wonder if we should give the static text boxes > a

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-30 Thread Dave Page
On Sat, Aug 30, 2008 at 9:28 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Dave Page a écrit : >> On Sat, Aug 30, 2008 at 5:52 PM, Guillaume Lelarge >> <[EMAIL PROTECTED]> wrote: >> Oh, yes - of course. I wonder if we should give the static text boxes a thin border so it's obviously

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-30 Thread Guillaume Lelarge
Dave Page a écrit : > On Sat, Aug 30, 2008 at 5:52 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: > >>> Oh, yes - of course. I wonder if we should give the static text boxes >>> a thin border so it's obviously they are there, even when empty? At >>> the moment it just looks odd. >>> >> I tried

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-30 Thread Dave Page
On Sat, Aug 30, 2008 at 5:52 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: >> Oh, yes - of course. I wonder if we should give the static text boxes >> a thin border so it's obviously they are there, even when empty? At >> the moment it just looks odd. >> > > I tried many things but didn't manag

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-30 Thread Dave Page
On Sat, Aug 30, 2008 at 5:28 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Dave Page a écrit : >> On Thu, Aug 28, 2008 at 8:56 AM, Guillaume Lelarge >> [...] >>> I'll first work on the server status window (remember the first part: >>> Replace the wxNotebook widget with the wxAuiNotebook so us

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-30 Thread Guillaume Lelarge
Dave Page a écrit : > On Wed, Aug 27, 2008 at 9:10 AM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: > >> It seems at the right place to me. There are three columns on this tab: >> first one for the labels, second one for the text box, and third one for >> static texts showing current values. >

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-30 Thread Guillaume Lelarge
Dave Page a écrit : > On Thu, Aug 28, 2008 at 8:56 AM, Guillaume Lelarge > [...] >> I'll first work on the server status window (remember the first part: >> Replace the wxNotebook widget with the wxAuiNotebook so users can close >> tabs and rearrange tabs order via drag-and-drop.) When the first pa

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-28 Thread Dave Page
On Thu, Aug 28, 2008 at 8:56 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > It sure seems a lot of work. We can't just replace the wxNotebook with a > wxAuiNotebook in the XRC files. I tried yesterday and it didn't work :-/ > > AFAICT, we need to write some code about a wxAuiManager and its pa

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-28 Thread Guillaume Lelarge
Dave Page a écrit : > On Thu, Aug 28, 2008 at 8:23 AM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: > >>> Well that may lead to some interestingly messy desktops (imagine - >>> separated tabs as far as the eye can see :-p ), but it could be useful >>> too. How does it solve this problem though?

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-28 Thread Dave Page
On Thu, Aug 28, 2008 at 8:23 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: >> Well that may lead to some interestingly messy desktops (imagine - >> separated tabs as far as the eye can see :-p ), but it could be useful >> too. How does it solve this problem though? >> > > wxAuiNotebook tabs can

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-28 Thread Guillaume Lelarge
Dave Page a écrit : > On Thu, Aug 28, 2008 at 12:15 AM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> Guillaume Lelarge a écrit : >>> Dave Page a écrit : >>> [...] It's also a real shame that tabs cannot scroll on the mac - having the dialogue extra wide doesn't look so nice :-(. >>>

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-28 Thread Dave Page
On Thu, Aug 28, 2008 at 12:15 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Guillaume Lelarge a écrit : >> Dave Page a écrit : >> [...] >>> It's also a real shame that tabs cannot scroll on the mac - having the >>> dialogue extra wide doesn't look so nice :-(. >> >> It's even less nice when yo

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-27 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : > Dave Page a écrit : > [...] >> It's also a real shame that tabs cannot scroll on the mac - having the >> dialogue extra wide doesn't look so nice :-(. > > It's even less nice when you open an existing table because there is one > more tab... > One other way to fix t

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-27 Thread Dave Page
On Wed, Aug 27, 2008 at 9:10 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > It seems at the right place to me. There are three columns on this tab: > first one for the labels, second one for the text box, and third one for > static texts showing current values. Oh, yes - of course. I wonder

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-27 Thread Guillaume Lelarge
Dave Page a écrit : > On Tue, Aug 26, 2008 at 10:50 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >>> [...] >>> I also get a crash if I try to open the New Table dialogue. I suspect >>> that is the possible incompatibility that you were worried about, >>> though I guess it could be related to

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-26 Thread Guillaume Lelarge
Dave Page a écrit : > On Tue, Aug 26, 2008 at 6:48 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> Guillaume Lelarge a écrit : >>> [...] >>> Back on this. The plan took a lot more time than I initially thought. >>> Anyways, here is the v5 patch updated. >>> >> I'm tired for sure... here is th

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-26 Thread Dave Page
On Tue, Aug 26, 2008 at 6:48 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Guillaume Lelarge a écrit : >> [...] >> Back on this. The plan took a lot more time than I initially thought. >> Anyways, here is the v5 patch updated. >> > > I'm tired for sure... here is the patch. :-( Well it looks

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-26 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : > [...] > Back on this. The plan took a lot more time than I initially thought. > Anyways, here is the v5 patch updated. > I'm tired for sure... here is the patch. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com enablingsqltextfield.20080826.patch.bz

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-08-26 Thread Guillaume Lelarge
Dave Page a écrit : > On Wed, Jul 9, 2008 at 12:31 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: > [...] >> I prefer to add sizing to all (properties') dialogs. This is a work I can >> do, step by step. I think I should follow these steps in this order: >> >> * one patch for each dialog to ad

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Dave Page
On Wed, Jul 9, 2008 at 12:31 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > I think you also check on Windows. No issue found? No, I don't have Windows to hand at the moment. I'm sure it will be fine here though if it works OK for you. Windows is pretty predictable in that way :-) > I prefer

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Guillaume Lelarge
Dave Page a écrit : On Wed, Jul 9, 2008 at 9:18 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: The last patch I sent works on GTK+. When I try it on Windows, it works for dlgFunction and dlgTrigger and doesn't with all other dlg*. I tried to understand what could be wrong with dlgDatabase. dl

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Dave Page
On Wed, Jul 9, 2008 at 9:18 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > The last patch I sent works on GTK+. When I try it on Windows, it works for > dlgFunction and dlgTrigger and doesn't with all other dlg*. I tried to > understand what could be wrong with dlgDatabase. dlgFunction already

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Guillaume Lelarge
Dave Page a écrit : (apologies for not reviewing the latest patch yet - we moved offices on Monday so I've been tied up with that for the last few days) No problem, don't worry :) On Wed, Jul 9, 2008 at 12:07 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: I worked on the remaining issue

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Dave Page
(apologies for not reviewing the latest patch yet - we moved offices on Monday so I've been tied up with that for the last few days) On Wed, Jul 9, 2008 at 12:07 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > I worked on the remaining issue tonight and it seems I can fix it this way: > I add

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-08 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : [...] The patch attached fixed some issues: * The "Are you sure..." message is displayed only when "Read Only" is checked. * No button is the default on the "Are you sure" message (which has a weird behaviour... hitting Esc will validate the dialog and the user

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-05 Thread Guillaume Lelarge
Dave Page a écrit : On Tue, Jul 1, 2008 at 11:52 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: I'm at the PostgreSQL booth, for the RMLL in Mont-de-Marsan (http://rmll.info). I'm trying the wifi system :) :-) Here is the patch that fixes your issue on Win32. Works great on Win32 and Linu

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-01 Thread Dave Page
On Tue, Jul 1, 2008 at 11:52 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > I'm at the PostgreSQL booth, for the RMLL in Mont-de-Marsan > (http://rmll.info). I'm trying the wifi system :) :-) > Here is the patch that fixes your issue on Win32. Works great on Win32 and > Linux... I'm not sure

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-01 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : Dave Page a écrit : On Fri, Jun 20, 2008 at 12:48 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Done. I thought we didn't hide UI objects, only disable them, to get a more consistant UI. On a single dialogue we disable objects so that dialogue will always have

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-20 Thread Dave Page
On Fri, Jun 20, 2008 at 1:09 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > I like "Lock DDL". Perhaps "Read only DDL" would please you more ? Nah, I like that even less. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@po

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-20 Thread Guillaume Lelarge
Dave Page a écrit : On Fri, Jun 20, 2008 at 12:48 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Done. I thought we didn't hide UI objects, only disable them, to get a more consistant UI. On a single dialogue we disable objects so that dialogue will always have the same layout no matter what

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-20 Thread Dave Page
On Fri, Jun 20, 2008 at 12:48 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Done. I thought we didn't hide UI objects, only disable them, to get a more > consistant UI. On a single dialogue we disable objects so that dialogue will always have the same layout no matter what server you're conne

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-19 Thread Guillaume Lelarge
Dave Page a écrit : On Tue, Jun 17, 2008 at 10:51 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Dave Page a écrit : When you open a properties dialogue, it gets passed a pointer to the pgObject which it may use right up until it is closed. If you refresh part of the tree, you delete and recr

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-18 Thread Dave Page
On Tue, Jun 17, 2008 at 10:51 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Dave Page a écrit : >> >> When you open a properties dialogue, it gets passed a pointer to the >> pgObject which it may use right up until it is closed. If you refresh >> part of the tree, you delete and recreate all t

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-17 Thread Guillaume Lelarge
Dave Page a écrit : On Tue, Jun 17, 2008 at 8:59 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: That can be potentially dangerous if the user has another property dialogue for a sibling object open though (actually that's an issue now iirc - this would just make it far more likely to occur).

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-17 Thread Dave Page
On Tue, Jun 17, 2008 at 8:59 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: >> That can be >> potentially dangerous if the user has another property dialogue for a >> sibling object open though (actually that's an issue now iirc - this >> would just make it far more likely to occur). >> > > What

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-17 Thread Guillaume Lelarge
Dave Page a écrit : On Mon, Jun 16, 2008 at 11:07 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: OK, this works on my local branch but I still have one issue with it: if the user change the name of a newly created object in the SQL text field, the treeview will display the name available in th

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-17 Thread Dave Page
On Mon, Jun 16, 2008 at 11:07 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > > OK, this works on my local branch but I still have one issue with it: if the > user change the name of a newly created object in the SQL text field, the > treeview will display the name available in the name field, n

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-16 Thread Guillaume Lelarge
Dave Page a écrit : On Mon, Jun 16, 2008 at 9:34 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Option 1 seems not very user friendly to me. Are you against option 2? if yes, why? Yes, because it's inconsistent to offer the feature in all but two dialogues. With option 1, the worst that wil

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-16 Thread Dave Page
On Mon, Jun 16, 2008 at 9:34 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Option 1 seems not very user friendly to me. Are you against option 2? if > yes, why? Yes, because it's inconsistent to offer the feature in all but two dialogues. With option 1, the worst that will happen is the user

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-16 Thread Guillaume Lelarge
Dave Page a écrit : On Mon, Jun 16, 2008 at 8:58 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Grmbl... There's a big flaw in my patch. You're right once again. Meh. It's happened a couple of times now :-) hehe Problem is, pgAdmin divide the queries to launch in two groups, only for

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-16 Thread Dave Page
On Mon, Jun 16, 2008 at 8:58 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Grmbl... There's a big flaw in my patch. You're right once again. Meh. It's happened a couple of times now :-) > Problem is, pgAdmin divide the queries to launch in two groups, only for > some objects : database and

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-16 Thread Dave Page
On Mon, Jun 16, 2008 at 9:11 PM, Dave Page <[EMAIL PROTECTED]> wrote: > Hmm, I'd forgotten about that. We do it because it allows us to run > non-transaction safe DDL in separate transactions (which is required > in 8.3). Actually, this is not a major issue - all that will happen is > that the ser

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-16 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : Dave Page a écrit : On Sat, Jun 14, 2008 at 3:01 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Finally, here is the prototype. As I first talked about this one year ago, I will summarize the idea : adding a checkbox on the SQL tab of an object's properties to le

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-14 Thread Guillaume Lelarge
Dave Page a écrit : On Sat, Jun 14, 2008 at 3:01 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Finally, here is the prototype. As I first talked about this one year ago, I will summarize the idea : adding a checkbox on the SQL tab of an object's properties to let the user change the SQL quer

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-14 Thread Dave Page
On Sat, Jun 14, 2008 at 3:01 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Finally, here is the prototype. As I first talked about this one year ago, I > will summarize the idea : adding a checkbox on the SQL tab of an object's > properties to let the user change the SQL query. Checking will

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-06-14 Thread Guillaume Lelarge
Dave Page a écrit : Guillaume Lelarge wrote: [...] Ideas ? Comments ? I think I'd like to see a prototype so we can get a feel for how it would work and what might explode. It shouldn't be too hard to do - just add an option to the SQL tab, and when selected, lock the tabset to that tab. Th

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2007-07-31 Thread Dave Page
Guillaume Lelarge wrote: Hi all, I was looking at the new features of DBVisualizer and found something that please me. I don't know if you remember this old thread : http://www.pgadmin.org/archives/pgadmin-hackers/2007-03/msg4.php I want to be able to change the generated SQL on object di