Thanks Dave.
On Fri, Jul 19, 2013 at 2:43 PM, Dave Page wrote:
> Thanks, patch applied.
>
> On Fri, Jul 19, 2013 at 7:21 AM, Neel Patel
> wrote:
> > Hi Dave,
> >
> > Thanks for the comment.
> >
> > We made the changes as you suggested.
> >
> > Please find the updated patch in attachment and let
Thanks, patch applied.
On Fri, Jul 19, 2013 at 7:21 AM, Neel Patel wrote:
> Hi Dave,
>
> Thanks for the comment.
>
> We made the changes as you suggested.
>
> Please find the updated patch in attachment and let me know if you have any
> query.
>
> Thanks,
> Neel Patel
>
>
> On Thu, Jul 18, 2013 a
Hi Dave,
Thanks for the comment.
We made the changes as you suggested.
Please find the updated patch in attachment and let me know if you have any
query.
Thanks,
Neel Patel
On Thu, Jul 18, 2013 at 5:54 PM, Dave Page wrote:
> Hi
>
> I realised this code is all wonky anyway - why is IsMaterial
Hi
I realised this code is all wonky anyway - why is IsMaterializedView()
not just an accessor over a pgView private variable that is set in
pgViewFactory::CreateObjects when we create the object? We already
know at that point whether it's a matview or not (from
pg_class.relkind). Querying pg_clas
Hi Dave,
Please find the updated patch with modification in query.
Thanks,
Neel Patel
On Wed, Jul 17, 2013 at 5:15 PM, Dave Page wrote:
> On Wed, Jul 17, 2013 at 12:23 PM, Neel Patel
> wrote:
> > Hi Dave,
> >
> > Just want to know.
> >
> > Now we are passing GetName() to qtDbString() and to f
On Wed, Jul 17, 2013 at 12:23 PM, Neel Patel
wrote:
> Hi Dave,
>
> Just want to know.
>
> Now we are passing GetName() to qtDbString() and to form the complete query
> we need to use qtDbString() to compare the string.
>
> We have added below string.
>
> wxString sql = wxT("SELECT count(*) FROM pg
Hi Dave,
Just want to know.
Now we are passing GetName() to qtDbString() and to form the complete query
we need to use qtDbString() to compare the string.
We have added below string.
wxString sql = wxT("SELECT count(*) FROM pg_matviews WHERE matviewname = ")
+ qtDbString(this->GetName()) + wxT(
Hi Dave,
Yes, you are right.
I also found one bug because of this fix where information is not correct
in the SQL Pane.
I will check and will send you the updated patch.
Thanks,
Neel Patel
On Wed, Jul 17, 2013 at 1:45 PM, Dave Page wrote:
> Hi
>
> On Tue, Jul 16, 2013 at 2:58 PM, Neel Patel
Hi
On Tue, Jul 16, 2013 at 2:58 PM, Neel Patel wrote:
> Hi Dave,
>
> Below is the bug description and find attached patch for fix.
>
>
> "If create any MATERIALIZED VIEW with double quote in SQL pane of
> pgAdminIII, the syntax is not displayed properly and it's showing create
> view instead of M
Hi Dave,
Below is the bug description and find attached patch for fix.
"If create any MATERIALIZED VIEW with double quote in SQL pane of
pgAdminIII, the syntax is not displayed properly and it's showing create
view instead of MATERIALIZED View, and user can not drop that and displayed
use MATERI
Hi Dave,
I think we missed to commit the below bug fix for materialized view.
Thanks,
Neel Patel
On Tue, Jul 2, 2013 at 12:42 PM, Neel Patel wrote:
> Hi Dave,
>
> Attached patch contains the fix for the below bug for materialized view in
> pgAdmin.
>
>
> "If create any MATERIALIZED VIEW with d
Thanks Dave.
Thanks,
Neel Patel
On Mon, Jul 8, 2013 at 6:04 PM, Dave Page wrote:
> Thanks, patch applied.
>
> On Wed, Jul 3, 2013 at 8:44 AM, Neel Patel
> wrote:
> > Hi Dave,
> >
> > Thanks for the comments.
> >
> > Find the attached patch with below fix.
> >
> > --- Incomplete comments remove
Thanks, patch applied.
On Wed, Jul 3, 2013 at 8:44 AM, Neel Patel wrote:
> Hi Dave,
>
> Thanks for the comments.
>
> Find the attached patch with below fix.
>
> --- Incomplete comments removed and added new comments
> --- s/Closed/Materialized/
> --- Added column "relkind" in outer query and remo
Hi Dave,
Thanks for the comments.
Find the attached patch with below fix.
--- Incomplete comments removed and added new comments
--- s/Closed/Materialized/
--- Added column "relkind" in outer query and removed the SELECT from the
loop.
--- Combined the below statement.
"(collection->GetConn
Hi
On Tue, Jul 2, 2013 at 3:25 PM, Thom Brown wrote:
> On 29 May 2013 10:40, Neel Patel wrote:
>> Hi Dave,
>>
>> Please find the updated patch after fixing some of the issues and comments
>> given by Ashesh.
>
> Just realised this reply has been in my draft folder for over a month...
>
>
> This
On 29 May 2013 10:40, Neel Patel wrote:
> Hi Dave,
>
> Please find the updated patch after fixing some of the issues and comments
> given by Ashesh.
Just realised this reply has been in my draft folder for over a month...
This comment appears to be incomplete:
//While editing the view, if it i
Hi
On Mon, Jul 1, 2013 at 1:00 PM, Neel Patel wrote:
> Hi Dave,
>
> Find the attached patch file ( it is on top of master branch ) for change in
> icon of materialized view in pgAdmin and also put the icon images attached
> in pgadmin/include/images folder.
>
> Please let me know in case of any i
Hi Dave,
Attached patch contains the fix for the below bug for materialized view in
pgAdmin.
"If create any MATERIALIZED VIEW with double quote in SQL pane of
pgAdminIII, the syntax is not displayed properly and it's showing create
view instead of MATERIALIZED View, and user can not drop that an
Hi Dave,
Find the attached patch file ( it is on top of master branch ) for change
in icon of materialized view in pgAdmin and also put the icon images
attached in pgadmin/include/images folder.
Please let me know in case of any issue.
Thanks,
Neel Patel
On Wed, Jun 19, 2013 at 8:46 PM, Dave
Thanks, applied.
On Wed, Jun 19, 2013 at 12:54 PM, Neel Patel
wrote:
> Hi Dave,
>
> Fixed the below bug.
>
> Bug:-
>
> When user creates the new schema and provides . in
> the definition of the materialized view then it fails to display correct
> information in properties and SQL pane. Below are
Hi Dave,
Fixed the below bug.
*Bug:- *
*
*
When user creates the new schema and provides . in
the definition of the materialized view then it fails to display correct
information in properties and SQL pane. Below are the steps to reproduce it.
Step 1 :- Create new schema under database.
Step 2:-
Committed with a couple of minor changes:
- Add the word "MATERIALIZED" to the COMMENT SQL where appropriate.
- List the comment after all the other properties, per our standard.
Thanks!!
On Fri, Jun 14, 2013 at 7:02 AM, Neel Patel wrote:
> Hi Dave,
>
>
> On Thu, Jun 13, 2013 at 5:41 PM, Dave
Hi
On Thu, Jun 13, 2013 at 9:23 AM, Neel Patel wrote:
> Hi Dave,
>
> Please find the updated patch file for Materialized View with below changes.
>
> Materialized View UI changes
> Added Option for WITH DATA
> Some of the bug fixes
Much better :-)
The only issue that I can fin
Hi
Per our discussion earlier, please put the Materialized: Yes/No option
at the top of the Materialization tab, and below that add a tabset
with three tabs for Options, and the heap and toast Vacuum options.
Thanks.
On Mon, Jun 10, 2013 at 10:16 AM, Neel Patel
wrote:
> Hi Dave,
>
> We have bel
Hi Dave,
We have below three options.
1. Materialized Yes/No
2. TableSpace
3. Fill Factor
I have checked with three options and below that two tabs so for that we
need to increase little height of the dialog to fit in. If so then we will
implement that and after detail testing will send you the
Hi
On Mon, Jun 10, 2013 at 7:23 AM, Neel Patel wrote:
> Hi Dave,
>
> We can combine the Materialization Tab and auto-vacuum tab.
>
> To make it consistent with other UI I would suggest to have one Tab called
> "Materialization" and in that tab we have another three Tabs.
>
> 1. Options ( Or we ca
Hi Dave,
We can combine the Materialization Tab and auto-vacuum tab.
To make it consistent with other UI I would suggest to have one Tab called
"Materialization" and in that tab we have another three Tabs.
1. Options ( Or we can have another name ) For setting the option for
materialized vi
On Mon, Jun 3, 2013 at 7:29 PM, Neel Patel wrote:
>
>
> On Mon, Jun 3, 2013 at 5:20 PM, Dave Page
> wrote:
>>
>> Hi
>>
>> On Mon, Jun 3, 2013 at 7:56 AM, Neel Patel
>> wrote:
>> > Hi Dave,
>> >
>> > Thanks for update.
>> >
>> > Yes it is a bug, I have not put the version check.
>> >
>> > Below a
On Mon, Jun 3, 2013 at 5:20 PM, Dave Page wrote:
> Hi
>
> On Mon, Jun 3, 2013 at 7:56 AM, Neel Patel
> wrote:
> > Hi Dave,
> >
> > Thanks for update.
> >
> > Yes it is a bug, I have not put the version check.
> >
> > Below are the changes.
> > --- Put the PG version check for mat views
> > ---
Hi
On Mon, Jun 3, 2013 at 7:56 AM, Neel Patel wrote:
> Hi Dave,
>
> Thanks for update.
>
> Yes it is a bug, I have not put the version check.
>
> Below are the changes.
> --- Put the PG version check for mat views
> --- In SQL Pane window change the the description of the view from --
> MATERIA
On Wed, May 29, 2013 at 10:40 AM, Neel Patel
wrote:
> Hi Dave,
>
> Please find the updated patch after fixing some of the issues and comments
> given by Ashesh.
I haven't looked at the code, but judging by the error I got when
first clicking on a view on a PG 9.2 server, you forgot to make this
c
31 matches
Mail list logo
