Thanks - committed.
On Wed, Mar 16, 2016 at 7:22 AM, Sanket Mehta
wrote:
> Hi,
>
> I forgot tot mention bugs in previous mail.
>
>
> 1. System cast field was showing Yes even if the cast was not a system cast,
> which I have resolved.
> 2. In Dependent and Dependency method in __init__.py file,
Hi,
I forgot tot mention bugs in previous mail.
1. System cast field was showing Yes even if the cast was not a system
cast, which I have resolved.
2. In Dependent and Dependency method in __init__.py file, unnecessary
third parameter 'cast' was being passed which I have removed
Regards,
San
Hi Dave,
PFA the patch for cast module incorporating changes regarding showing
system objects.
Apart from support for showing system object I have resolved few bugs in
that, unnecessary code and added nodes.sql file.
Please do review it and if it looks good, please commit.
Regards,
Sanket Mehta
Thanks, patch applied.
On Tue, Mar 1, 2016 at 7:20 AM, Sanket Mehta
wrote:
> Hi,
>
> There was an error in cast module while fetching its dependency and
> dependent.
> Below is the patch which resolves this issue.
> Please review and commit it.
>
>
>
> Regards,
> Sanket Mehta
> Sr Software engine
Hi,
There was an error in cast module while fetching its dependency and
dependent.
Below is the patch which resolves this issue.
Please review and commit it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Feb 24, 2016 at 10:17 PM, Dave Page wrote:
> Thanks - committed.
>
> O
Thanks - committed.
On Tue, Feb 23, 2016 at 1:34 PM, Sanket Mehta wrote:
> Hi,
>
> PFA the revised patch as per your comments.
> Please review it and let me know the feedback.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Tue, Feb 23, 2016 at 4:10 PM, Dave Page wrote:
Hi,
PFA the revised patch as per your comments.
Please review it and let me know the feedback.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Feb 23, 2016 at 4:10 PM, Dave Page wrote:
> Hi
>
> I've attached an update to this patch, in which I've done some
> word-smithing on va
Hi
I've attached an update to this patch, in which I've done some
word-smithing on various comments, and adjusted the SQL templates to
improve the formatting.
However, it looks like it's bit-rotted, as the dependents/dependencies
display is throwing Python errors. Please fix and then I think it's
Hi Dave,
PFA the revise patch.
It includes changes according to your review comments as well as
dependency/dependent part also.
Let me know in case anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Feb 15, 2016 at 10:25 PM, Dave Page wrote:
> And this time
And this time with the attachment...
On Mon, Feb 15, 2016 at 4:53 PM, Dave Page wrote:
> That's much better. Just a couple of comments now, partly based on an
> email I wrote earlier:
>
> - There is still inconsistency in comment style. Please see the attachment
> for an example. Note that there
That's much better. Just a couple of comments now, partly based on an email
I wrote earlier:
- There is still inconsistency in comment style. Please see the attachment
for an example. Note that there is *always* a space between the comment
marker and text.
- If I try to edit a cast, I can change
Hi,
PFA the revised patch with all the required comments.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Feb 15, 2016 at 4:18 PM, Dave Page wrote:
>
>
> On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta <
> sanket.me...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Regarding your
On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta wrote:
> Hi Dave,
>
> Regarding your suggestion of putting some comments in javascript, I think
> I have already put some comments regarding model data and their controls if
> any extended.
>
> Can you please let me know where exactly you think more c
Hi Dave,
Regarding your suggestion of putting some comments in javascript, I think I
have already put some comments regarding model data and their controls if
any extended.
Can you please let me know where exactly you think more comments are
required?
Regards,
Sanket Mehta
Sr Software engineer
On Fri, Feb 12, 2016 at 11:57 AM, Sanket Mehta <
sanket.me...@enterprisedb.com> wrote:
> Hi Akshay,
>
> PFA the updated patch.
>
>
Hi
When testing this patch, I get the following error:
Traceback (most recent call last):
File "pgAdmin4.py", line 56, in
app = create_app()
File "/Users/dp
Hi Akshay,
PFA the updated patch.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, Feb 11, 2016 at 12:09 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
> Hi Sanket
>
> Most of the review comments has been resolved but I found some issues with
> this patch
>
>- When
Hi Sanket
Most of the review comments has been resolved but I found some issues with
this patch
- When select some system cast it is showing wrong query, for example
when select "abstime->date" in pgAdmin3 it is showing "AS ASSIGNMENT"
and with your code it is showing "AS IMPLICIT".
-
Hi Akshay,
PFA the revised patch.
All the comments are inline.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, Feb 5, 2016 at 12:43 PM, Akshay Joshi wrote:
> Hi Sanket
>
> Below are the review comments
>
>- As "Show System Object" is not implemented yet, we should show all
Hi Sanket
Below are the review comments
- As "Show System Object" is not implemented yet, we should show all the
objects by default.
- As in pgAdmin3 when click on Casts (Collection) node it should show
only Name, Owner and Comments. With current code it is showing all the
properti
Hi Akshay,
PFA the latest patch for Cast module.
Please do review it and let me know if anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Jan 20, 2016 at 5:03 PM, Sanket Mehta wrote:
> Hi Neel.
>
> PFA the revised patch which has changed according to your co
Hi Neel.
PFA the revised patch which has changed according to your comments.
Please do review it and let me know in case anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Jan 20, 2016 at 10:20 AM, Neel Patel
wrote:
> Hi Sanket,
>
> Below are the review comm
Hi Sanket,
Below are the review comments.
- When we edit any existing cast node then it gives error "*Response object
has no attribute strip*". This error is coming because generated SQL is
wrong.
- Unnecessary debug logs are coming on console. Please remove unnecessary
debug logs.
- In some of
Hi,
PFA updated patch for cast module as per check list provided by Neel.
Please do review it and let me know in case of anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Jan 18, 2016 at 7:16 PM, Sanket Mehta wrote:
> Hi,
>
> PFA patch for cast module.
> Pl
23 matches
Mail list logo
