Sure.
On Thu, Sep 1, 2016 at 4:44 PM, Dave Page
wrote:
> Hi
>
> Please separate the cleanup from the new tests. Each patch should have
> just one feature/focus/fix.
>
> Thanks.
>
> On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh <
> navnath.gad...@enterprisedb.com> wrote:
>
>> Hello Dave,
>>
Hi
Please separate the cleanup from the new tests. Each patch should have just
one feature/focus/fix.
Thanks.
On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:
> Hello Dave,
> Object cleanup work is completed in above patch. I am working on enhanced
>
Hello Dave,
Object cleanup work is completed in above patch. I am working on enhanced
summary work, once that's complete I will send the revised patch.
Thanks!
On Thu, Sep 1, 2016 at 3:57 PM, Dave Page
wrote:
> Per my earlier email to Priyanka, I'm not going to commit any more test
> cases
Per my earlier email to Priyanka, I'm not going to commit any more test
cases until the existing issues are resolved and the enhanced summary and
object cleanup work is complete, otherwise it's just taking too much time
unnecessarily.
Please re-test and resubmit this patch once that work is comple
Hi Dave,
Currently I am working on that. Will send it in the next patch.
Thanks!
On Tue, Aug 16, 2016 at 6:05 PM, Dave Page
wrote:
> Thanks - applied!
>
> Can you please work on the following ASAP?
>
> - Removal of encoded credentials from the SMTP test output.
> - Summary display as dis
Thanks - applied!
Can you please work on the following ASAP?
- Removal of encoded credentials from the SMTP test output.
- Summary display as discussed.
Thanks again.
On Fri, Aug 12, 2016 at 10:40 AM, Navnath Gadakh
wrote:
> Hi Dave,
> Please find the patch for API unit test cases for Sch
Hi Dave,
Please find the patch for API unit test cases for Schema and its
sub-nodes (Collations and Trigger functions).
You can run testsuite using the following commands
*For schemas*
python regression/runtests.py --pkg
browser.server_groups.servers.databases.schemas
*For Collations*
Thanks - applied with some minor wording and README tweaks.
On Tue, Aug 9, 2016 at 10:19 AM, Navnath Gadakh
wrote:
> Hi Dave,
>
> On Mon, Aug 8, 2016 at 9:15 PM, Dave Page
> wrote:
>>
>> Hi
>>
>> I guess you need to test if tablespace_path is omitted, not just empty?
>
> Yes, thats right.. P
Hi
I guess you need to test if tablespace_path is omitted, not just empty?
This function test the add tablespace scenario (Check Tablespace Node) ... ERROR
==
ERROR: setUpClass
(pgadmin.browser.server_groups.servers.tablespaces.
On Thu, Aug 4, 2016 at 1:02 PM, Navnath Gadakh
wrote:
> Hi Dave,
>
> On Thu, Aug 4, 2016 at 4:04 PM, Dave Page
> wrote:
>>
>> Hi
>>
>> On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh
>> wrote:
>>
>> >> Oh - does the per-server config override the main config? That's
>> >> useful. So anything tha
Hi Dave,
On Thu, Aug 4, 2016 at 4:04 PM, Dave Page
wrote:
> Hi
>
> On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh
> wrote:
>
> >> Oh - does the per-server config override the main config? That's
> >> useful. So anything that's in test_advanced_config.py can be
> >> overridden on a per-server b
Hi
On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh
wrote:
>> Oh - does the per-server config override the main config? That's
>> useful. So anything that's in test_advanced_config.py can be
>> overridden on a per-server basis in test_config.py?
>
> No.
> per-server i.e advance config(tes
Hi Dave,
On Wed, Aug 3, 2016 at 8:32 PM, Dave Page
wrote:
> On Wed, Aug 3, 2016 at 2:01 PM, Navnath Gadakh
> wrote:
> > Hi Dave,
> > Thanks for clarification.
> >
> > On Wed, Aug 3, 2016 at 2:45 PM, Dave Page
> > wrote:
> >>
> >> Hi Navnath
> >>
> >> On Tue, Aug 2, 2016 at 3:58 PM, Navnat
On Wed, Aug 3, 2016 at 2:01 PM, Navnath Gadakh
wrote:
> Hi Dave,
> Thanks for clarification.
>
> On Wed, Aug 3, 2016 at 2:45 PM, Dave Page
> wrote:
>>
>> Hi Navnath
>>
>> On Tue, Aug 2, 2016 at 3:58 PM, Navnath Gadakh
>> wrote:
>> > Hi Dave,
>> > Please find the attached patch.
>> > Th
Hi Dave,
Thanks for clarification.
On Wed, Aug 3, 2016 at 2:45 PM, Dave Page
wrote:
> Hi Navnath
>
> On Tue, Aug 2, 2016 at 3:58 PM, Navnath Gadakh
> wrote:
> > Hi Dave,
> > Please find the attached patch.
> > This patch includes:
> > 1. API test cases for Roles & Tablespaces node(Com
Hi Navnath
On Tue, Aug 2, 2016 at 3:58 PM, Navnath Gadakh
wrote:
> Hi Dave,
> Please find the attached patch.
> This patch includes:
> 1. API test cases for Roles & Tablespaces node(Completed nodes: server
> groups, servers, databases)
> You can run test-suite using following command
>
Hi Dave,
Please find the attached patch.
*This patch includes:*
1. API test cases for Roles & Tablespaces node(Completed nodes: server
groups, servers, databases)
You can run test-suite using following command
for roles node
python regression/runtests.py --pkg
browser.s
Hi
On Mon, Aug 1, 2016 at 10:54 AM, Navnath Gadakh
wrote:
> Hi Dave,
>
> On Mon, Aug 1, 2016 at 3:17 PM, Dave Page wrote:
>> On Thu, Jul 28, 2016 at 8:12 AM, Navnath Gadakh
>> wrote:
>>> Thanks Dave!
>>>
>>> On Wed, Jul 27, 2016 at 8:12 PM, Dave Page
>>> wrote:
Ahh, that explains it. Nic
Hi Dave,
On Mon, Aug 1, 2016 at 3:17 PM, Dave Page wrote:
> On Thu, Jul 28, 2016 at 8:12 AM, Navnath Gadakh
> wrote:
>> Thanks Dave!
>>
>> On Wed, Jul 27, 2016 at 8:12 PM, Dave Page
>> wrote:
>>> Ahh, that explains it. Nice catch! It's working in both server and
>>> desktop modes now :-).
>>>
On Thu, Jul 28, 2016 at 8:12 AM, Navnath Gadakh
wrote:
> Thanks Dave!
>
> On Wed, Jul 27, 2016 at 8:12 PM, Dave Page wrote:
>> Ahh, that explains it. Nice catch! It's working in both server and
>> desktop modes now :-).
>>
>> I've committed the patch, but can you please look at the following issu
Thanks Dave!
On Wed, Jul 27, 2016 at 8:12 PM, Dave Page wrote:
> Ahh, that explains it. Nice catch! It's working in both server and
> desktop modes now :-).
>
> I've committed the patch, but can you please look at the following issues:
>
> 1) When testing SMTP, the encoded password used to connec
On 27 July 2016 at 20:12, Dave Page wrote:
> Ahh, that explains it. Nice catch! It's working in both server and
> desktop modes now :-).
>
Great. Thanks to Khushboo for helping Navnath in this task.
Thank you.
> On Wed, Jul 27, 2016 at 1:19 PM, Navnath Gadakh
> wrote:
> > Hi Dave,
> >
Ahh, that explains it. Nice catch! It's working in both server and
desktop modes now :-).
I've committed the patch, but can you please look at the following issues:
1) When testing SMTP, the encoded password used to connect to the
server is displayed in both the logs and stdout (the "send: 'AUTH
Hi Dave,
We have reproduced the issue you mentioned in the previous
email. We need to skip the login related test cases when SERVER_MODE =
False in the web/config_local.py.
Please find the revised patch for the same.
Thanks!
On Fri, Jul 22, 2016 at 9:48 PM, Dave Page wrote:
> Hi
>
> On F
Hi Dave,
I tried to reproduce this issue at my end, but didn't work.
Also tried with clean GIT tree.
Will look more into this tomorrow.
Thanks!
On Fri, Jul 22, 2016 at 9:48 PM, Dave Page
wrote:
> Hi
>
> On Fri, Jul 22, 2016 at 2:22 PM, Navnath Gadakh
> wrote:
> > Hi Dave,
> >
> >
Hi
On Fri, Jul 22, 2016 at 2:22 PM, Navnath Gadakh
wrote:
> Hi Dave,
>
>Please find the attached patch for pgAdmin4 unittest(Support of API
> testing with different servers i.e. PG and PPAS).
>
> This patch includes-
>
> Test framework support API testing with multiple server for this we need
Hi Dave,
Please find the attached patch for pgAdmin4 unittest(Support of API
testing with different servers i.e. PG and PPAS).
*This patch includes-*
1.
Test framework support API testing with multiple server for this we need
to modify test_config.json(for user it’s test_config.json
Hi Navnath,
I have just ran the automated test cases, I noticed that the login
test-case gets called (which actually post data and gets logged-in) each
time before every test case runs. I think this should not happen, user
login should be done only once.
Thanks,
Khushboo
On Mon, Jul 18, 2016 at
Thanks - applied with some tweaks and changes, most notably:
- "--pkg all" is the default if no command line options are given.
- Output now goes in regression/regression.log
- Terminal output is limited to WARNINGS from the app server.
- The runner script is now python regression/runtests.py
Hi Dave,
Please find the revised patch for unit tests of pgAdmin4 APIs.
This patch includes-
1.
test_advance_config.json(for user it’s test_advance_config.json.in) for
advance test configuration for database/server(Priyanka was working on this)
2.
test_config.json(for user it’
Hi
On Mon, Jul 11, 2016 at 2:16 PM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:
> Hi Dave,
> PFA updated patch for modular API test cases.
>
> On Mon, Jul 11, 2016 at 5:11 PM, Dave Page
> wrote:
>
>>
>>
>> On Fri, Jul 8, 2016 at 2:30 PM, Navnath Gadakh <
>> navnath.gad...@enterprise
Hi Dave,
PFA updated patch for modular API test cases.
On Mon, Jul 11, 2016 at 5:11 PM, Dave Page
wrote:
>
>
> On Fri, Jul 8, 2016 at 2:30 PM, Navnath Gadakh <
> navnath.gad...@enterprisedb.com> wrote:
>
>>
>> Hi Dave,
>>
>> PFA patch for modular API test cases.
>>
>> Kindly, review the same and
On Fri, Jul 8, 2016 at 2:30 PM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:
>
> Hi Dave,
>
> PFA patch for modular API test cases.
>
> Kindly, review the same and let me know for any modification.
>
Please re-create the patch so that it doesn't revert various changes made
to config.p
33 matches
Mail list logo
