Ensure the feature tests use the correct test settings database. Fixes #2486
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ee555e4687dcd94cc054738076b4cb78999e81c
Author: Khushboo Vashi
Modified Files
--
web/config.py
Fix the JS Bundler test to work when there are multiple servers defined in a
test run.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b846ae4e04efee32156c4def44346a6878de6b0
Author: Joao Pedro De Almeida Pereira
Modified Files
un 13, 2017 at 10:35 AM, Dave Page wrote:
>>
>> Hi
>>
>> On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
>> wrote:
>> > Hi Hackers,
>> >
>> > Attached you can find the patch that corrects that Bundle tests that was
>> > po
kers,
> >
> > Attached you can find the patch that corrects that Bundle tests that was
> > polluting the os and subprocess modules.
> >
> > This patch reverts the commit that skipped the test.
>
> This is almost exactly what Ashesh and I came up with (along wit
Hi
On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
wrote:
> Hi Hackers,
>
> Attached you can find the patch that corrects that Bundle tests that was
> polluting the os and subprocess modules.
>
> This patch reverts the commit that skipped the test.
This is a
Hi Hackers,
Attached you can find the patch that corrects that Bundle tests that was
polluting the os and subprocess modules.
This patch reverts the commit that skipped the test.
Thanks
Shruti & Joao
correct-bundle-test.patch
Description: Binary data
--
Sent via pgadmin-hackers mai
Hello Hackers,
We will create a new patch to solve this issue.
Thanks
Joao & Shruti
On Tue, Jun 13, 2017 at 9:37 AM, Dave Page wrote:
> Pivotal team,
>
> Per the commit below, and the probably many messages you've likely
> seen from Jenkins, I've had to disable the
Pivotal team,
Per the commit below, and the probably many messages you've likely
seen from Jenkins, I've had to disable the JavascriptBundler test. It
works fine if you're testing a single server, but if you have more
than one enabled in test_config.json, then it will fail on th
Temporarily disable the Javascript bundler test until it handle more than one
run.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb97722fc3826f94f375f5f48807a486383ee3a9
Modified Files
--
web/pgadmin/utils/javascript/tests
>>
>> Hi Hackers,
>>
>> We were trying to run the feature tests against GreenPlum and one of the
>> tests was failing (CheckForViewDataTest). In this test, we are creating a
>> table using COLLATE, and the COLLATE command is only available starting in
>> ver
Skip a test that uses the COLLATE option on PG versions below 9.1 (e.g.
Greenplum).
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9ce9c97173e904792073597f90ff30c4bfdc1fc
Author: Joao Pedro De Almeida Pereira
Modified Files
of the
> tests was failing (CheckForViewDataTest). In this test, we are creating a
> table using COLLATE, and the COLLATE command is only available starting
> in version 9.1 of Postgres, per the documentation. We decided to skip this
> test for now for all PG Versions below 9.1
>
Hi Hackers,
We were trying to run the feature tests against GreenPlum and one of the
tests was failing (CheckForViewDataTest). In this test, we are creating a
table using COLLATE, and the COLLATE command is only available starting in
version 9.1 of Postgres, per the documentation. We decided to
Resolve the PG datatype feature test flakiness and make for a nice buttery
crust.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f89aec867a3bcac337362889dfb6769188524839
Author: George Gelashvili
Modified Files
Hi
OK. Do you know why? What's it waiting for? It was working for me (I
always run tests multiple times before committing them, to try to
ensure they're reliable).
On Mon, May 29, 2017 at 7:23 AM, Murtuza Zabuawala
wrote:
> Hi Dave,
>
> With latest pull, PG data-type test
Hi Dave,
With latest pull, PG data-type test fails on my system,
==
ERROR: runTest (pgadmin.feature_tests.pg_datatype_validation_test.
PGDataypeFeatureTest)
Test checks for PG data-types output
Increase feature test timeouts.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=10caae4dc699511a03461814ee94b5fb310a7675
Author: George Gelashvili
Modified Files
--
web/regression/feature_utils/pgadmin_page.py | 11 +++
1
houldn't increase the overall test time, but only allow waiting longer
> for an element to appear, if needed.
>
> We've also split out the app start timeout since that seemed to need more
> time on CI.
>
> Patch attached.
>
> Thanks!
> Joao, Matt, and George
>
&g
Hello Hackers,
We are running tests including feature tests in Circle CI, and have been
seeing some flakiness due to what we believe are insufficient wait-for
timeouts.
This shouldn't increase the overall test time, but only allow waiting
longer for an element to appear, if needed.
We&#x
t; >
>> > Please find the attached updated patch.
>> >
>> > Thanks,
>> > Khushboo
>> >
>> > On Thu, May 11, 2017 at 2:41 PM, Dave Page wrote:
>> >>
>> >> Hi
>> >>
>> >> On Thu, May 11, 2017 at 6:38
>
>> > Thanks,
>> > Khushboo
>> >
>> > On Thu, May 11, 2017 at 2:41 PM, Dave Page wrote:
>> >>
>> >> Hi
>> >>
>> >> On Thu, May 11, 2017 at 6:38 AM, Khushboo Vashi
>> >> wrote:
>> >>>
atch.
> >
> > Thanks,
> > Khushboo
> >
> > On Thu, May 11, 2017 at 2:41 PM, Dave Page wrote:
> >>
> >> Hi
> >>
> >> On Thu, May 11, 2017 at 6:38 AM, Khushboo Vashi
> >> wrote:
> >>>
> >>> Hi,
> >
; Hi
>>
>> On Thu, May 11, 2017 at 6:38 AM, Khushboo Vashi
>> wrote:
>>>
>>> Hi,
>>>
>>> As we have been facing many issues with different data-type display in
>>> Query Tool output, Dave suggested to write the feature test for the same
ng many issues with different data-type display in
>> Query Tool output, Dave suggested to write the feature test for the same.
>>
>> I have started with some basic set of data-type values and will add more.
>> Please find the attached initial patch for the same.
>>
>
(pgadmin.feature_tests.pg_data
>> type_validation_test.PGDataypeFeatureTest)
>> Test checks for PG data-types output
>> --
>> Traceback (most recent call last):
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmi
On Thu, May 11, 2017 at 2:45 PM, Dave Page wrote:
> BTW - on a related note, I was seeing this failure in the tests:
>
> FAIL: runTest (pgadmin.feature_tests.pg_datatype_validation_test.PGDataype
> FeatureTest)
> Test checks for PG da
BTW - on a related note, I was seeing this failure in the tests:
FAIL: runTest
(pgadmin.feature_tests.pg_datatype_validation_test.PGDataypeFeatureTest)
Test checks for PG data-types output
--
Traceback (most recent call last
Hi
On Thu, May 11, 2017 at 6:38 AM, Khushboo Vashi <
[email protected]> wrote:
> Hi,
>
> As we have been facing many issues with different data-type display in
> Query Tool output, Dave suggested to write the feature test for the same.
>
> I have started wit
Hi,
As we have been facing many issues with different data-type display in
Query Tool output, Dave suggested to write the feature test for the same.
I have started with some basic set of data-type values and will add more.
Please find the attached initial patch for the same.
Thanks,
Khushboo
om> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find the revised patch. I have added some print
>>> statements for debug purpose, so that I can get which line causing this
>>> issue. Most probably issue should be in the cleanup process.
>>>
>&g
Windows compatibility fixes for the test suite.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c32bf7780e718d66ef0c70af53519dac02224e1e
Author: Navnath Gadakh
Modified Files
--
.../utils/tests/test_versioned_template_loader.py
nt statements
>> for debug purpose, so that I can get which line causing this issue. Most
>> probably issue should be in the cleanup process.
>>
>> Please apply the patch and run the regression. Send me your console
>> output and *regression.log* file
>>
>>
*regression.log* file
Thanks!
On Thu, May 4, 2017 at 2:18 PM, Dave Page wrote:
> I still see the issue. See the attached screenshot. Killing process 32287
> caused the test suite to exit.[image: Inline image 1]
>
> On Wed, May 3, 2017 at 1:32 PM, Navnath Gadakh <
> navnath.gad..
I still see the issue. See the attached screenshot. Killing process 32287
caused the test suite to exit.[image: Inline image 1]
On Wed, May 3, 2017 at 1:32 PM, Navnath Gadakh <
[email protected]> wrote:
> It's getting strange now. I just updated my Mac OS from EI C
It's getting strange now. I just updated my Mac OS from EI Capitan(10.11.6)
to Sierra(10.12.4). I have applied the patch and it ran successfully
without any hangup.
This is my console output:
*==*
*Test Result Su
>> It just hangs after printing the result summary.
>>
>> On Fri, Apr 28, 2017 at 2:51 PM, Navnath Gadakh <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find the patch for OS compatability issue of
> When testing on Mac, the testsuite never exits with this patch applied. It
> just hangs after printing the result summary.
>
> On Fri, Apr 28, 2017 at 2:51 PM, Navnath Gadakh <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> Please f
Hi
When testing on Mac, the testsuite never exits with this patch applied. It
just hangs after printing the result summary.
On Fri, Apr 28, 2017 at 2:51 PM, Navnath Gadakh <
[email protected]> wrote:
> Hi Dave,
>
> Please find the patch for OS compatabilit
Thanks, applied.
On Thu, Apr 27, 2017 at 10:22 PM, Sarah McAlear wrote:
> Hi Hackers!
>
> We realized that the feature tests and unit tests were using the same
> server, which was causing some flakiness when running the tests. This patch
> renames the server for the feature tests.
>
> Thanks!
>
Use a different server name for unit vs. feature tests to avoid some observed
conflicts.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4acecfa59a650369f14e1f61db8816e4eb13718a
Author: Sarah McAlear
Modified Files
--
web/regress
Hi Dave,
Please find the patch for OS compatability issue of test-suite.
*Code Changes:*
1. Minor code changes done related to os module in
*pgadmin4/web/regression/feature_utils/app_starter.py*
2. Code added in
pgadmin4/*web/pgadmin/utils/tests
Hi Hackers!
We realized that the feature tests and unit tests were using the same
server, which was causing some flakiness when running the tests. This patch
renames the server for the feature tests.
Thanks!
Joao & Sarah
0001-Change-the-name-of-the-Server-created-for-Feature-te.patch
Descriptio
Update test requirements for the latest rev of Chrome.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3eb92f7ea3abf3c6cb21d6f1dc391a300095026c
Author: Joao Pedro De Almeida Pereira
Modified Files
--
web/regression
he function name addSuccess does not match the styling of the code,
>>>> it should be add_success
>>>
>>> Done.
>>>>
>>>> Suggestions:
>>>> - The definition of the class_name (run_tests.py, line 229) variable
>>>> looks the same as
Include passed test results in the JSON output from the regression tests.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62716c4193c4434b002682126b634b29d70d1870
Author: Navnath Gadakh
Modified Files
--
.../sql/tests
> Suggestions:
>>> - The definition of the class_name (run_tests.py, line 229) variable
>>> looks the same as in the if statements below and could be extracted into a
>>> function to avoid repeating the same code.
>>>
>> Done.
>>
>>> - In the same fu
it
>> should be add_success
>>
> Done.
>
>> Suggestions:
>> - The definition of the class_name (run_tests.py, line 229) variable
>> looks the same as in the if statements below and could be extracted into a
>> function to avoid repeating the same code.
>>
extracted into a
> function to avoid repeating the same code.
>
Done.
> - In the same function when we are updating error/failure/skip test
> results the code looks pretty similar and can also be extracted into a
> function
>
Done.
@Dave, Please find the attached patch with nec
function when we are updating error/failure/skip test results
the code looks pretty similar and can also be extracted into a function
Thanks
Joao & Sarah
On Fri, Apr 7, 2017 at 10:15 AM, Navnath Gadakh <
[email protected]> wrote:
> Hi Dave,
>
>
>
Hi Dave,
Please find the revised patch for test result enhancement, which
include code to write passed test cases into the JSON file along with
skipped and failed.
On Tue, Apr 4, 2017 at 11:30 AM, Navnath Gadakh <
[email protected]> wrote:
>
Swap entries in karma.conf so test-main.js is matched first, per suggestion
from Atira to fix the failing Jasmine tests.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fcc122f29015983cca0f29ae074ec4951be8006b
Modified Files
Hi Dave,
Please find the revised patch for test result enhancement.
What's in the patch:
1. The test result summary will store in JSON file.
2. Removed some redundant code from regression/test_utils.py
3. Added the scenario names for feature tests.
4. To print test scenario names in f
Hi Akshay,
Please find the revised patch for test result enhancement.
*What's in the patch:*
1. The test result summary will store in JSON file.
2. Removed some redundant code from *regression/test_utils.py*
*3. A*dded the scenario names for feature tests.
4. To print test scenario nam
Include translation message catalogs in CI build/test runs.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a1bb8863a8759263636b0b8aa77ad462f3ce4d4
Modified Files
--
ci/ci_runner.sh | 1 +
1 file changed, 1 insertion(+)
--
Sent
Make sure each build/test starts in the correct directory.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac1637f281d320ef727c23eef135d332ee6eb8cd
Modified Files
--
ci/build_docs.sh| 3 ++-
ci/build_pip_wheel.sh | 3
(pgadmin.feature_tests.connect_to_server_feature_test.ConnectsToServerFeatureTest)
Test database connection which can be created from the UI
--
Traceback (most recent call last):
File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/base_feature_test.py"
Hi Dave,
Please find the revised patch for test result enhancement.
*What's in the patch:*
1. The test result summary will store in JSON file.
2. Removed some redundant code from *regression/test_utils.py*
*3. A*dded the scenario names for feature tests.
4. To print test scenario nam
>> >> >> Ctrl+C.
>> >>
>> >> The above is still a problem. In fact, not only do I have to hit
>> >> Ctrl+C, but then the browser prompts me to check I really do want to
>> >> exit.
>> >>
>> >> There'
to
> >> exit.
> >>
> >> There's also another problem that just showed up. I got the following
> >> failure on PG 9.4 (due to a known intermittent bug that Ashesh and
> >> Tira@Pivotal are working on). Note how it's not reporte
>
>
> Maybe - I'd need to see a viable patch with minimal impact first though.
Sure, makes sense.
That'll only work to a point. What happens if the user installs a
> plugin to get some additional functionality? We still need the ability
> to ensure code can be added to an existing installation.
On Mon, Mar 27, 2017 at 12:05 PM, Atira Odhner wrote:
>> A change as large as moving to React will be for v2.x, not v1.x, so we
>> cannot really wait unless we want to write off the feature tests as
>> unusable for the forseeable future.
>
>
> I don't think we should wait on moving the entire code
>
> A change as large as moving to React will be for v2.x, not v1.x, so we
> cannot really wait unless we want to write off the feature tests as
> unusable for the forseeable future.
I don't think we should wait on moving the entire codebase to react before
releasing features that use it. React a
On Mon, Mar 27, 2017 at 11:47 AM, Atira Odhner wrote:
>>
>> Tira's various patches all seem to be flakey :-(:
>
>
> Yes, that's because the way it was working before was to arbitrarily wait a
> full second. My intent with the patches was not to apply them to the code,
> but to demonstrate that the
we still need to get the feature tests
> working reliably ASAP (Murtuza is working on some more at the moment).
> Ashesh, please replace the 1 char variable names with something more
> meaningful as a first step.
>
> Would it help to get the two of you on a call to try to figure t
do I have to hit
>> Ctrl+C, but then the browser prompts me to check I really do want to
>> exit.
>>
>> There's also another problem that just showed up. I got the following
>> failure on PG 9.4 (due to a known intermittent bug that Ashesh and
>> Tira@Pivotal a
ollowing
> failure on PG 9.4 (due to a known intermittent bug that Ashesh and
> Tira@Pivotal are working on). Note how it's not reported in the
> summary (or the JSON output):
>
I found the issue, In the feature tests we need to add a scenario name for
each test case. the purpose of
he moment).
Ashesh, please replace the 1 char variable names with something more
meaningful as a first step.
Would it help to get the two of you on a call to try to figure this out and
agree on a solution?
Thanks.
On Wednesday, March 22, 2017, Atira Odhner wrote:
> Hi Ashesh,
>
>
>>
t;/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/support/wait.py",
line 80, in until
raise TimeoutException(message, screen, stacktrace)
TimeoutException: Message: Timed out waiting for elem
Hi Dave,
Please find the revised patch.
On Wed, Mar 22, 2017 at 5:09 PM, Dave Page wrote:
> Hi
>
> On Wed, Mar 22, 2017 at 6:03 AM, Navnath Gadakh
> wrote:
> > Hi Dave,
> >
> >Please find the patch for test result enhancement.
> > What&#x
Replace the template selection feature test with one that tests table DDL
generation (which also covers template selection).
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe9bc379c7d03c9dee632fb7c1a2ac2eef315371
Author: Atira Odhner
Hi Ashesh,
> First - let me try to explain the problem with the failure in the
>>> feature test.
>>> We do not load all the javascript libraries, when starting the pgAdmin 4
>>> (i.e. the loading the browser/index.html).
>>> But - load them only when f
On Wed, Mar 22, 2017 at 7:23 PM, Atira Odhner wrote:
> First - let me try to explain the problem with the failure in the
>> feature test.
>> We do not load all the javascript libraries, when starting the pgAdmin 4
>> (i.e. the loading the browser/index.html).
>> But
>
> First - let me try to explain the problem with the failure in the
> feature test.
> We do not load all the javascript libraries, when starting the pgAdmin 4
> (i.e. the loading the browser/index.html).
> But - load them only when first tree-item of certain type is added.
Hi
On Wed, Mar 22, 2017 at 6:03 AM, Navnath Gadakh
wrote:
> Hi Dave,
>
>Please find the patch for test result enhancement.
> What's in the patch:
> 1. The test result summary will store in JSON file.
> 2. Removed some redundant code from regression/test_util
vior, and speeds up the polling.
>>>
>>> Ashesh, can you explain why you are setting the text on the spinner
>>> after hiding it, or why you are hiding it rather than removing it?
>>>
>> First - let me try to explain the problem with the failure in the featu
Hi Dave,
Please find the patch for test result enhancement.
*What's in the patch:*
1. The test result summary will store in JSON file.
2. Removed some redundant code from *regression/test_utils.py*
3. To print test scenario names in failed and skipped test cases, I ove
Here is a new patchset that instead hides the spinner when the acitree has
been initialized. On average, the spinner seems to disappear about 2
seconds sooner, and I haven't seen flakiness with these changes yet.
Tira & Joao
On Mon, Mar 20, 2017 at 4:17 PM, Atira Odhner wrote:
> Note that this
Note that this patch makes the problem of the tree not having loaded worse,
because it only waits for js modules to load rather than arbitrarily
waiting 900ms.
On Mon, Mar 20, 2017 at 3:17 PM, Atira Odhner wrote:
> Hi Ashesh,
>
> *Regarding your second patch:*
>
> It looks like your second patch
Ooops, my bad. Sorry about that - it's fixed now.
On Mon, Mar 20, 2017 at 2:01 PM, Joao Pedro De Almeida Pereira
wrote:
> Hello Hackers,
> We noticed that some Python comments were added to the fake_translations.js
> file. We flushed out this issue running the Jasmine tests by doing(do not
> forg
t; I'll leave you and Tira to figure this one out if you don't mind. My
> plate is kinda full at the moment.
>
> I will note though that neither blocking or potential failures are
> desirable.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pg
Hello Hackers,
We noticed that some Python comments were added to the fake_translations.js
file. We flushed out this issue running the Jasmine tests by doing(do not
forget to install node dependencies instructions in web/regression/README):
cd $PGADMIN4_SRC/web/
karma start
This patch corrects t
On Mon, Mar 20, 2017 at 10:24 AM, Ashesh Vashi
wrote:
> On Fri, Mar 17, 2017 at 8:35 PM, Sarah McAlear wrote:
>>
>> Hello,
>>
>> We agree that we should keep an eye on this and the failing feature tests.
>> Our current story touches part of this code, but we won't go into changing
>> the library
t;> I am thinking of using the 'require' function within that function, when
>>> that node type is not present in the application at that point of time.
>>> Though - I am still not sure, wheather 'require' works that way, or not.
>>>
>>> --
er 'require' works that way, or not.
>>
>> -- Thanks, Ashesh
>>
>> Tira
>>
>> On Thu, Mar 16, 2017, 6:49 AM Dave Page wrote:
>>
>>> On Thu, Mar 16, 2017 at 10:39 AM, Ashesh Vashi <
>>> [email protected]> wrote:
>>
Remove test related files from the mac appbundle.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6abb906b2041a76e18157082bbcc9c20f7d136dd
Modified Files
--
pkg/mac/build.sh | 12 ++--
1 file changed, 10 insertions(+), 2
ype is not present in the application at that point of time.
> Though - I am still not sure, wheather 'require' works that way, or not.
>
> -- Thanks, Ashesh
>
> Tira
>
> On Thu, Mar 16, 2017, 6:49 AM Dave Page wrote:
>
>> On Thu, Mar 16, 2017 at 10:39
hu, Mar 16, 2017, 6:49 AM Dave Page wrote:
> On Thu, Mar 16, 2017 at 10:39 AM, Ashesh Vashi <
> [email protected]> wrote:
>
> On Thu, Mar 16, 2017 at 3:55 PM, Dave Page wrote:
>
> Hi Ashesh,
>
> A common theme is emerging from some of the feature test r
On Thu, Mar 16, 2017, 6:49 AM Dave Page wrote:
> On Thu, Mar 16, 2017 at 10:39 AM, Ashesh Vashi <
> [email protected]> wrote:
>
> On Thu, Mar 16, 2017 at 3:55 PM, Dave Page wrote:
>
> Hi Ashesh,
>
> A common theme is emerging from some of the feature tes
On Thu, Mar 16, 2017 at 10:39 AM, Ashesh Vashi <
[email protected]> wrote:
> On Thu, Mar 16, 2017 at 3:55 PM, Dave Page wrote:
>
>> Hi Ashesh,
>>
>> A common theme is emerging from some of the feature test regression
>> failures on the Jen
On Thu, Mar 16, 2017 at 3:55 PM, Dave Page wrote:
> Hi Ashesh,
>
> A common theme is emerging from some of the feature test regression
> failures on the Jenkins server. Please see:
>
> https://jenkins.pgadmin.org/job/pgadmin4-master-python27/
> ws/web/regression/screenshot
Hi Ashesh,
A common theme is emerging from some of the feature test regression
failures on the Jenkins server. Please see:
https://jenkins.pgadmin.org/job/pgadmin4-master-python27/ws/web/regression/screenshots/EDB_Postgres_AS_9.3/ConnectsToServerFeatureTest-2017.03.16_10.09.18-Python-2.7.13.png
Update test requirements to include a version of Selenium that supports Chrome
57, and the chromedriver installer.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6ad6bf5aab212c19b94b7ac353598dd59d3b7ea3
Author: Joao Pedro De Almeida Pereira
Add Jasmine test framework for JS testing.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f84156dc6589304e56f202151bf9199c6f7e985
Author: Atira Odhner
Modified Files
--
.gitignore | 1 +
karma.conf.js
Hi
On Fri, Mar 3, 2017 at 6:41 PM, Atira Odhner wrote:
> Hey Dave,
>
> We're not able to reproduce that issue over here. Any chance you could debug
> it?
Per the discussion at
https://github.com/seleniumhq/selenium-google-code-issue-archive/issues/3378,
it looks like we're not closing the driver
o Pedro De Almeida Pereira
> > wrote:
> >> Hi,
> >> We adjusted the patches to correct the issues that you mentioned
> >>
> >> Improves screenshots and reduces test flakiness
> >
> > Hmm, was that the 0.5 second sleep? I hate doing that, but some
On Fri, Mar 3, 2017 at 1:57 PM, Dave Page wrote:
> Hi
>
> On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira
> wrote:
>> Hi,
>> We adjusted the patches to correct the issues that you mentioned
>>
>> Improves screenshots and reduces test flakin
Hi
On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira
wrote:
> Hi,
> We adjusted the patches to correct the issues that you mentioned
>
> Improves screenshots and reduces test flakiness
Hmm, was that the 0.5 second sleep? I hate doing that, but sometimes
it's
ne - the further optimisation would be to
think about test groups, where tests can be safely undertaken in
sequence without a reset in-between. I think it would be reasonable in
such cases to abort the group if a single test fails, thus potentially
leaving the UI in an unknown state. That would potent
Hi,
We adjusted the patches to correct the issues that you mentioned
Improves screenshots and reduces test flakiness
- rename screenshot files to add python version
- put screenshots into separate pg version folders
Thanks
Joao & Tira & Sarah
On Thu, Mar 2, 2017 at 5:15 AM, D
; >> On my top-of-the-range-last-year Mac, startup takes about 14 seconds
> >> per test - that's from the start of the test, until the point at which
> >> the "Loading pgAdmin..." spinner vanishes.
> >
> >
> > That includes the time it takes to lo
1 - 100 of 234 matches
Mail list logo
