Re: [pgadmin-hackers] [pgadmin-support] Aborted viewing operation

2003-09-24 Thread Dave Page
Thanks Hiroshi, patch applied. Regards, Dave > -Original Message- > From: Hiroshi Saito [mailto:[EMAIL PROTECTED] > Sent: 24 September 2003 02:40 > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED]; > [EMAIL PROTECTED]; Dave Page > Subject: Re: [pgadmin-support] Aborted viewing operation >

Re: [pgadmin-hackers] [pgadmin-support] Aborted viewing operation

2003-09-24 Thread Andreas Pflug
The fix is no fix but a bug and needs to be reverted; I removed it from CVS. PQfnumber is a libpq API func, not SQL and thus doesn't need quoting. Regards, Andreas Dave Page wrote: Thanks Hiroshi, patch applied. Regards, Dave -Original Message- From: Hiroshi Saito [mailto:[EMAIL PROTE

Re: [pgadmin-hackers] pgRule_patch

2003-09-24 Thread Dave Page
Hi Hiroshi, Andreas is re-working this patch to make it a little more beautiful :-) Thanks, Dave > -Original Message- > From: Hiroshi Saito [mailto:[EMAIL PROTECTED] > Sent: 19 September 2003 19:33 > To: Dave Page > Cc: [EMAIL PROTECTED] > Subject: pgRule_patch > > > Hi Dave. > > Thi

Re: [pgadmin-hackers] pgRule_patch

2003-09-24 Thread Andreas Pflug
Dave Page wrote: Hi Hiroshi, Andreas is re-working this patch to make it a little more beautiful :-) Already done; it's merely a 4-liner in pgRule.cpp. Regards, Andreas ---(end of broadcast)--- TIP 2: you can get off all lists at once with the u

Re: [pgadmin-hackers] [pgadmin-support] Aborted viewing operation

2003-09-24 Thread Dave Page
Sorry, minor brain fart - that did cross my mind when I applied it but for some reason then thought it was right! Regards, Dave > -Original Message- > From: Andreas Pflug [mailto:[EMAIL PROTECTED] > Sent: 24 September 2003 16:03 > To: Dave Page > Cc: Hiroshi Saito; [EMAIL PROTECTED] > Su

Re: [pgadmin-hackers] [pgadmin-support] Aborted viewing operation

2003-09-24 Thread Hiroshi Saito
Why? PQfnumber is improper if QUOTE isn't done. See libpq. It disposes of all tolowers. Regards, Hiroshi Saito - Original Message - From: "Dave Page" <[EMAIL PROTECTED]> To: "Andreas Pflug" <[EMAIL PROTECTED]> Cc: "Hiroshi Saito" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Thursday, S

Re: [pgadmin-hackers] pgRule_patch

2003-09-24 Thread Hiroshi Saito
> Dave Page wrote: > > >Hi Hiroshi, > > > >Andreas is re-working this patch to make it a little more beautiful :-) > > > Already done; it's merely a 4-liner in pgRule.cpp. Thanks. Indeed. In other words, a lot of efforts are necessary for me.:) Regards, Hiroshi Saito --

Re: [pgadmin-hackers] [pgadmin-support] Aborted viewing operation

2003-09-24 Thread Andreas Pflug
Hiroshi Saito wrote: Why? PQfnumber is improper if QUOTE isn't done. See libpq. It disposes of all tolowers. Seems that Hiroshi is right and we have to turn back the turning back :-) Doc doesn't say anything about it, but apparently libpq really tolowers the col name. There's also a fix for vi