[pgadmin-hackers] SVN Commit by dpage: r7575 - in branches/REL-1_6_0_PATCHES/pgadmin3/docs/en_US: . pg

2009-01-30 Thread svn
Author: dpage Date: 2009-01-30 09:47:09 + (Fri, 30 Jan 2009) New Revision: 7575 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7575&view=rev Log: Update docs for 8.2.12 Added: branches/REL-1_6_0_PATCHES/pgadmin3/docs/en_US/pg/release-7-4-24.html branches/REL-1_6_0

Re: [pgadmin-hackers] PATCH: Column Level Privileges

2009-01-30 Thread Dave Page
On Thu, Jan 29, 2009 at 5:17 PM, Ashesh Vashi wrote: > Hi All, > > Please find the patch for Column Level Privileges support. > I have also attached some of the test-cases for it. Hi Ashesh, Couple of minor issues/questions: - Why didn't you derive the dialog from dlgSecurityProperty? I assume

Re: [pgadmin-hackers] PATCH: Column Level Privileges

2009-01-30 Thread Ashesh Vashi
Hi Dave, Couple of minor issues/questions: - Why didn't you derive the dialog from dlgSecurityProperty? I assume it would have been too messy as it's already derived from dlgTypeProperty? dlgSecurityProperty and dlgTypeProperty both are derived from dlgPropery. If we derive the dlgColumn from b

Re: [pgadmin-hackers] PATCH: Column Level Privileges

2009-01-30 Thread Ashesh Vashi
Hi Dave, Dave Page wrote: - As a general rule, we disable controls not relevant to a particular version of Postgres. We should do the same with this tab - disable the controls rather than hide them on servers < 8.4. Done - Can we lose the comment above the column permissions in the reverse eng