Re: [pgadmin-hackers] Redundant statements

2010-04-29 Thread Erwin Brandstetter
On 28.04.2010 19:16, brandstet...@falter.at wrote: Aloha! I am testing Guillaume's version of pgadmin3.exe from Apr. 17. The fix below is included and it seems to fix the problem just fine. However, as a side effect (?) there is now a redundant statement for each and every column: ALTER

Re: [pgadmin-hackers] Redundant statements

2010-04-29 Thread Guillaume Lelarge
Sorry for not answering sooner. Le 29/04/2010 14:15, Erwin Brandstetter a écrit : > On 28.04.2010 19:16, brandstet...@falter.at wrote: >> Aloha! >> >> I am testing Guillaume's version of pgadmin3.exe from Apr. 17. >> >> The fix below is included and it seems to fix the problem just fine. >> Howeve

Re: [pgadmin-hackers] PATCH(WIP): Printing Support And Save GQB/Explain as an image

2010-04-29 Thread Ashesh Vashi
Hi Dave, As discussed, I am not confident about the Printing support on Mac OSX. It is working well on other platforms. In fact, Print Preview is also working good on OSX. But, It gives arbitrary results for the printing.. (The main feature of this patch.) :-( I will need some more time investiga

[pgadmin-hackers] PATCH: Debugger crashing on OSX

2010-04-29 Thread Ashesh Vashi
Hi Dave, As you found the segment fault on OSX related to debugger. In dlgDirectDbg::OnTargetComplete(), It waits for the function this->Show(true) for completion, and "this" pointer will not be available on cancellation, and hence It is crashing on next line. ie. this->SetFocus(); On removing

Re: [pgadmin-hackers] Redundant statements

2010-04-29 Thread Erwin Brandstetter
On 29.04.2010 15:21, guilla...@lelarge.info wrote: Sorry for not answering sooner. No problem, the thread is old, but I just posted that yesterday. :) Le 29/04/2010 14:15, Erwin Brandstetter a écrit : On 28.04.2010 19:16, brandstet...@falter.at wrote: Aloha! I am testing Gui

[pgadmin-hackers] SVN Commit by guillaume: r8308 - trunk/www/download

2010-04-29 Thread svn
Author: guillaume Date: 2010-04-29 16:33:34 +0100 (Thu, 29 Apr 2010) New Revision: 8308 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8308&view=rev Log: Update Debian's notes for download. Modified: trunk/www/download/debian.php -- Sent via pgadmin-hackers mailing li

[pgadmin-hackers] SVN Commit by guillaume: r8309 - in trunk/www/locale: cs_CZ/LC_MESSAGES fr_FR/LC_MESSAGES zh_CN/LC_MESSAGES

2010-04-29 Thread svn
Author: guillaume Date: 2010-04-29 16:34:22 +0100 (Thu, 29 Apr 2010) New Revision: 8309 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8309&view=rev Log: Automatic stringmerge using merge script. Modified: trunk/www/locale/cs_CZ/LC_MESSAGES/pgadmin3_website.mo trunk/w

[pgadmin-hackers] SVN Commit by guillaume: r8310 - trunk/www/locale

2010-04-29 Thread svn
Author: guillaume Date: 2010-04-29 16:34:45 +0100 (Thu, 29 Apr 2010) New Revision: 8310 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8310&view=rev Log: Update pot file. Modified: trunk/www/locale/pgadmin3_website.pot -- Sent via pgadmin-hackers mailing list (pgadmin

[pgadmin-hackers] SVN Commit by guillaume: r8311 - trunk/www/locale/fr_FR/LC_MESSAGES

2010-04-29 Thread svn
Author: guillaume Date: 2010-04-29 16:37:06 +0100 (Thu, 29 Apr 2010) New Revision: 8311 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8311&view=rev Log: Update website's french translation. Modified: trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.mo trunk/www/l

[pgadmin-hackers] [pgAdmin III] #176: Reduce "SET STORAGE" noise in SQL pannel

2010-04-29 Thread pgAdmin Trac
#176: Reduce "SET STORAGE" noise in SQL pannel ---+ Reporter: brsa | Owner: dpage Type: bug| Status: new Priority: minor | Milestone: Component: pgad

Re: [pgadmin-hackers] Redundant statements

2010-04-29 Thread Guillaume Lelarge
Le 29/04/2010 17:28, Erwin Brandstetter a écrit : > On 29.04.2010 15:21, guilla...@lelarge.info wrote: >> Sorry for not answering sooner. >> > > No problem, the thread is old, but I just posted that yesterday. :) > > >> Le 29/04/2010 14:15, Erwin Brandstetter a écrit : >> >>> On 28.04.201

Re: [pgadmin-hackers] [pgAdmin III] #176: Reduce "SET STORAGE" noise in SQL pannel

2010-04-29 Thread pgAdmin Trac
#176: Reduce "SET STORAGE" noise in SQL pannel ---+ Reporter: brsa | Owner: gleu Type: bug| Status: assigned Priority: minor | Milestone: Compone

[pgadmin-hackers] SVN Commit by guillaume: r8312 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/include/schema pgadmin/schema

2010-04-29 Thread svn
Author: guillaume Date: 2010-04-29 17:45:30 +0100 (Thu, 29 Apr 2010) New Revision: 8312 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8312&view=rev Log: Fix to only show Storage value if the value is different from the type's default value, per a suggestion from Erwin Brand

[pgadmin-hackers] SVN Commit by guillaume: r8313 - in trunk/pgadmin3: . pgadmin/include/schema pgadmin/schema

2010-04-29 Thread svn
Author: guillaume Date: 2010-04-29 17:46:48 +0100 (Thu, 29 Apr 2010) New Revision: 8313 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8313&view=rev Log: Fix to only show Storage value if the value is different from the type's default value, per a suggestion from Erwin Brand

Re: [pgadmin-hackers] [pgAdmin III] #176: Reduce "SET STORAGE" noise in SQL pannel

2010-04-29 Thread pgAdmin Trac
#176: Reduce "SET STORAGE" noise in SQL pannel --+- Reporter: brsa | Owner: gleu Type: bug | Status: closed Priority: minor| Milestone: 1.10.3 Compon

Re: [pgadmin-hackers] Redundant statements

2010-04-29 Thread Guillaume Lelarge
Le 29/04/2010 17:50, Guillaume Lelarge a écrit : > Le 29/04/2010 17:28, Erwin Brandstetter a écrit : >> On 29.04.2010 15:21, guilla...@lelarge.info wrote: > [...] What do you think of it? Should I create a ticket? >>> Well, I would like to have a better handling of the "SET STORAGE"

[pgadmin-hackers] SVN Commit by dpage: r8314 - in trunk/pgadmin3: . pgadmin/debugger

2010-04-29 Thread svn
Author: dpage Date: 2010-04-29 20:02:24 +0100 (Thu, 29 Apr 2010) New Revision: 8314 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8314&view=rev Log: Fix a crash bug seen when closing the debugger parameter dialog on OSX. Modified: trunk/pgadmin3/CHANGELOG trunk/pgadm

[pgadmin-hackers] SVN Commit by dpage: r8315 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/debugger

2010-04-29 Thread svn
Author: dpage Date: 2010-04-29 20:07:28 +0100 (Thu, 29 Apr 2010) New Revision: 8315 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8315&view=rev Log: Fix a crash bug seen when closing the debugger parameter dialog on OSX. Modified: branches/REL-1_10_0_PATCHES/pgadmin3/CH

Re: [pgadmin-hackers] PATCH: Debugger crashing on OSX

2010-04-29 Thread Dave Page
On Thu, Apr 29, 2010 at 3:19 PM, Ashesh Vashi wrote: > Hi Dave, > As you found the segment fault on OSX  related to debugger. > In dlgDirectDbg::OnTargetComplete(), It waits for the function > this->Show(true) for completion, and "this" pointer will not be available on > cancellation,  and hence I

[pgadmin-hackers] SVN Commit by dpage: r8316 - in trunk/pgadmin3: . pgadmin pgadmin/ctl pgadmin/frm pgadmin/gqb pgadmin/include/ctl pgadmin/include/frm pgadmin/include/gqb

2010-04-29 Thread svn
Author: dpage Date: 2010-04-29 20:32:20 +0100 (Thu, 29 Apr 2010) New Revision: 8316 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8316&view=rev Log: Add support for saving the graphical explain and query builder canvases as images. [Ashesh Vashi] Modified: trunk/pgadmi

[pgadmin-hackers] SVN Commit by dpage: r8317 - trunk/pgadmin3/pgadmin

2010-04-29 Thread svn
Author: dpage Date: 2010-04-29 20:34:40 +0100 (Thu, 29 Apr 2010) New Revision: 8317 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8317&view=rev Log: Remove dead code. Modified: trunk/pgadmin3/pgadmin/pgAdmin3.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hacke

Re: [pgadmin-hackers] PATCH(WIP): Printing Support And Save GQB/Explain as an image

2010-04-29 Thread Dave Page
On Thu, Apr 29, 2010 at 2:25 PM, Ashesh Vashi wrote: > Hi Dave, > As discussed, I am not confident about the Printing support on Mac OSX. > It is working well on other platforms. In fact, Print Preview is also > working good on OSX. But, It gives arbitrary results for the printing.. (The > main fe

[pgadmin-hackers] SVN Commit by guillaume: r8318 - in trunk/pgadmin3/i18n: af_ZA ar_SA bg_BG ca_ES cs_CZ da_DK de_CH de_DE el_GR es_ES fa_IR fi_FI fr_FR gl_ES gu_IN hi_IN hr_HR hu_HU id_ID is_IS it_IT

2010-04-29 Thread svn
Author: guillaume Date: 2010-04-29 21:05:50 +0100 (Thu, 29 Apr 2010) New Revision: 8318 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8318&view=rev Log: Automatic merge using stringmerge script. Modified: trunk/pgadmin3/i18n/af_ZA/pgadmin3.po trunk/pgadmin3/i18n/ar_S

[pgadmin-hackers] SVN Commit by dpage: r8319 - trunk/pgadmin3/pgadmin/frm

2010-04-29 Thread svn
Author: dpage Date: 2010-04-29 21:51:04 +0100 (Thu, 29 Apr 2010) New Revision: 8319 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8319&view=rev Log: Fix some warnings. Modified: trunk/pgadmin3/pgadmin/frm/frmQuery.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-

[pgadmin-hackers] SVN Commit by guillaume: r8320 - trunk/pgadmin3/i18n/fr_FR

2010-04-29 Thread svn
Author: guillaume Date: 2010-04-29 22:46:37 +0100 (Thu, 29 Apr 2010) New Revision: 8320 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8320&view=rev Log: Update of the french translation. Modified: trunk/pgadmin3/i18n/fr_FR/pgadmin3.mo trunk/pgadmin3/i18n/fr_FR/pgadm

Re: [pgadmin-hackers] Redundant statements

2010-04-29 Thread Erwin Brandstetter
On 29.04.2010 18:48, guilla...@lelarge.info wrote: Le 29/04/2010 17:50, Guillaume Lelarge a écrit : Le 29/04/2010 17:28, Erwin Brandstetter a écrit : On 29.04.2010 15:21, guilla...@lelarge.info wrote: [...] What do you think of it? Should I create a ticket?

Re: [pgadmin-hackers] [pgAdmin III] #14: Save graphical explain output

2010-04-29 Thread pgAdmin Trac
#14: Save graphical explain output --+- Reporter: mha | Owner: ashesh.vashi Type: feature | Status: closed Priority: minor| Milestone: 1.12 Component: pgadmin | Versio

Re: [pgadmin-hackers] Redundant statements

2010-04-29 Thread Guillaume Lelarge
Le 30/04/2010 00:35, Erwin Brandstetter a écrit : > On 29.04.2010 18:48, guilla...@lelarge.info wrote: >> Le 29/04/2010 17:50, Guillaume Lelarge a écrit : >> >>> Le 29/04/2010 17:28, Erwin Brandstetter a écrit : >>> On 29.04.2010 15:21, guilla...@lelarge.info wrote: >>> [.

Re: [pgadmin-hackers] Redundant statements

2010-04-29 Thread Erwin Brandstetter
On 30.04.2010 00:40, guilla...@lelarge.info wrote: Le 30/04/2010 00:35, Erwin Brandstetter a écrit : On 29.04.2010 18:48, guilla...@lelarge.info wrote: Le 29/04/2010 17:50, Guillaume Lelarge a écrit : Le 29/04/2010 17:28, Erwin Brandstetter a écrit : On 29.04.201