Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Guillaume Lelarge
On Mon, 2011-07-04 at 23:42 +0200, Jasmin Dizdarevic wrote: > > > 2011/7/4 Guillaume Lelarge > On Mon, 2011-07-04 at 09:10 +0200, Guillaume Lelarge wrote: > > On Sun, 2011-07-03 at 23:39 +0200, Jasmin Dizdarevic wrote: > > > Could somebody review the patch and maybe commi

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 21:33 +0200, Jasmin Dizdarevic wrote: > Sure. > Thanks. I'm almost done, and ready to apply :) -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your su

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 8:35 PM, Guillaume Lelarge wrote: > On Tue, 2011-07-05 at 21:33 +0200, Jasmin Dizdarevic wrote: >> Sure. >> > > Thanks. I'm almost done, and ready to apply :) Looks like that dialogue needs some tweaking (status bar, button positioning - actually, we don't normally have clo

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Guillaume Lelarge
Hi Thom, On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: > [...] > I noticed that objects which can be moved to different schemas can't > be moved in PgAdmin, so I looked to see if there was any request to > have this implemented, and found this ticket: > http://code.pgadmin.org/trac/ticket/5

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 8:47 PM, Guillaume Lelarge wrote: > > Thanks a lot for your work. This patch was something I was waiting for. A few weeks back I had to talk Thom into posting a 2 line fix. I'm beginning to think I may have unleashed some sort of rampant patch beast... > BTW, are you going

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 20:42 +0100, Dave Page wrote: > On Tue, Jul 5, 2011 at 8:35 PM, Guillaume Lelarge > wrote: > > On Tue, 2011-07-05 at 21:33 +0200, Jasmin Dizdarevic wrote: > >> Sure. > >> > > > > Thanks. I'm almost done, and ready to apply :) > > Looks like that dialogue needs some tweaking

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread jasmin . dizdarevic
Is a status bar really neccessary? There is just one message to be displayed ;) --Originalnachricht-- Von: Guillaume Lelarge An:Dave Page Cc:Jasmin Dizdarevic Cc:pgadmin-hackers@postgresql.org Betreff: Re: Fwd: [pgadmin-hackers] Discussion - Search Objects Gesendet: 5. Jul. 2011 21:50 On

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 20:51 +0100, Dave Page wrote: > On Tue, Jul 5, 2011 at 8:47 PM, Guillaume Lelarge > wrote: > > > > Thanks a lot for your work. This patch was something I was waiting for. > > A few weeks back I had to talk Thom into posting a 2 line fix. I'm > beginning to think I may have u

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 8:50 PM, Guillaume Lelarge wrote: > On Tue, 2011-07-05 at 20:42 +0100, Dave Page wrote: >> On Tue, Jul 5, 2011 at 8:35 PM, Guillaume Lelarge >> wrote: >> > On Tue, 2011-07-05 at 21:33 +0200, Jasmin Dizdarevic wrote: >> >> Sure. >> >> >> > >> > Thanks. I'm almost done, and r

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 19:54 +, jasmin.dizdare...@gmail.com wrote: > Is a status bar really neccessary? > There is just one message to be displayed ;) > It's better to keep the UI consistent. And it's not a huge work. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.co

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 8:54 PM, wrote: > Is a status bar really neccessary? > There is just one message to be displayed ;) It maintains consistency of look and feel across the app. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com Th

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 8:57 PM, Guillaume Lelarge wrote: > On Tue, 2011-07-05 at 20:51 +0100, Dave Page wrote: >> On Tue, Jul 5, 2011 at 8:47 PM, Guillaume Lelarge >> wrote: >> > >> > Thanks a lot for your work. This patch was something I was waiting for. >> >> A few weeks back I had to talk Thom

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread jasmin . dizdarevic
Are you siamese twins? :) --Originalnachricht-- Von: Dave Page An:jasmin.dizdare...@gmail.com Cc:Guillaume Lelarge Cc:pgadmin-hackers@postgresql.org Betreff: Re: Re: Fwd: [pgadmin-hackers] Discussion - Search Objects Gesendet: 5. Jul. 2011 22:00 On Tue, Jul 5, 2011 at 8:54 PM, wrote: > I

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 20:47, Guillaume Lelarge wrote: > Hi Thom, > > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: >> [...] >> I noticed that objects which can be moved to different schemas can't >> be moved in PgAdmin, so I looked to see if there was any request to >> have this implemented, and f

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 21:00 +0100, Dave Page wrote: > On Tue, Jul 5, 2011 at 8:54 PM, wrote: > > Is a status bar really neccessary? > > There is just one message to be displayed ;) > > It maintains consistency of look and feel across the app. > That's also what I replied. But I just noticed th

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 20:51, Dave Page wrote: > On Tue, Jul 5, 2011 at 8:47 PM, Guillaume Lelarge > wrote: >> >> Thanks a lot for your work. This patch was something I was waiting for. > > A few weeks back I had to talk Thom into posting a 2 line fix. I'm > beginning to think I may have unleashed some s

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 9:02 PM, wrote: > Are you siamese twins? :) That'd be a bit tricky - the worlds busiest shipping lane is between us. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 9:02 PM, Guillaume Lelarge wrote: > On Tue, 2011-07-05 at 21:00 +0100, Dave Page wrote: >> On Tue, Jul 5, 2011 at 8:54 PM,   wrote: >> > Is a status bar really neccessary? >> > There is just one message to be displayed ;) >> >> It maintains consistency of look and feel acros

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 21:01 +0100, Thom Brown wrote: > On 5 July 2011 20:47, Guillaume Lelarge wrote: > > Hi Thom, > > > > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: > >> [...] > >> I noticed that objects which can be moved to different schemas can't > >> be moved in PgAdmin, so I looked

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 21:05 +0100, Dave Page wrote: > On Tue, Jul 5, 2011 at 9:02 PM, Guillaume Lelarge > wrote: > > On Tue, 2011-07-05 at 21:00 +0100, Dave Page wrote: > >> On Tue, Jul 5, 2011 at 8:54 PM, wrote: > >> > Is a status bar really neccessary? > >> > There is just one message to be di

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Jasmin Dizdarevic
2011/7/5 Guillaume Lelarge > On Tue, 2011-07-05 at 21:01 +0100, Thom Brown wrote: > > On 5 July 2011 20:47, Guillaume Lelarge wrote: > > > Hi Thom, > > > > > > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: > > >> [...] > > >> I noticed that objects which can be moved to different schemas

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 21:14, Jasmin Dizdarevic wrote: >> > > Did you fix the issue with the refresh of the browser? (I can't check >> > > yet, I'm doing a last time compile of Jasmin's patch :) ) >> > >> > I got it refreshing the node in the original schema, but not the >> > destination one. >> > >> >> W

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 21:08, Guillaume Lelarge wrote: > On Tue, 2011-07-05 at 21:01 +0100, Thom Brown wrote: >> On 5 July 2011 20:47, Guillaume Lelarge wrote: >> > Hi Thom, >> > >> > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: >> >> [...] >> >> I noticed that objects which can be moved to diffe

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Jasmin Dizdarevic
Me too...it's quite hard to get in ;) GetNodePath returns a string representing an language dependent node path: Server Groups/localhost/Databases/myDb/Schemas/mySchema/Tables/myTable SetCurrentNodePath accpet the string node path and select's the desired object. During implementing search ob

Re: [pgadmin-hackers] Changing extension schema silently fails

2011-07-05 Thread Thom Brown
On 5 July 2011 21:23, Thom Brown wrote: > Hi, > > I'm using the latest head and I created the file_fdw extension, then > attempted to change its schema.  No error was returned, but it > remained in the same schema. > > I then dropped the extension and created it again specifying the new > schema,

[pgadmin-hackers] Changing extension schema silently fails

2011-07-05 Thread Thom Brown
Hi, I'm using the latest head and I created the file_fdw extension, then attempted to change its schema. No error was returned, but it remained in the same schema. I then dropped the extension and created it again specifying the new schema, and it is correctly assigned to that schema. Am I miss

[pgadmin-hackers] pgAdmin III commit: Add "Search Objects" dialog

2011-07-05 Thread Guillaume Lelarge
Add "Search Objects" dialog This dialog, available from the database contextual menu, helps users to find objects whose names match a specific pattern. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=38622ecbc08b565621c1204c48051487fc548100 Aut

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Guillaume Lelarge
On Tue, 2011-07-05 at 20:42 +0100, Dave Page wrote: > On Tue, Jul 5, 2011 at 8:35 PM, Guillaume Lelarge > wrote: > > On Tue, 2011-07-05 at 21:33 +0200, Jasmin Dizdarevic wrote: > >> Sure. > >> > > > > Thanks. I'm almost done, and ready to apply :) > > Looks like that dialogue needs some tweaking

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Jasmin Dizdarevic
Great that it's done. Thank you for beautification. 2011/7/5 Guillaume Lelarge > On Tue, 2011-07-05 at 20:42 +0100, Dave Page wrote: > > On Tue, Jul 5, 2011 at 8:35 PM, Guillaume Lelarge > > wrote: > > > On Tue, 2011-07-05 at 21:33 +0200, Jasmin Dizdarevic wrote: > > >> Sure. > > >> > > > > >

Re: Fwd: [pgadmin-hackers] Discussion - Search Objects

2011-07-05 Thread Dave Page
On Tue, Jul 5, 2011 at 10:06 PM, Guillaume Lelarge wrote: > On Tue, 2011-07-05 at 20:42 +0100, Dave Page wrote: >> On Tue, Jul 5, 2011 at 8:35 PM, Guillaume Lelarge >> wrote: >> > On Tue, 2011-07-05 at 21:33 +0200, Jasmin Dizdarevic wrote: >> >> Sure. >> >> >> > >> > Thanks. I'm almost done, and

[pgadmin-hackers] pgAdmin III commit: Update xrcDialogs.cpp, and "make syle"

2011-07-05 Thread Guillaume Lelarge
Update xrcDialogs.cpp, and "make syle" Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=487c52ee62fb22ccf2c8a478a5f480a7f3f79ac6 Modified Files -- pgadmin/dlg/dlgSearchObject.cpp |8 +- pgadmin/dlg/dlgSequence.cpp |4 +- pg