Re: [pgadmin-hackers] Different look and feel of the Documentation on Windows and Linux

2012-09-04 Thread Dave Page
On Tue, Sep 4, 2012 at 9:56 AM, Akshay Joshi wrote: > Hi > > I have observed there is a difference in the look and feel of pgAdmin3 > documentation on Windows and Linux. As we have .chm file on windows and .hhp > file on Linux. > Attached is the screenshots. Is it the expected behavior? Yeah. Unf

[pgadmin-hackers] pgAgent Database Name Limitation

2012-09-04 Thread Martin French
Hi all, I've come across an issue within pgAgent whereby it cannot/will not connect to a database where there is a space in the name. (I know that typically pgAgent should run within the postgres db to allow pgAdmin job management, however, this is a second pgAgent running with a specific tas

[pgadmin-hackers] Fixed help button crash

2012-09-04 Thread Akshay Joshi
Hi Dave I have fixed one crash which occurs when user clicks on help button of Options dialog. Attached is the patch. Please review it and if it looks good then can you please commit it. -- *Akshay Joshi Senior Software Engineer EnterpriseDB Corporation The Enterprise PostgreSQL Company Phone: +

Re: [pgadmin-hackers] pgAgent Database Name Limitation

2012-09-04 Thread Martin French
> > Hi all, > > I've come across an issue within pgAgent whereby it cannot/will not > connect to a database where there is a space in the name. > (I know that typically pgAgent should run within the postgres db to > allow pgAdmin job management, however, this is a second pgAgent > running wi

Re: [pgadmin-hackers] pgAgent Database Name Limitation

2012-09-04 Thread Dave Page
Hi On Tue, Sep 4, 2012 at 11:21 AM, Martin French wrote: >> >> Hi all, >> >> I've come across an issue within pgAgent whereby it cannot/will not >> connect to a database where there is a space in the name. >> (I know that typically pgAgent should run within the postgres db to >> allow pgAdmin job

Re: [pgadmin-hackers] pgAgent Database Name Limitation

2012-09-04 Thread Martin French
> > Hi all, > > > > I've come across an issue within pgAgent whereby it cannot/will not > > connect to a database where there is a space in the name. > > (I know that typically pgAgent should run within the postgres db to > > allow pgAdmin job management, however, this is a second pgAgent > >

[pgadmin-hackers] pgAdmin III commit: Fix a crash which occurs when user clicks on help b

2012-09-04 Thread Dave Page
Fix a crash which occurs when user clicks on help button of Options dialog. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=22aed23247bc924169c954add310adbcc436290c Author: Akshay Joshi Modified Files -- pgadmin/frm/frmOptions.cpp

[pgadmin-hackers] pgAdmin III commit: Fix a crash which occurs when user clicks on help b

2012-09-04 Thread Dave Page
Fix a crash which occurs when user clicks on help button of Options dialog. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bf2d585c5d085459adcac64c017d3b728c0ca62c Author: Akshay Joshi Modified Files -- pgadmin/frm/frm

Re: [pgadmin-hackers] Fixed help button crash

2012-09-04 Thread Dave Page
Thanks, patch applied. On Tue, Sep 4, 2012 at 10:45 AM, Akshay Joshi wrote: > Hi Dave > > I have fixed one crash which occurs when user clicks on help button of > Options dialog. Attached is the patch. > Please review it and if it looks good then can you please commit it. > > -- > Akshay Joshi >

Re: [pgadmin-hackers] patch for "Sequence: calculate next value to be expected"

2012-09-04 Thread Dave Page
Hi On Tue, Sep 4, 2012 at 5:19 AM, Quan Zongliang wrote: > Hi, > > Please find the attachments. > > I try to make a enhancement to sequence. > As my understanding, add a property item to properties pane. > The nextValue is lastValue + increment; > > Is it right? If looks right - but the patches

Re: [pgadmin-hackers] pgAgent Database Name Limitation

2012-09-04 Thread Martin French
> > connInfo connInfo::getConnectionInfo(wxString connStr) > > { > > connInfo cnInfo; > > > > wxRegEx propertyExp; > > > > // Remove the white-space(s) to match the following format > > // i.e. prop=value > > bool res = propertyExp.Compile(wxT("(([ ]*[\t]*)+)

Re: [pgadmin-hackers] little patch for "Detect serial columns from pg_depend" and bugfix

2012-09-04 Thread Dave Page
Hi On Tue, Sep 4, 2012 at 5:03 AM, Quan Zongliang wrote: > Hi, > > Please find the attachments. > > pgColumn.patch: > > Detect serial columns from pg_depend, not column default (observe deviating > serial name) This patch does not apply: raptor:pgAdmin3 dpage$ git apply ~/Downloads/pgColumn.p

Re: [pgadmin-hackers] pgAgent Database Name Limitation

2012-09-04 Thread Dave Page
On Tue, Sep 4, 2012 at 12:00 PM, Martin French wrote: > >> > connInfo connInfo::getConnectionInfo(wxString connStr) >> > { >> > connInfo cnInfo; >> > >> > wxRegEx propertyExp; >> > >> > // Remove the white-space(s) to match the following format >> > // i.e. prop=val

[pgadmin-hackers] Unable to create new function if "Owner" or "Comment" is specified.

2012-09-04 Thread Sachin Srivastava
Hi, Due to re-quoting of already quoted schema qualified function name in the "ALTER FUNCTION OWNER to " query while adding a new function we get an error about function name not found. Attached is a patch that fixes the issue. -- Regards, Sachin Srivastava EnterpriseDB, India function_error

[pgadmin-hackers] pgAdmin III commit: Fix issues with my old index commit

2012-09-04 Thread Guillaume Lelarge
Fix issues with my old index commit The issue was that we included the name of the table with the name of the index, instead of the name of the schema. It fixes SQL script, and maintenance tools. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=c

Re: [pgadmin-hackers] pgAdmin III commit: Lots of work on domains, and check constraints

2012-09-04 Thread Guillaume Lelarge
On Mon, 2012-09-03 at 22:41 +0200, Guillaume Lelarge wrote: > On Mon, 2012-09-03 at 08:54 +0100, Dave Page wrote: > > On Fri, Aug 31, 2012 at 10:57 PM, Guillaume Lelarge > > wrote: > > > On Sun, 2012-08-26 at 18:18 +0200, Guillaume Lelarge wrote: > > >> On Mon, 2012-07-23 at 08:38 +0100, Dave Page

[pgadmin-hackers] pgAdmin III commit: Fix issues with my old index commit

2012-09-04 Thread Guillaume Lelarge
Fix issues with my old index commit The issue was that we included the name of the table with the name of the index, instead of the name of the schema. It fixes SQL script, and maintenance tools. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=

[pgadmin-hackers] pgAdmin III commit: Update japanese translation

2012-09-04 Thread Guillaume Lelarge
Update japanese translation Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e6100d6f7308cb3e042f3d84a86c3bc0446a083f Author: Quan Zongliang Modified Files -- i18n/ja_JP/pgadmin3.mo | Bin 276264 -> 301131 bytes i18n/ja_

[pgadmin-hackers] pgAdmin III commit: Update japanese translation

2012-09-04 Thread Guillaume Lelarge
Update japanese translation Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cc1272ca362a13304f51fd9b0fb6b9df4e09bdc2 Author: Quan Zongliang Modified Files -- i18n/ja_JP/pgadmin3.mo | Bin 276264 -> 301131 bytes i18n/ja_JP/pgadmin3.

Re: [pgadmin-hackers] patch for "Sequence: calculate next value to be expected"

2012-09-04 Thread Quan Zongliang
On 2012/9/4 18:55, Dave Page wrote: Hi On Tue, Sep 4, 2012 at 5:19 AM, Quan Zongliang wrote: Hi, Please find the attachments. I try to make a enhancement to sequence. As my understanding, add a property item to properties pane. The nextValue is lastValue + increment; Is it right? If looks

Re: [pgadmin-hackers] patch for "Sequence: calculate next value to be expected"

2012-09-04 Thread Quan Zongliang
On 2012/9/5 9:02, Quan Zongliang wrote: On 2012/9/4 18:55, Dave Page wrote: Hi On Tue, Sep 4, 2012 at 5:19 AM, Quan Zongliang wrote: Hi, Please find the attachments. I try to make a enhancement to sequence. As my understanding, add a property item to properties pane. The nextValue is lastV

Re: [pgadmin-hackers] little patch for "Detect serial columns from pg_depend" and bugfix

2012-09-04 Thread Quan Zongliang
On 2012/9/4 19:02, Dave Page wrote: Hi On Tue, Sep 4, 2012 at 5:03 AM, Quan Zongliang wrote: Hi, Please find the attachments. pgColumn.patch: Detect serial columns from pg_depend, not column default (observe deviating serial name) This patch does not apply: raptor:pgAdmin3 dpage$ git a