Re: [pgadmin-hackers] pgadmin3.hhp.cached

On Fri, Jul 19, 2013 at 10:29 PM, Richard PALO wrote: > I needed to undo the following workaround put in Makefile.am: >> >> # We need to ensure the help cache is world writeable >> install-data-hook: >> - touch $(help_dir)/docs/en_US/pgadmin3.hhp.cached >> - chmod 0666 $(help_dir)/do

[pgadmin-hackers] Fixed some minor issues in frmImport

Hi Dave I have fixed following minor issues in frmImport class - Unable to open the help when clicked on Help button of Import dialog. - Fixed syntax error when deselect all the column and click on "Import" button. I have put a message box to fix the issue. Please review it and if looks

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Hi Dinesh I have just started reviewing your code and found on issue where any changes made on Event Trigger dialog won't be saved. After looking at the code, you haven't override the ::OnOK() function in dlgEventTrigger.cpp. Can you please fix this and resend the new patch. On Wed, Jul 10, 2013

[pgadmin-hackers] Search Object dialog Help button issue

Hi Dave, It was noticed that on clicking the Help button on the Search Object dialog, the Help dialog was not opening the correct help page related to Search Object dialog. Attached is a patch that fixes this issue. Let me know in case of any concerns with the attached patch. Thanks, -- regard

[pgadmin-hackers] pgAdmin III commit: Fix path the the Search Objects help doc.

Fix path the the Search Objects help doc. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c076a972576b85747d28900f3997c6eb9cfc6473 Author: Dhiraj Chawla Modified Files -- CHANGELOG |1 + pgadmin/dlg/dlgSear

[pgadmin-hackers] pgAdmin III commit: Fix path the the Search Objects help doc.

Fix path the the Search Objects help doc. Conflicts: CHANGELOG Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=337815b78312c757aa45bae472f2ac0ddc087ce2 Author: Dhiraj Chawla Modified Files -- CHANGELOG

Re: [pgadmin-hackers] Search Object dialog Help button issue

Thanks, applied. On Mon, Jul 22, 2013 at 1:57 PM, Dhiraj Chawla wrote: > Hi Dave, > > It was noticed that on clicking the Help button on the Search Object dialog, > the Help dialog was not opening the correct help page related to Search > Object dialog. Attached is a patch that fixes this issue.

[pgadmin-hackers] pgAdmin III commit: Fix the help path on the import dialogue and improv

Fix the help path on the import dialogue and improve the error handling. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=18604f0827db2788c24961216218cc2db366f10c Author: Akshay Joshi Modified Files -- CHANGELOG

[pgadmin-hackers] pgAdmin III commit: Fix the help path on the import dialogue and improv

Fix the help path on the import dialogue and improve the error handling. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f6c640646709a5e0b98df5e4bb5e69c54b958834 Author: Akshay Joshi Modified Files -- CHANGELOG

Re: [pgadmin-hackers] Fixed some minor issues in frmImport

Thanks, patch applied. On Mon, Jul 22, 2013 at 10:31 AM, Akshay Joshi wrote: > Hi Dave > > I have fixed following minor issues in frmImport class > > Unable to open the help when clicked on Help button of Import dialog. > Fixed syntax error when deselect all the column and click on "Import" > but

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

Akshay, please let me know when your review is complete and then I'll take a look. On Mon, Jul 22, 2013 at 2:09 PM, Dinesh Kumar wrote: > Hi Akshay, > > Thank you so much for correcting me on this. It's my bad to forgot the > naming convention in the code. Now, ::OnOK() is get populating the re

Re: [pgadmin-hackers] Search Object dialog Help button issue

Thanks Dave. On Mon, Jul 22, 2013 at 6:37 PM, Dave Page wrote: > Thanks, applied. > > On Mon, Jul 22, 2013 at 1:57 PM, Dhiraj Chawla > wrote: > > Hi Dave, > > > > It was noticed that on clicking the Help button on the Search Object > dialog, > > the Help dialog was not opening the correct help

[pgadmin-hackers] pgAdmin III commit: Avoid using a Help cache file that needs to be worl

Avoid using a Help cache file that needs to be world writeable, and ensure sed is happy when post-processing helpfiles. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=02a0b814ca3714a5fc7f34c51b44f6aab51b951c Modified Files ---

[pgadmin-hackers] pgAdmin III commit: Avoid using a Help cache file that needs to be worl

Avoid using a Help cache file that needs to be world writeable, and ensure sed is happy when post-processing helpfiles. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=fb53e8357eb9772db2d1b14c8a531c7908e5b442 Modified Files -- CHAN