Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

2015-06-14 Thread John Obaterspok
Hello Sanket, Just enter "rollback" and exec The while(wxIsalpha(query.GetChar(wordlen))) wordlen++; As the 'k' in rollback is a char it also tries the next character (worklen = 8) which causes out of bounds check. -- john 2015-06-12 13:25 GMT+02:00 Sanket Mehta : > Hi John, > > I hav

Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

2015-06-14 Thread Sanket Mehta
Hi John, I have tried the same, I am not getting any out of the bounds error, it simply comes out of the while loop. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Sun, Jun 14, 2015 at 2:00 PM, John Obaterspok wrote: > Hello Sanket, > > Just enter "rollback" and exec > > The >

Re: [pgadmin-hackers] SSH error messages not shown

2015-06-14 Thread Dave Page
Akshay, can you look into this please? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 13 Jun 2015, at 16:22, Jacek Wielemborek wrote: > > Hi, > > When an libssh2 call fails, pgAdmin III just

Re: [pgadmin-hackers] valgrind complains a lot when trying to establish an SSH tunnel while giving wrong key

2015-06-14 Thread Dave Page
Akshay, can you look into this please? Do we need to update the libssh code from upstream? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 13 Jun 2015, at 16:20, Jacek Wielemborek wrote: > > H

Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

2015-06-14 Thread Ashesh Vashi
John, As I understand correctly, 8th character will be '\0' (null character). Hence - wxIsAlpha() will come out of the loop in general. But - it is possible every platform has different behaviour for wxWidgets. Can you please be specific about the operating system? -- Thanks & Regards, Ashesh V

Re: [pgadmin-hackers] SSH error messages not shown

2015-06-14 Thread Akshay Joshi
Sure. On Sun, Jun 14, 2015 at 3:13 PM, Dave Page wrote: > Akshay, can you look into this please? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On 13 Jun 2015, at 16:22, Jacek Wiel

Re: [pgadmin-hackers] valgrind complains a lot when trying to establish an SSH tunnel while giving wrong key

2015-06-14 Thread Akshay Joshi
Sure. On Sun, Jun 14, 2015 at 3:13 PM, Dave Page wrote: > Akshay, can you look into this please? Do we need to update the libssh > code from upstream? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com > The Enterprise Postg

Re: [pgadmin-hackers] SSH error messages not shown

2015-06-14 Thread Akshay Joshi
Hi Jacek On Mon, Jun 15, 2015 at 10:40 AM, Akshay Joshi wrote: > Sure. > > On Sun, Jun 14, 2015 at 3:13 PM, Dave Page wrote: > >> Akshay, can you look into this please? >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK:http://www.enterprisedb.