Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

2015-06-15 Thread John Obaterspok
I'm using Visual Studio 2010 on Windows 7 x64. wxWidgets is wxMSW-3.0.2. It might be an assert that triggers in wxwidgets, but ignoring it just causes pgadmin to terminate. -- john 2015-06-14 18:44 GMT+02:00 Ashesh Vashi : > John, > > As I understand correctly, 8th character will be '\0' (null c

Re: [pgadmin-hackers] [PATCH] Add ElapsedTimeToString to format execution time in a more readable manner (instead of showing everything as msec)

2015-06-15 Thread John Obaterspok
Hi, Attached is an updated patch. -- john 2015-06-12 6:50 GMT+02:00 Ashesh Vashi : > Hi John, > > Can you please add comments for the below piece of code for explanation? > - > *@@ -3088,13 +3090,22 @@ void frmQuery::OnTimer(wxTimerEvent &event)* > * }* > > * // Increase the granularity f

[pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

2015-06-15 Thread John Obaterspok
Hello, With the newly added option to disable auto commit (hurray) I really missed commit/rollback toolbar buttons. Attached patch adds this. -- john 0001-Add-Commit-Rollback-toolbar-action.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

2015-06-15 Thread Sanket Mehta
Hi, We were using wxWidgets 2.8.12 so that may be the issue. I will now try with wxwidgets 3.0.2 and let you know. Btw apart from this issue, we have also resolved other issues in the code, i will soon send a new patch for the same. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon