[pgadmin-hackers] pgAdmin 4 commit: Improvise the PostgreSQL driver to fetch the status m

2016-04-05 Thread Ashesh Vashi
Improvise the PostgreSQL driver to fetch the status message. At the moment, we will only allow to fetch status messages from the asynchronous connection only, later - we may implement to fetch the status message from the normal connection too. Branch -- master Details --- http://git.post

Re: [pgadmin-hackers] [pgAdmin4][psycopg2] - Modified status message implementation

2016-04-05 Thread Ashesh Vashi
On Mon, Apr 4, 2016 at 4:53 PM, Neel Patel wrote: > Hi, > > Please find attached patch file which modified the earlier statusmessage > implementation. > > *Previous implementation:- * > > statusmessage was implemented inside the poll function and if poll result > row is greater than zero then sta

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

2016-04-05 Thread Khushboo Vashi
Hi, Please find updated patch for the Foreign Table Module. This patch is dependent on 1. Backgrid Depscell Patch, (submitted by me) 2. NodeAjaxOptionsCell Transform change patch, on which Ashesh and Murtuza are working Thanks, Khushboo On Wed, Feb 24, 2016 at 2:57 PM, Khushboo Vashi < khush

[pgadmin-hackers] pgAdmin 4 commit: Honour the 'show_system_object' flag when generating

2016-04-05 Thread Ashesh Vashi
Honour the 'show_system_object' flag when generating the list of schema nodes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=40165f2d1e3286dc3f9fa8c924bd6b3603abdaa5 Modified Files -- .../databases/schemas/templates/schema/pg/9.1_

[pgadmin-hackers] pgAdmin 4 commit: Add support for functions and procedures.

2016-04-05 Thread Dave Page
Add support for functions and procedures. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ed7015ebc92c161a15e0b959846286967142f3c Author: Khushboo Vashi Modified Files -- .../databases/schemas/functions/__init__.py| 1314 +

[pgadmin-hackers] pgAdmin 4 commit: Utility functions for trigger and rule nodes, central

2016-04-05 Thread Dave Page
Utility functions for trigger and rule nodes, centralised because they're also utilised by the view node. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1eb3fd9d59eaa6d2324d93511eb27c325820f94 Author: Surinder Kumar Modified Files -

Re: [pgadmin-hackers] [pgAdmin4] PATCH: Added Utility functions for triggers node and rules node

2016-04-05 Thread Dave Page
Thanks - committed. On Wed, Mar 23, 2016 at 3:43 PM, Surinder Kumar wrote: > Hi, > > Trigger and Rules nodes have functions which are also used by view node. > View node use them while generating reverse engineering SQL for respective > nodes. > so they are moved into schema/utils.py > > > Please

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-04-05 Thread Dave Page
Thanks - committed. On Mon, Mar 28, 2016 at 8:26 AM, Khushboo Vashi wrote: > Hi, > > Please find updated patch for the functions/procedures module. > > Thanks, > Khushboo > > On Wed, Mar 23, 2016 at 5:33 PM, Dave Page wrote: >> >> On Tue, Mar 22, 2016 at 10:51 AM, Khushboo Vashi >> wrote: >> >

[pgadmin-hackers] pgAdmin 4 commit: Add support for domains.

2016-04-05 Thread Dave Page
Add support for domains. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2add0155a3ff1de68bebfa78eed5b4d2248d34e9 Author: Khushboo Vashi Modified Files -- .../servers/databases/schemas/domains/__init__.py | 824 +++

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-04-05 Thread Dave Page
Thanks - committed. On Thu, Mar 24, 2016 at 3:25 PM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch for the Domains Module. > > Thanks, > Khushboo > > On Thu, Mar 24, 2016 at 5:29 PM, Dave Page wrote: >> >> Hi >> >> You're going to hate me for this >> >> - I added an

[pgadmin-hackers] pgAdmin 4 commit: Revert style change introduced in commit f7e4e8bea010

2016-04-05 Thread Dave Page
Revert style change introduced in commit f7e4e8bea01074fffd0f6f8fc8570a7518ff9137 as it's removing padding from all grids. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=34ef5790ba2476e9594a6997ab0b5c7232e3d902 Modified Files --

Re: [pgadmin-hackers] Patch: Added select2cell editor for backgrid [pgAdmin4]

2016-04-05 Thread Dave Page
I've reverted the change to overrides.css that this patch made as it was that that was causing the padding issue on backgrid that we noted this morning when looking at the debugger. +} + +.select2-cell .select2-container > .backgrid th, .backgrid td +{ +padding: 0px; Please fix in a less blan

[pgadmin-hackers] pgAdmin 4 commit: Minor adjustment to the menu font sizing.

2016-04-05 Thread Dave Page
Minor adjustment to the menu font sizing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=01d6b46838a2befc6cf8e1c0a28188c058d9f94c Modified Files -- web/pgadmin/static/css/wcDocker/Themes/pgadmin.css | 8 1 file changed, 4 i

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-04-05 Thread Thom Brown
I'm getting weirdness with this node. See the attached picture, where it shows the servers node appearing under functions. Thom On 5 April 2016 at 16:21, Dave Page wrote: > Thanks - committed. > > On Mon, Mar 28, 2016 at 8:26 AM, Khushboo Vashi > wrote: >> Hi, >> >> Please find updated patch f

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-04-05 Thread Dave Page
On Tue, Apr 5, 2016 at 5:18 PM, Thom Brown wrote: > I'm getting weirdness with this node. See the attached picture, where > it shows the servers node appearing under functions. Make sure you've restarted the python server, and do a hard-refresh in your browser. That normally clears that issue up

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-05 Thread Dave Page
Hi On Tue, Apr 5, 2016 at 12:40 PM, Neel Patel wrote: > Hi, > > Please find attached debugger v1 patch. To test this patch we need to apply > the "function" module patch submitted by Khushboo. > > For the debugger functionality, direct and indirect debugging is working as > per pgadmin3 except be

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-04-05 Thread Thom Brown
On 5 April 2016 at 17:20, Dave Page wrote: > On Tue, Apr 5, 2016 at 5:18 PM, Thom Brown wrote: >> I'm getting weirdness with this node. See the attached picture, where >> it shows the servers node appearing under functions. > > Make sure you've restarted the python server, and do a hard-refresh

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-05 Thread Neel Patel
Hi Dave, We will fix the error "KeyError: 'session_id'" but regarding the blank tab, we have tried with PostgreSQL 9.4 with both the version of python (2.7 & 3.4) but we are not able to reproduce the issue. Below are some of the questions to debug the issue. - Is it only reproduce on PostgreS

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-05 Thread Neel Patel
One more additional information. Follow the below steps and send us pgAdmin4.log file. - Browse till function which we want to debug. Do not click on the "Debug" context menu. - Stop the server - Enable the "Debug" option in the config file under "web" folder. - Start the server.

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-05 Thread Neel Patel
Hi Dave, Updated above information. We want this pgadmin4 log information to debug the debugger blank tab open issue. Thanks, Neel Patel On Wed, Apr 6, 2016 at 11:50 AM, Neel Patel wrote: > One more additional information. > > Follow the below steps and send us pgAdmin4.log file. > >- Brow