Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-06 Thread Neel Patel
Hi Dave, I got the root cause. Issue will reproduce when we applied Akshay's query tool patch. Issue was once the panel was initialized, HTML file was not getting loaded in to the panel due to the change in frame.js. Both query tool and debugger patch file contains the change in "frame.js" file.

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-06 Thread Dave Page
On Wed, Apr 6, 2016 at 8:57 AM, Neel Patel wrote: > Hi Dave, > > I got the root cause. Issue will reproduce when we applied Akshay's query > tool patch. > Issue was once the panel was initialized, HTML file was not getting loaded > in to the panel due to the change in frame.js. > > Both query tool

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Backgrid StringDepsCell

2016-04-06 Thread Ashesh Vashi
Hi Khushboo, On Tue, Apr 5, 2016 at 10:59 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Ashesh, > > I have changed the function name (from *render_deps* to *updateUIDeps*), > which will be called on the dependent field change, as per your suggestion. > I've updated the patch.

[pgadmin-hackers] pgAdmin 4 commit: Added support for 'array' type in the schema of Node

2016-04-06 Thread Ashesh Vashi
Added support for 'array' type in the schema of Node model to treat as an object, and handle it well in the toJSON(..) with session transformation. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ba0814377e9039c0d057b236cc3581c4d6fee87 Modifie

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

2016-04-06 Thread Surinder Kumar
Hi PFA updated patch with resolved review comments. On Tue, Apr 5, 2016 at 11:06 AM, Ashesh Vashi wrote: > On Wed, Mar 30, 2016 at 5:14 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi, >> >> Please find updated patch. >> >> This patch has following changes: >> 1. Improved

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-06 Thread Dave Page
Hi On Tue, Apr 5, 2016 at 10:20 AM, Akshay Joshi wrote: > Hi All > > I have implemented the Data Grid and Query Tool as one component. > > *Functionality working for Data Grid*: > >- Add/Update/Delete rows if object is editable. >- Copy row >- Paste row >- Refresh >- Client F