Re: [pgadmin-hackers] [pgAdmin4]: Query tool and debugger height issue

2016-05-23 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, May 23, 2016 at 12:05 PM, Neel Patel wrote: > Hi, > > Because of th

[pgadmin-hackers] pgAdmin 4 commit: Fixed the issue related to set proper height, width o

2016-05-23 Thread Ashesh Vashi
Fixed the issue related to set proper height, width of the div of a frame in wcFrame. This is only happens only in the Firefox browser. This was regression of the commit-id: 9a832086c5c4c0dda51c43edd7fc4f40dda63a0c. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4

[pgadmin-hackers] [pgAdmin4][Patch]: Auto redirect to page on opening FileManager when used in Fieldset

2016-05-23 Thread Surinder Kumar
Hi, *Issue*: When FileControl is used in * *tag, it auto redirects to some url when FileManager is opened up. *Reason: *The issue was due to ** tag, when a jQuery event which is bound to an element gets fired, the event callback then delegate the click event to the parent element which is form ta

[pgadmin-hackers] pgAdmin 4 commit: Fixes the issue about redirection to undesirable URL

2016-05-23 Thread Ashesh Vashi
Fixes the issue about redirection to undesirable URL when clicked on the file control selection button. All our views are inherited from the Backform.Form (a extended Backbone.View), which has an tag element set to 'form'. The default action for a button in form is to submit the data, and that res

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Auto redirect to page on opening FileManager when used in Fieldset

2016-05-23 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, May 23, 2016 at 4:15 PM, Surinder Kumar < surinder.ku...@enterprisedb

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-23 Thread Murtuza Zabuawala
Hi, PFA patch, which will fixes below mentioned issues, - Fixed all the review comments given by Dave on tables & its child nodes. *Additional enhancements* - In Index node, We have updated the way columns were added, earlier it was using subnode control now we can insert/update values in-pl

[pgadmin-hackers] pgAdmin 4 commit: Initialize the msg to None as we may not have msg ava

2016-05-23 Thread Ashesh Vashi
Initialize the msg to None as we may not have msg available, when current version, and latest released version is matching. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=98fa93413d5db14434c0144b3a3d7bfcb69bba80 Modified Files -- w

[pgadmin-hackers] PATCH: To fix condition checking in Backup utility (pgAdmin4)

2016-05-23 Thread Murtuza Zabuawala
Hi, PFA minor patch to fixed condition checking in Backup utility. Thanks to Neel for reporting this. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Backup_updated_condition.patch Description: Binary data -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: [Backup] Checking for 'only_data' parameter before ac

2016-05-23 Thread Ashesh Vashi
[Backup] Checking for 'only_data' parameter before accessing it. Reported by Neel Patel Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0840e6af2dc089e7e640e2f1dc38c5119cebf47e Modified Files -- web/pgadmin/tools/backup/__init__.py

Re: [pgadmin-hackers] PATCH: To fix condition checking in Backup utility (pgAdmin4)

2016-05-23 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, May 24, 2016 at 11:57 AM, Murtuza Zabuawala < murtuza.zabuaw...@enter

[pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

2016-05-23 Thread Harshal Dhumal
Hi, PFA patch for server and database node: Issue fixed: Added node type check in is_connected check. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/js/databases.js b/we

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1218 - Backup table not working.

2016-05-23 Thread Ashesh Vashi
Fixes #1218 - Backup table not working. Send parameters in proper format to work it well with table backup. Thanks Fahar for reporting it. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dca6951e745c7b8a363a55ec6ca42c4aa359c459 Modified Files

Re: [pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

2016-05-23 Thread Ashesh Vashi
On Tue, May 24, 2016 at 12:06 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > > PFA patch for server and database node: > > Issue fixed: Added node type check in is_connected check. > Can you please describe the situation, when these functions are being executed outside the

Re: [pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

2016-05-23 Thread Harshal Dhumal
Hi Ashesh, For change server password we have added check is_connected() in server.js. Also same function is also available in database.js. So it was causing change server password menu to enable on database node as well if database is connected. This issue will appear for any other menu if that