Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-26 Thread Ashesh Vashi
Thanks. On May 25, 2016 21:01, "Thom Brown" wrote: > Thanks. I've raised all of these in tickets 1231 to 1237. > > Thom > > On 25 May 2016 at 04:23, Ashesh Vashi > wrote: > >> Hi Thom, >> >> Can you please create RM cases for the same, it will be easy to track >> those issues? >> We're using "h

[pgadmin-hackers] PATCH: To fix issue in procedure node (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in procedure node where only create new procedure option is available to user (Drop/Properties etc were missing). (RM-1123) Additional enhancements: - Remove arguments from drop statments as procedure can drop only by its name. - Remove "Drop cascade" option as proc

[pgadmin-hackers] [pgAdmin4][Patch]: Load nodes under schema at database level

2016-05-26 Thread Surinder Kumar
Hi, *Issue*: Following nodes : 1. *domains* 2. *foreign tables* 3. *fts configurations* 4. *fts dictionary and* 5. *functions* lists server nodes instead of their child nodes which is wrong. It is because their javascript files are set to load at schema level, but they should loa

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-26 Thread Thom Brown
On 26 May 2016 at 11:20, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch for RM#1231 & RM#1237. > > Additionally I have shifted 'Advanced tab' after columns & constraint tab. > > > @Thom, > > Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to > p

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi, PFA patch for RM#1231 & RM#1237. Additionally I have shifted 'Advanced tab' after columns & constraint tab. @Thom, Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to populate "Of type" combo box as given below. I was not able to find a way to differentiate between table &

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi, PFA updated patch which will also include new query given by Thom for "Of type" drop-down. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, May 26, 2016 at 4:04 PM, Thom Brown wrote: > On 26 May 2016 at 11

Re: [pgadmin-hackers] Documentation patch for pgAdmin 4

2016-05-26 Thread Dave Page
Hi On Wed, May 25, 2016 at 3:26 PM, Susan Douglas wrote: > Hi All, > > I've attached a patch that adds new dialog descriptions to the pgAdmin 4 > documentation... Thanks! I see the following issues when building the docs with this patch. Can you please fix and resend? /Users/dpage/git/pgadmin4

[pgadmin-hackers] pgAdmin 4 commit: Auto-run setup.py if the config database doesn't exis

2016-05-26 Thread Dave Page
Auto-run setup.py if the config database doesn't exist. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0dabbf3dad6e8e84f1a51c59ee4ed971ce01d1b9 Author: Paresh More Modified Files -- web/pgAdmin4.py | 11 --- 1 file changed,

[pgadmin-hackers] PATCH: To fix an issue with port validation (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi, PFA patch to fix an issue where we are allowing to enter port till 65534 and not 65535. (RM-1147) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1147.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgad

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

2016-05-26 Thread Dave Page
Hi On Fri, May 20, 2016 at 9:33 AM, Paresh More wrote: > Hello Dave. > > Attached are two patch for pgAdmin4-windows > > pgAdmin4_createDB.patch > - patch for pgAdmin4.py to autocreate database configuration if does not > exist. > - Now pgadmin.db would be not be bundled with installer, it would

[pgadmin-hackers] pgAdmin 4 commit: s/domain-constraints/domain_constraints for consisten

2016-05-26 Thread Dave Page
s/domain-constraints/domain_constraints for consistency. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7aea8f85364b3bfdf7769168165a4a8d05e3cadb Modified Files -- .../schemas/domains/domain-constraints/__init__.py | 690 ---

[pgadmin-hackers] pgAdmin 4 commit: Additional docs from Susan.

2016-05-26 Thread Dave Page
Additional docs from Susan. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b85fa58344d7c68c60a2fd433cb65ea137a3fc5a Modified Files -- docs/en_US/domain_dialog.rst | 81 docs/en_US/foreign_server_d

[pgadmin-hackers] PATCH: To fix issue in removing comments in edit mode (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in function/procedure/trigger-function node while updating comments. (RM#1142) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1142.patch Description: Binary data -- Sent via pgadmin-hackers mailing l

[pgadmin-hackers] PATCH: To fix issue in updating comments (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in updating comments in foreign data wrapper/foreign table. (RM#1143) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1143.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadm