Re: [pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

Hi On Wed, Jul 6, 2016 at 9:12 AM, Neel Patel wrote: > Hi Dave, > > I have tried to fix most of the review comments. I have modified the patch > on top of your changes. Please find attached updated patch file. > Find my comments inline. Can you please review and let us know your feedback > ? Th

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1435 - "Move to last page" should also scroll to end

Hi On Wed, Jul 6, 2016 at 9:16 AM, Surinder Kumar wrote: > Hi > > Please find attached patch with fix. > Every time either a new row is added or pasted. Scroll to the bottom of the > table div. > > Please review It doesn't seem to work for me in either Safari or Chrome. -- Dave Page Blog: http

Re: [pgadmin-hackers] [Patch] Fix Unicode in errmsg

Thanks Magnun. Ashesh, can you review this please, and check if similar changes are needed elsewhere? Thanks. On Wed, Jul 6, 2016 at 7:55 PM, Magnun Leno (Pessoal) wrote: > Hi All, > > Just a small patch to fix server addition/connection errors when using > non-ascii languages (pt_BR in my case

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Ashesh, can you review/commit please? Thanks. On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > By mistake I deleted a line which was not supposed to be deleted, and that > line of code was initialization of select2. > > -- > *Harshal Dhumal* > *S

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1435 - "Move to last page" should also scroll to end

On Thu, Jul 7, 2016 at 2:30 PM, Dave Page wrote: > Hi > > On Wed, Jul 6, 2016 at 9:16 AM, Surinder Kumar > wrote: > > Hi > > > > Please find attached patch with fix. > > Every time either a new row is added or pasted. Scroll to the bottom of > the > > table div. > > > > Please review > > It does

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1435 - "Move to last page" should also scroll to end

Thanks, applied. On Thu, Jul 7, 2016 at 11:07 AM, Surinder Kumar wrote: > On Thu, Jul 7, 2016 at 2:30 PM, Dave Page wrote: >> >> Hi >> >> On Wed, Jul 6, 2016 at 9:16 AM, Surinder Kumar >> wrote: >> > Hi >> > >> > Please find attached patch with fix. >> > Every time either a new row is added or

[pgadmin-hackers] pgAdmin 4 commit: Scroll to the new row when adding one in the query to

Scroll to the new row when adding one in the query tool. Fixes #1435 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=52d1af63a547d8aaeb9a4fbb63e45011e57bab18 Author: Surinder Kumar Modified Files -- .../sqleditor/templates/sqledito

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Sure - I will do. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jul 7, 2016 at 2:33 PM, Dave Page wrote: > Ashesh, can you review/com

Re: [pgadmin-hackers] [Patch] Fix Unicode in errmsg

Sure - I will do. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jul 7, 2016 at 2:31 PM, Dave Page wrote: > Thanks Magnun. > > Ashesh,

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Wed, Jul 6, 2016 at 5:40 PM, Dave Page wrote: > >> Hi, >> >> I think we need more changes than just that; >> >> - The path at the top should not be editable (it should be greyed in fact) >> > Ok > >> >>

[pgadmin-hackers] Where do I submit patches?

I submitted a bugfix to this mailing list, didn't see a response, but *did* see references to issue numbers. Where do you file issues? I came to this mailing list from pgadmin.org. -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:

Re: [pgadmin-hackers] Where do I submit patches?

> On 7 Jul 2016, at 17:35, Stuart Gathman wrote: > > I submitted a bugfix to this mailing list, didn't see a response, but > *did* see references to issue numbers. Where do you file issues? I > came to this mailing list from pgadmin.org. I don't recall seeing that - can you send it again plea

Re: [pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

Hi Dave, Please find attached patch file for the fix of crash and comment text. Downloading cancel request was not handled properly and due to that application was getting crashed. Do review it and let us know for comments. Thanks, Neel Patel On Thu, Jul 7, 2016 at 2:13 PM, Dave Page wrote: >